Hello everyone!

Recently I've received two crash reports for Geeqie 1.1 (patched a bit) from
somebody who had browsed through a collection of large TIFF files (>25 MB).
The crash is not reproducible, but might be related to skipping to the next
file while loading the current file is not done.

The symptoms are similar. While gdk-pixbuf mentions

  width = 7898
  height = 3318

Geeqie's own code in pr_zoom_clamp at pixbuf-renderer.c:1755 refers to

  w = 0
  h = 0

but the reason for the crash is it somehow uses an invalid pixbuf renderer,
when trying to call  pr->renderer->invalidate_all(pr->renderer), and segfaults.

  https://bugzilla.redhat.com/attachment.cgi?id=960178

The call of pr_zoom_clamp() leads back to pixbuf_renderer_set_size_early(),
unless I misread the code.

The second time the user has encountered a crash, it ran into a NULL pixbuf
renderer pointer early in pixbuf_renderer_set_size_early(),

  #0  pixbuf_renderer_set_size_early (pr=0x0, width=3465, height=5202)
  at pixbuf-renderer.c:2916
        zoom = 1

  2915          zoom = pixbuf_renderer_zoom_get(pr);
  2916          pr->image_width = width;
  2917          pr->image_height = height;

and interestingly, pixbuf_renderer_zoom_get(pr) tries to protect against an
invalid "pr" ptr,

        g_return_val_if_fail(IS_PIXBUF_RENDERER(pr), 1.0);

but that doesn't help outside that function, of course.

  https://bugzilla.redhat.com/attachment.cgi?id=962883


It looks like some sort of race to me.
Any ideas, anyone?

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Reply via email to