Re: [Geeqie-devel] Bad optimization in renderer-tiles.c

2015-08-11 Thread Michael Schwendt 
On Tue, 11 Aug 2015 23:07:06 +0200, Uwe Ohse wrote:

 Hello,
 
 in src/renderer-tiles.c there is a really bad optimization, starting at about 
 line 1336 (current qeeqie.org git):
 
 1336 else if ((pr-zoom == 1.0 || pr-scale == 1.0) 
 1337  pr-aspect_ratio == 1.0 
 1338  !has_alpha 
 1339  orientation == EXIF_ORIENTATION_TOP_LEFT 
 1340  !(pr-func_post_process  !(pr-post_process_slow  
 fast)) 
 1341  !(rt-stereo_mode  PR_STEREO_ANAGLYPH))
 1342 {
 1343 /* special case: faster, simple, scale 1.0, base 
 orientation, no postprocessing */
 1344 cairo_t *cr;
 1345 cr = cairo_create(it-surface);
 1346 cairo_rectangle (cr, x, y, w, h);
 1347 gdk_cairo_set_source_pixbuf(cr, pr-pixbuf, -it-x - 
 GET_RIGHT_PIXBUF_OFFSET(rt), -it-y);
 1348 cairo_fill (cr);
 1349 cairo_destroy (cr);
 1350 }
 
 it looks good, but is dead slow, for each and every call to 
 gdk_cairo_set_source_pixbuf takes at least 15 milliseconds on my not
 really slow machine, which amounts to over 2 seconds if 144 tiles have to be 
 drawn (tested with many jpegs and a few large pngs).
 
 i propose to remove this optimization until someone fixes it. After removal 
 geeqie is fast, again.
 


http://sourceforge.net/p/geeqie/bugs/213/
( Created: 2014-12-05 )

--
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Bad optimization in renderer-tiles.c

2015-08-11 Thread Uwe Ohse 
Hello,

in src/renderer-tiles.c there is a really bad optimization, starting at about 
line 1336 (current qeeqie.org git):

1336 else if ((pr-zoom == 1.0 || pr-scale == 1.0) 
1337  pr-aspect_ratio == 1.0 
1338  !has_alpha 
1339  orientation == EXIF_ORIENTATION_TOP_LEFT 
1340  !(pr-func_post_process  !(pr-post_process_slow  
fast)) 
1341  !(rt-stereo_mode  PR_STEREO_ANAGLYPH))
1342 {
1343 /* special case: faster, simple, scale 1.0, base 
orientation, no postprocessing */
1344 cairo_t *cr;
1345 cr = cairo_create(it-surface);
1346 cairo_rectangle (cr, x, y, w, h);
1347 gdk_cairo_set_source_pixbuf(cr, pr-pixbuf, -it-x - 
GET_RIGHT_PIXBUF_OFFSET(rt), -it-y);
1348 cairo_fill (cr);
1349 cairo_destroy (cr);
1350 }

it looks good, but is dead slow, for each and every call to 
gdk_cairo_set_source_pixbuf takes at least 15 milliseconds on my not
really slow machine, which amounts to over 2 seconds if 144 tiles have to be 
drawn (tested with many jpegs and a few large pngs).

i propose to remove this optimization until someone fixes it. After removal 
geeqie is fast, again.

Regards, Uwe


--
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] gQview feature lost : properties

2015-08-11 Thread Klaus Ethgen 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Am Di den 19. Mai 2015 um 15:51 schrieb me...@gmx.fr:
 In the old gQview there was a properties feature in the right click on an 
 image. I
 miss it in geeqie, when I have to check the size of a file after resizing it, 
 for example.
 
 Here is a picture to show what I mean: 
 http://citrotux.org/gqview-image-properties.png
 
 
 Would it be possible to add the properties context menu from gqview to geeqie 
 ?

I'll have a look.

Regards
   Klaus
- -- 
Klaus Ethgen  http://www.ethgen.ch/
pub  4096R/4E20AF1C 2011-05-16   Klaus Ethgen kl...@ethgen.de
Fingerprint: 85D4 CA42 952C 949B 1753  62B3 79D0 B06F 4E20 AF1C
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQGcBAEBCgAGBQJVynjKAAoJEKZ8CrGAGfas/ncL/1Nm+pyfyiqO+D14BMb+hsGG
WtVhNmcOVEl+rGaxmjb7qqft/ZrmUQ70FRYuMm7AsSV1OkQXFgXPxy7nKifZcT7o
7EGpQc/j15FnScRO4lqKNrgHZYGWgInk21+xgE0cCWgiOax/p6vBgK5qp0bhOzH4
OUoSPlLfU7iUpgjR3Ul8/F1iAHG1T1p7nRN4Wf2r7OI9pBOfUbQrUkGtJ65ATV0g
iqdT5/HV1Nz6e34XiT/3qj7mCyYGl7wjsOQctgp56gw4ELMPnsu5nQK7NzcV/V4b
dqiGnHbLIgTQrs/OlDRIJIahv+cPkeFCtKj6fvIYM32v3+uzvgJBPHJ7bXusidAh
eJopZzyrewjETB2B+fU52FLJPtbhiebKxjQVoiJm4lWsngD29gVRfQOWDMhD7dWY
6imkArgK1TpPBezZpBZreWxU8SqbeJjmpxFzVVvgffX0Et+b7HoKiGcLatsN8FYP
00Mrm+G8paSeb/DQ3Hz3Z0Ctz5i8d6O/v4onn6+ejQ==
=f1pE
-END PGP SIGNATURE-

--
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

[Geeqie-devel] Version 1.2.1

2015-08-11 Thread Klaus Ethgen 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Hi,

I released version 1.2.1 as a bugfix release.

Regards
   Klaus
- -- 
Klaus Ethgen  http://www.ethgen.ch/
pub  4096R/4E20AF1C 2011-05-16   Klaus Ethgen kl...@ethgen.de
Fingerprint: 85D4 CA42 952C 949B 1753  62B3 79D0 B06F 4E20 AF1C
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQGcBAEBCgAGBQJVynt1AAoJEKZ8CrGAGfasjQ8L/i2G+W/AbN585Jj2VkaFxsHy
wAD6/+J0scBLKaA7UgotRSp+tu4yVcFnwMsQhT8GVvz6BU5+8NUm7gqwp1nmuURE
YbHp+A6iuDy2PJwKE4W/KRaZhsbIWX8A/iGBeGevrDeDAvmb1G4AGQ3Q/75x4nh4
M7xh28u2p25Buj2MW6QrhZkJNawd/VDTxNhqP/+kMfh5lA2/DLAR99WTNej0zs8B
aX3K8pSDrPCqOIE81xjkuQpLOii7kdQoUuX2J1d+JswJYUbMxlzmI3JeGBtekG6B
ILbXyh8UslhIZvurmlEgzlCvFTtsbzEETO3oaucdQiG9CjUaDxiij5bli6V8OJwZ
t/4gWk1QSFsPLQjq5hxyVjv1spOyZOZqayNRZpb4GM7uPLP7AJW1bU6Na5ETutfr
cuxQsmDFu51FYmLY80absMUnWFhggmjnNDPn4Qq6YIUklNc4jfsbrS2noNwV4ZL+
nYwxEY7JdjtNJvH6m1zTqYQXVNdgCBsW/880aCvNiA==
=9op0
-END PGP SIGNATURE-

--
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel

Re: [Geeqie-devel] Bad optimization in renderer-tiles.c

2015-08-11 Thread Klaus Ethgen 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Hi,

Am Di den 11. Aug 2015 um 22:07 schrieb Uwe Ohse:
 in src/renderer-tiles.c there is a really bad optimization, starting at about 
 line 1336 (current qeeqie.org git):
 
 1336 else if ((pr-zoom == 1.0 || pr-scale == 1.0) 
 1337  pr-aspect_ratio == 1.0 
 1338  !has_alpha 
 1339  orientation == EXIF_ORIENTATION_TOP_LEFT 
 1340  !(pr-func_post_process  !(pr-post_process_slow  
 fast)) 
 1341  !(rt-stereo_mode  PR_STEREO_ANAGLYPH))
 1342 {
 1343 /* special case: faster, simple, scale 1.0, base 
 orientation, no postprocessing */
 1344 cairo_t *cr;
 1345 cr = cairo_create(it-surface);
 1346 cairo_rectangle (cr, x, y, w, h);
 1347 gdk_cairo_set_source_pixbuf(cr, pr-pixbuf, -it-x - 
 GET_RIGHT_PIXBUF_OFFSET(rt), -it-y);
 1348 cairo_fill (cr);
 1349 cairo_destroy (cr);
 1350 }
 
 it looks good, but is dead slow, for each and every call to 
 gdk_cairo_set_source_pixbuf takes at least 15 milliseconds on my not
 really slow machine, which amounts to over 2 seconds if 144 tiles have to be 
 drawn (tested with many jpegs and a few large pngs).
 
 i propose to remove this optimization until someone fixes it. After removal 
 geeqie is fast, again.

Thanks for the find. I will put it into git.

Am Di den 11. Aug 2015 um 22:42 schrieb Michael Schwendt:
 http://sourceforge.net/p/geeqie/bugs/213/
 ( Created: 2014-12-05 )

Well, to be honest, I, personally, do not care about sourceforge anymore
since they started to serve maleware with open source stuff. I even do
not have an account anymore. And, frankly, the bugtracker there was
never something great.

But nevertheless, thanks.

Regards
   Klaus
- -- 
Klaus Ethgen  http://www.ethgen.ch/
pub  4096R/4E20AF1C 2011-05-16   Klaus Ethgen kl...@ethgen.de
Fingerprint: 85D4 CA42 952C 949B 1753  62B3 79D0 B06F 4E20 AF1C
-BEGIN PGP SIGNATURE-
Version: GnuPG v1

iQGcBAEBCgAGBQJVynMIAAoJEKZ8CrGAGfascZsMAIs6DPUGCw5J63P6eq43OdXj
uqVMlaYtpOPPHzwIZ25JrguGlvF1JsBfSS6uCHMvIkh/uDzysdAfAeXNhIBT0uPg
AcOnx2cOQD6BYofpzAflbkVanJ153TK54oqdjWFWbe8aZlXBFGdNky9dFXlZQ/dZ
1tGqkY+pJ7SppvTFc6bbkp+WGuIU0DQLNAnEi85V1FLFUPlmYEyGx9BkhlgYJK6h
IRNaU/vK6hkkUuA1d6Uq0qkns7cjIaBLcdvHdabiP/KbGJrWTecebvk4ZTNjjzpr
WQuo89SZRyP+VsLY8yThPQ1vYvhg9qMZDl9TelF8wCEYgHS53NVuULVnGiwFejGx
PMD0SwAEMnhfuHoXt1RcmsmXKRdYWc1VeEZkvcdXOOzJ9rwYNXIlpbObs2s/2gSY
hD3Vq/Idy3b3hxNKU0n8JCpg4VhKdxd0i9Vcqcd7em8rTBCd0OM8NE4HGCOadB3V
o7bZ8RNEJ0iImVJIGizPQr3eNIyKxLZmJiYOOHqF3g==
=9FvS
-END PGP SIGNATURE-

--
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel