Re: [Geeqie-devel] Compiling geeqie on Mac
Martin Proetzsch a écrit :
> Hi again,
>
>
> On Jul 28, 2009, at 10:32 PM, Vladimir Nadvornik wrote:
>
>
>> what() is declared like this:
>>
>> virtual const char* what() const throw() { return msg_.c_str(); }
>>
>> It should not need another c_str(),
>> Which Exiv2 version do you have?
>>
>
> I found out that my exiv2 installation was kind of screwed up.
> Although fink showed me an installed version 0.18, some files still
> remained from a previous 0.12 installation. After having fixed this,
> geeqie compiles using only the patch by Laurent. So, from my point of
> view it is ready for checkin.
>
> Regards,
> Martin
>
>
>
Patch committed as revision 1811.
Thank you for reporting the issue.
--
Zas
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
Hi again,
On Jul 28, 2009, at 10:32 PM, Vladimir Nadvornik wrote:
> what() is declared like this:
>
> virtual const char* what() const throw() { return msg_.c_str(); }
>
> It should not need another c_str(),
> Which Exiv2 version do you have?
I found out that my exiv2 installation was kind of screwed up.
Although fink showed me an installed version 0.18, some files still
remained from a previous 0.12 installation. After having fixed this,
geeqie compiles using only the patch by Laurent. So, from my point of
view it is ready for checkin.
Regards,
Martin
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
Hi Vladimir On Jul 28, 2009, at 10:27 PM, Vladimir Nadvornik wrote: > The patch looks good. > > Another question is if this mmap hack works on non-linux systems. > It is supposed to handle the situation when an image is truncated > during > reading. > It can be tested with this script: > > while true; do > cat 1.jpg >out.jpg > cat 2.jpg >out.jpg > done > > The images 1.jpg and 2.jpg should differ in size, like 50KB and 500KB. > Point geeqie to out.jpg while the script is running and it should > not crash. > I've tried this out and geeqie does not crash. It frequently tries to update the image and gets partial results as expected. Martin -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
On Saturday 25 July 2009 23:27:37 Martin Proetzsch wrote:
> The first one is just an explicit cast (seems to be due a more
> restrictive compiler),
what() is declared like this:
virtual const char* what() const throw() { return msg_.c_str(); }
It should not need another c_str(),
Which Exiv2 version do you have?
Vladimir
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
On Sunday 26 July 2009 21:09:55 Laurent Monin wrote: > Greg Troxel a écrit : > > and Mac OS X 10.5.7 has MAP_ANON and not MAP_ANONYMOUS. Just dropping > > it seems not justified, but perhaps it is actually ok. > > Yes, instead can you try the attached patch ? > > MAP_ANON should be defined, but not MAP_ANONYMOUS on some systems, > so making an alias should suffice. > The patch looks good. Another question is if this mmap hack works on non-linux systems. It is supposed to handle the situation when an image is truncated during reading. It can be tested with this script: while true; do cat 1.jpg >out.jpg cat 2.jpg >out.jpg done The images 1.jpg and 2.jpg should differ in size, like 50KB and 500KB. Point geeqie to out.jpg while the script is running and it should not crash. Vladimir -- Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
Omari Stephens a écrit : Is this really part of the "Compiling geeqie on Mac" thread? I don't see the connection. --xsdg Martin Proetzsch attached 2 patches in 1 to his first message. It is an attempt to fix 2 compilation issues on MacOs X. The first patch is about MAP_ANON vs MAP_ANONYMOUS. The second concerns exiv2.cc. Looks perfectly connected to me ;) -- Zas -- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
Hi Omari, On Montag 27 Juli 2009, Omari Stephens wrote: > Laurent Monin wrote: > > On ubuntu jaunty i get this compilation error after applying your > > exiv2.cc patch: > ... > Is this really part of the "Compiling geeqie on Mac" thread? I don't see > the connection. > > --xsdg Yes it is, because the patch Laurent mentions is the one I did to make geeqie compile on OSX. Martin -- Dipl.-Technoinform. Martin Proetzsch Tel.: 0631 / 205 - 2654 Fax.: 0631 / 205 - 2640 Email: proetz...@informatik.uni-kl.de -- Technische Universität Kaiserslautern Fachbereich Informatik Arbeitsgruppe Robotersysteme Postfach 3049, 67653 Kaiserslautern Gottlieb-Daimler-Straße Geb. 48, 67663 Kaiserslautern http://agrosy.informatik.uni-kl.de -- -- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
Hi, On Montag 27 Juli 2009, Laurent Monin wrote: > On ubuntu jaunty i get this compilation error after applying your > exiv2.cc patch: > > exiv2.cc: In function ‘void debug_exception(Exiv2::AnyError&)’: > exiv2.cc:106: erreur: request for member ‘c_str’ in > ‘((Exiv2::AnyError*)e)->Exiv2::AnyError::.std::exception::what() >’, which is of non-class type ‘const char*’ OK, then I have to have a look at that again. Thanks for testing. Martin -- Dipl.-Technoinform. Martin Proetzsch Tel.: 0631 / 205 - 2654 Fax.: 0631 / 205 - 2640 Email: proetz...@informatik.uni-kl.de -- Technische Universität Kaiserslautern Fachbereich Informatik Arbeitsgruppe Robotersysteme Postfach 3049, 67653 Kaiserslautern Gottlieb-Daimler-Straße Geb. 48, 67663 Kaiserslautern http://agrosy.informatik.uni-kl.de -- -- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
Laurent Monin wrote: > Martin Proetzsch a écrit : >> Hello Laurent, >> >> >> On Jul 26, 2009, at 9:09 PM, Laurent Monin wrote: >> >> >>> Yes, instead can you try the attached patch ? >>> >>> MAP_ANON should be defined, but not MAP_ANONYMOUS on some systems, >>> so making an alias should suffice. >>> >> I have done so and geeqie works as expected. So, if it also works for >> the other operating systems, someone could apply the patch to svn >> (together with my patch of the exiv2.cc concerning the explicit cast). >> >> Thanks a lot. I'll frequently check for changes and tell you about >> news on osx. >> >> Martin >> >> > On ubuntu jaunty i get this compilation error after applying your > exiv2.cc patch: > > exiv2.cc: In function ‘void debug_exception(Exiv2::AnyError&)’: > exiv2.cc:106: erreur: request for member ‘c_str’ in > ‘((Exiv2::AnyError*)e)->Exiv2::AnyError::.std::exception::what()’, > which is of non-class type ‘const char*’ Is this really part of the "Compiling geeqie on Mac" thread? I don't see the connection. --xsdg -- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
Martin Proetzsch a écrit : > Hello Laurent, > > > On Jul 26, 2009, at 9:09 PM, Laurent Monin wrote: > > >> Yes, instead can you try the attached patch ? >> >> MAP_ANON should be defined, but not MAP_ANONYMOUS on some systems, >> so making an alias should suffice. >> > > I have done so and geeqie works as expected. So, if it also works for > the other operating systems, someone could apply the patch to svn > (together with my patch of the exiv2.cc concerning the explicit cast). > > Thanks a lot. I'll frequently check for changes and tell you about > news on osx. > > Martin > > On ubuntu jaunty i get this compilation error after applying your exiv2.cc patch: exiv2.cc: In function ‘void debug_exception(Exiv2::AnyError&)’: exiv2.cc:106: erreur: request for member ‘c_str’ in ‘((Exiv2::AnyError*)e)->Exiv2::AnyError::.std::exception::what()’, which is of non-class type ‘const char*’ -- Zas -- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
Hello Laurent, On Jul 26, 2009, at 9:09 PM, Laurent Monin wrote: > Yes, instead can you try the attached patch ? > > MAP_ANON should be defined, but not MAP_ANONYMOUS on some systems, > so making an alias should suffice. I have done so and geeqie works as expected. So, if it also works for the other operating systems, someone could apply the patch to svn (together with my patch of the exiv2.cc concerning the explicit cast). Thanks a lot. I'll frequently check for changes and tell you about news on osx. Martin -- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
Greg Troxel a écrit :
> and Mac OS X 10.5.7 has MAP_ANON and not MAP_ANONYMOUS. Just dropping
> it seems not justified, but perhaps it is actually ok.
>
>
Yes, instead can you try the attached patch ?
MAP_ANON should be defined, but not MAP_ANONYMOUS on some systems,
so making an alias should suffice.
--
Zas
Index: compat.h
===
--- compat.h (révision 1803)
+++ compat.h (copie de travail)
@@ -21,5 +21,13 @@
#endif
+/* Some systems (BSD,MacOsX,HP-UX,...) define MAP_ANON and not MAP_ANONYMOUS */
+#if defined(MAP_ANON) && !defined(MAP_ANONYMOUS)
+#define MAP_ANONYMOUS MAP_ANON
+#elif defined(MAP_ANONYMOUS) && !defined(MAP_ANON)
+#define MAP_ANON MAP_ANONYMOUS
+#endif
+
+
#endif /* COMPAT_H */
/* vim: set shiftwidth=8 softtabstop=0 cindent cinoptions={1s: */
Index: main.c
===
--- main.c (révision 1803)
+++ main.c (copie de travail)
@@ -10,7 +10,21 @@
* This software comes with no warranty of any kind, use at your own risk!
*/
+#include /* for keyboard values */
+#ifdef HAVE_LIBCHAMPLAIN
+#ifdef HAVE_LIBCHAMPLAIN_GTK
+#include
+#endif
+#endif
+#include
+#include
+
+#include
+#ifdef G_OS_UNIX
+#include
+#endif
+
#include "main.h"
#include "cache.h"
@@ -36,21 +50,7 @@
#include "histogram.h"
#include "pixbuf_util.h"
-#include /* for keyboard values */
-#ifdef HAVE_LIBCHAMPLAIN
-#ifdef HAVE_LIBCHAMPLAIN_GTK
-#include
-#endif
-#endif
-#include
-#include
-
-#include
-#ifdef G_OS_UNIX
-#include
-#endif
-
gboolean thumb_format_changed = FALSE;
static RemoteConnection *remote_connection = NULL;
--
___
Geeqie-devel mailing list
Geeqie-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
and Mac OS X 10.5.7 has MAP_ANON and not MAP_ANONYMOUS. Just dropping it seems not justified, but perhaps it is actually ok. pgpVvIBatJ4L8.pgp Description: PGP signature -- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
Re: [Geeqie-devel] Compiling geeqie on Mac
understand: MAP_ANONYMOUS was not declared (where can it be found?). I think the problem is that POSIX specifies mmap but not MAP_ANON or MAP_ANONYMOUS, found in . On NetBSD the constant is MAP_ANON. My somewhat fuzzy memory is that mmap was a BSD invention, and I'd expect NetBSD matches 4.4BSD (and 4.2BSD if mmap were there), so that would lead me to believe the sources should use MAP_ANON and have some fixup for systems that use MAP_ANONYMOUS but don't define MAP_ANON. pgpDo8LJzQLfu.pgp Description: PGP signature -- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] Compiling geeqie on Mac
Hello,I'm new to this list. I found out about geeqie by reading the a post of Vladimir Nadvornik at the ufraw-mailinglist. As I've been using gqview for years now I was very happy that development proceeds further on.Now I have compiled geeqie on a Mac (OSX 10.4.11) using libraries provided by fink, gcc version is i686-apple-darwin8-gcc-4.0.1 (GCC) 4.0.1 (Apple Computer, Inc. build 5363). It wasn't a hard problem but required two changes in exiv2.cc and main.c, see the attached file. The first one is just an explicit cast (seems to be due a more restrictive compiler), the second one I don't understand: MAP_ANONYMOUS was not declared (where can it be found?). Now geeqie works for me. What do you think about these patches? geeqie_on_mac.diff Description: Binary data Cheers,Martin-- ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
