[gem5-dev] Review Request 2312: Multi-level page table class.

2014-07-11 Thread Alexandru Dutu via gem5-dev

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2312/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 10253:359daed0c723
---
Multi-level page table class.
This is part of the larger effort of supporting virtualized execution in SE 
mode.


Diffs
-

  src/arch/alpha/process.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/arm/process.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/mips/process.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/power/process.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/sparc/process.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/x86/pagetable.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/x86/pagetable_walker.cc c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/x86/process.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/x86/system.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/mem/SConscript c625a3c51bac050879457e666dd83299a36d761b 
  src/mem/multi_level_page_table.hh PRE-CREATION 
  src/mem/multi_level_page_table.cc PRE-CREATION 
  src/mem/multi_level_page_table_impl.hh PRE-CREATION 
  src/mem/page_table.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/sim/Process.py c625a3c51bac050879457e666dd83299a36d761b 
  src/sim/SConscript c625a3c51bac050879457e666dd83299a36d761b 
  src/sim/process.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/sim/process.cc c625a3c51bac050879457e666dd83299a36d761b 

Diff: http://reviews.gem5.org/r/2312/diff/


Testing
---

Regressions passed.


Thanks,

Alexandru Dutu

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


[gem5-dev] Review Request 2313: Making KvmCPU model usable in SE mode.

2014-07-11 Thread Alexandru Dutu via gem5-dev

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2313/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 10254:661c482f7d58
---
Making KvmCPU model usable in SE mode.


Diffs
-

  configs/example/se.py c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/x86/cpuid.cc c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/x86/process.cc c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/x86/regs/misc.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/x86/system.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/arch/x86/system.cc c625a3c51bac050879457e666dd83299a36d761b 
  src/cpu/kvm/base.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/cpu/kvm/base.cc c625a3c51bac050879457e666dd83299a36d761b 
  src/cpu/kvm/x86_cpu.hh c625a3c51bac050879457e666dd83299a36d761b 
  src/cpu/kvm/x86_cpu.cc c625a3c51bac050879457e666dd83299a36d761b 

Diff: http://reviews.gem5.org/r/2313/diff/


Testing
---

Quick regressions passed.


Thanks,

Alexandru Dutu

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


Re: [gem5-dev] Switching from 80 to 100 character lines?

2014-07-11 Thread Anthony Gutierrez via gem5-dev
I think this is not only a good idea, but a needed change. I think with
modern monitors one can comfortable fit a few text editors, all displaying
=100 columns, on one screen.


Anthony Gutierrez
http://web.eecs.umich.edu/~atgutier


On Wed, Jul 9, 2014 at 3:45 PM, Ali Saidi via gem5-dev gem5-dev@gem5.org
wrote:



 We've talked about this before, but I'd like to bring it up again. I'd l
 like to switch the style to 100 character lines. I think it's far
 clearer when the majority of the time all the function arguments end up
 on a single line and while sometimes you can get around that with
 temporaries it's not always the case.

 Thoughts?

 Thanks,

 Ali


 ___
 gem5-dev mailing list
 gem5-dev@gem5.org
 http://m5sim.org/mailman/listinfo/gem5-dev

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev