Re: [gem5-dev] Review Request 3558: ruby: garnet2.0
> On Sept. 23, 2016, 5:47 a.m., Zicong Wang wrote: > > Missing src_outport & dst_inport when create the mesh links in > > MeshDirCorners_XY.py, which will cause segmentation fault(tested in > > X86_MESI_Two_Level) Hi Zicong, Thanks for testing the patch on your end. Can you send me the command you used that gave you the segmentation fault? src_outport and dst_inport are supposed to be optional parameters. I can add them in to MeshDirCorners_XY but want to find out why they gave an error. Thanks, Tushar - Tushar --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3558/#review8734 --- On Aug. 24, 2016, 3:24 p.m., Tushar Krishna wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3558/ > --- > > (Updated Aug. 24, 2016, 3:24 p.m.) > > > Review request for Default, Andreas Hansson, Brad Beckmann, Jieming Yin, and > Matthew Poremba. > > > Repository: gem5 > > > Description > --- > > ruby: garnet2.0 > Revamped version of garnet with more optimized single-cycle routers, > more configurability, and cleaner code. > > > Diffs > - > > src/mem/ruby/network/garnet2.0/GarnetLink.py PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetNetwork.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetNetwork.cc PRE-CREATION > configs/topologies/Crossbar.py d726d0cea027 > configs/topologies/MeshDirCorners_XY.py PRE-CREATION > configs/topologies/Mesh_XY.py PRE-CREATION > configs/topologies/Mesh_westfirst.py PRE-CREATION > configs/topologies/Pt2Pt.py d726d0cea027 > src/base/statistics.cc d726d0cea027 > src/mem/ruby/network/BasicRouter.py d726d0cea027 > src/mem/ruby/network/garnet2.0/CommonTypes.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/Credit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/Credit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/CreditLink.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/CrossbarSwitch.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/CrossbarSwitch.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetLink.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetLink.cc PRE-CREATION > configs/network/Network.py PRE-CREATION > src/mem/ruby/network/garnet2.0/Router.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/RoutingUnit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/RoutingUnit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/SConscript PRE-CREATION > src/mem/ruby/network/garnet2.0/SwitchAllocator.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/SwitchAllocator.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/VirtualChannel.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/VirtualChannel.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/flit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/flit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/flitBuffer.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/flitBuffer.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/OutputUnit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/OutputUnit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/README.txt PRE-CREATION > src/mem/ruby/network/garnet2.0/Router.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/NetworkLink.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/OutVcState.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/OutVcState.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/NetworkLink.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/GarnetNetwork.py PRE-CREATION > src/mem/ruby/network/garnet2.0/InputUnit.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/InputUnit.cc PRE-CREATION > src/mem/ruby/network/garnet2.0/NetworkInterface.hh PRE-CREATION > src/mem/ruby/network/garnet2.0/NetworkInterface.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/3558/diff/ > > > Testing > --- > > > Thanks, > > Tushar Krishna > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing: passed. * build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-two-level: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-atomic: passed. * build/ALPHA_MOESI_hammer/tests/opt/quick/se/60.rubytest/alpha/linux/rubytest-ruby-MOESI_hammer: passed. * build/ALPHA_MOESI_hammer/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby-MOESI_hammer: passed. * build/ALPHA_MOESI_hammer/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MOESI_hammer: passed. * build/ALPHA_MESI_Two_Level/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby-MESI_Two_Level: passed. * build/ALPHA_MOESI_CMP_directory/tests/opt/quick/se/60.rubytest/alpha/linux/rubytest-ruby-MOESI_CMP_directory: passed. * build/ALPHA_MOESI_CMP_token/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MOESI_CMP_token: passed. * build/ALPHA/tests/opt/quick/se/70.twolf/alpha/tru64/simple-atomic: passed. * build/ALPHA_MOESI_CMP_token/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby-MOESI_CMP_token: passed. * build/ALPHA_MOESI_CMP_token/tests/opt/quick/se/60.rubytest/alpha/linux/rubytest-ruby-MOESI_CMP_token: passed. * build/ALPHA_MOESI_CMP_directory/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory: passed. * build/ALPHA/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby: passed. * build/ALPHA_MOESI_CMP_directory/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MOESI_CMP_directory: passed. * build/ALPHA_MESI_Two_Level/tests/opt/quick/se/60.rubytest/alpha/linux/rubytest-ruby-MESI_Two_Level: passed. * build/ALPHA_MESI_Two_Level/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby-MESI_Two_Level: passed. * build/ALPHA/tests/opt/quick/se/60.rubytest/alpha/linux/rubytest-ruby: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: passed. * build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-atomic: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: passed. * build/ALPHA_MESI_Two_Level/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby-MESI_Two_Level: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby: passed. * build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-timing: passed. * build/ALPHA_MOESI_hammer/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby-MOESI_hammer: passed. * build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-simple: passed. * build/ALPHA_MOESI_CMP_token/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby-MOESI_CMP_token: passed. * build/ALPHA/tests/opt/quick/se/01.hello-2T-smt/alpha/linux/o3-timing-mt: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/o3-timing: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic: passed. * build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-atomic-dual: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/minor-timing: passed. * build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-timing-dual: passed. * build/ALPHA_MOESI_CMP_directory/tests/opt/quick/se/50.memtest/alpha/linux/memtest-ruby-MOESI_CMP_directory: passed. * build/NULL/tests/opt/quick/se/50.memtest/null/none/memtest: passed. * build/ALPHA/tests/opt/quick/se/50.vortex/alpha/tru64/simple-atomic: passed. * build/NULL/tests/opt/quick/se/50.memtest/null/none/memtest-filter: passed. * build/NULL/tests/opt/quick/se/70.tgen/null/none/tgen-dram-ctrl: passed. * build/NULL/tests/opt/quick/se/70.tgen/null/none/tgen-simple-mem: passed. * build/ALPHA/tests/opt/quick/se/30.eon/alpha/tru64/simple-atomic: passed. * build/ALPHA/tests/opt/quick/se/70.twolf/alpha/tru64/simple-timing: passed. * build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-simple: passed. * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/o3-timing: passed. * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing: passed. * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-atomic: passed. * build/NULL/tests/opt/quick/se/51.memcheck/null/none/memcheck: passed. * build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-two-level: passed. * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing-ruby: passed. * build/POWER/tests/opt/quick/se/00.hello/power/linux/simple-atomic: passed. * build/POWER/tests/opt/quick/se/00.hello/power/linux/o3-timing: passed. *
