Re: [gem5-dev] Compilation error for gem5 after statfs change
I must chime in here.
Brandon is putting in an heroic effort here and you keep asking him to do more
and more. I'm really concerned with the precedent being set. I do not believe
there has ever been a consensus that gem5 supports any OS other than Linux.
Once we have a common public regression tester infrastructure that allows us to
test multiple OSes, then we can officially add other OSes if people add the
tests to do so. However until that happens, can someone who actually cares
about these non-standard environments run these tests?
Brad
-Original Message-
From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Jason Lowe-Power
Sent: Thursday, January 26, 2017 3:55 PM
To: gem5 Developer List ; Potter, Brandon
Subject: Re: [gem5-dev] Compilation error for gem5 after statfs change
Hi Brandon,
BTW, here's a Travis-CI config file that will run tests on GCC and Clang on
both Mac and Linux hosts. We can add many more parameters for different
versions of compilers, etc., but this is something that should allow you to
test changes on more than just your current platform.
If you have a github mirror, every time you push to it, Travis-CI kicks off
4 builds (for the matrix of OS and compiler).
https://github.com/powerjg/gem5-ci-test/blob/master/.travis.yml
It would be great if you could take a look at this, Brandon.
Thanks,
Jason
On Thu, Jan 26, 2017 at 4:47 AM Andreas Hansson
wrote:
> Hi all,
>
> While I agree about the end goal (test every commit on every platform)
> I would suggest we go about this one step at a time. The likelihood of
> breakage is only high for anything related to syscall emulation, so it
> really only affects a small part of the developer community. Agreed?
>
> With that in mind I think we can prevent 99% of the issues if syscall
> emulation patches are built on a BSD system with clang. I would be
> wrong, but I would think this is a very good filter, with a fairly low
> cost and effort of deployment. Virtualbox + some flavour of BSD would do it.
>
> Andreas
>
> On 25/01/2017, 23:18, "gem5-dev on behalf of Jason Lowe-Power"
> wrote:
>
> >Yeah, it's a major problem that we say that we support macOS and
> >others when we allow commits that break builds on these other OSes.
> >
> >If we are going to say that we have support for OSes other than
> >Linux, we need to at least verify gem5 builds on these OSes,
> >preferably before accepting a commit. I'm currently testing out the
> >free Travis-CI service ( https://travis-ci.org/powerjg/gem5-ci-test).
> >We could probably hook this up to our gem5 github page, if it works
> >out.
> >
> >Another important point, though, is that we can't expect all
> >committers to own multiple machines to test their changes on. We need
> >something that will do pre-commit builds on all the platforms we
> >claim to support.
> >
> >We're in the middle of moving the regression tests to a hosted
> >jenkins instance. Hopefully this will solve some of these issues
> >(though I don't think it will support multiple OS builds).
> >
> >Do others have any ideas on a long-term solution here?
> >
> >Cheers,
> >Jason
> >
> >On Tue, Jan 24, 2017 at 5:46 PM Bjoern A. Zeeb <
> >bzeeb-li...@lists.zabbadoz.net> wrote:
> >
> >On 24 Jan 2017, at 22:08, Jason Lowe-Power wrote:
> >
> >> Hi Brandon,
> >>
> >> I think this is a "real" bug:
> >>
> >
> http://qa.gem5.org//1905/compiling-problem-gem5-mac-os-10-11-6-scons-b
> uild
> >-arm-gem5-opt
> >.
> >> I think there are a few more places that need an #ifdef NO_STATFS.
> >> Could
> >> you look into it and post a patch if there's a problem? If not,
> >> please reply to the gem5 QA post and let them know.
> >
> >Can people try this one and probably get the #ifdefs right for NetBSD
> >as well? There are at least 3 different checks for that code; if
> >people don’t care about “style” I could get it right, but ..
> >
> >diff -r e47703369039 src/sim/syscall_emul.hh
> >--- a/src/sim/syscall_emul.hh Fri Jan 20 14:12:58 2017 -0500
> >+++ b/src/sim/syscall_emul.hh Tue Jan 24 23:45:04 2017 +
> >@@ -70,6 +70,8 @@
> > #include
> > #if (NO_STATFS == 0)
> > #include
> >+#else
> >+#include
> > #endif
> > #include
> > #include
> >@@ -530,20 +532,25 @@
> > {
> > TypedBufferArg tgt(addr);
> >
> >+tgt->f_type = TheISA::htog(host->f_type);
> > #if defined(__OpenBSD__) || defined(__APPLE__) || defined(__FreeBSD__)
> >-tgt->f_type = 0;
> >+tgt->f_bsize = TheISA::htog(host->f_iosize);
> > #else
> >-tgt->f_type = TheISA::htog(host->f_type);
> >+tgt->f_bsize = TheISA::htog(host->f_bsize);
> > #endif
> >-tgt->f_bsize = TheISA::htog(host->f_bsize);
> > tgt->f_blocks = TheISA::htog(host->f_blocks);
> > tgt->f_bfree = TheISA::htog(host->f_bfree);
> > tgt->f_bavail = TheISA::htog(host->f_bavail);
> > tgt->f_files = TheISA::htog(host->f_files);
> > tgt->f_ffree = TheISA::htog(host->f_ffree);
> > memcpy(&tgt->f_fsid, &host->f_f
[gem5-dev] Cron /z/m5/regression/do-regression quick
* build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-atomic: FAILED! * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing: FAILED!*** diff[simerr]: SKIPPED*** stat_diff: SKIPPED *** diff[config.ini]: SKIPPED* build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-two-level: FAILED! * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/o3-timing: FAILED! * build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-simple: FAILED!*** diff[config.ini]: SKIPPED * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing-ruby: FAILED! * build/NULL/tests/opt/quick/se/51.memcheck/null/none/memcheck: FAILED! * build/NULL/tests/opt/quick/se/50.memtest/null/none/memtest: FAILED! * build/NULL/tests/opt/quick/se/70.tgen/null/none/tgen-simple-mem: FAILED! * build/NULL/tests/opt/quick/se/50.memtest/null/none/memtest-filter: FAILED!*** gem5 stderr *** * build/NULL/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby: FAILED! * build/NULL/tests/opt/quick/se/70.tgen/null/none/tgen-dram-ctrl: FAILED! * build/NULL_MOESI_hammer/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby-MOESI_hammer: FAILED! * build/NULL_MESI_Two_Level/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby-MESI_Two_Level: FAILED! * build/NULL_MOESI_CMP_directory/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby-MOESI_CMP_directory: FAILED! * build/NULL_MOESI_CMP_token/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby-MOESI_CMP_token: FAILED! * build/POWER/tests/opt/quick/se/00.hello/power/linux/simple-atomic: FAILED! * build/POWER/tests/opt/quick/se/00.hello/power/linux/o3-timing: FAILED! * build/SPARC/tests/opt/quick/se/70.twolf/sparc/linux/simple-timing: FAILED! gem5 exited with non-zero status: 1* build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/o3-timing: FAILED! * build/SPARC/tests/opt/quick/se/03.learning-gem5/sparc/linux/learning-gem5-p1-two-level: FAILED! * build/SPARC/tests/opt/quick/se/70.twolf/sparc/linux/simple-atomic: FAILED! * build/SPARC/tests/opt/quick/se/10.mcf/sparc/linux/simple-atomic: FAILED! * build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/simple-timing: FAILED! * build/SPARC/tests/opt/quick/se/03.learning-gem5/sparc/linux/learning-gem5-p1-simple: FAILED! * build/SPARC/tests/opt/quick/se/50.vortex/sparc/linux/simple-timing: FAILED! * build/SPARC/tests/opt/quick/se/00.hello/sparc/linux/simple-timing: FAILED! * build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/simple-atomic: FAILED! * build/SPARC/tests/opt/quick/se/40.m5threads-test-atomic/sparc/linux/o3-timing-mp: FAILED! *** diff[config.ini]: SKIPPED* build/SPARC/tests/opt/quick/se/00.hello/sparc/linux/simple-timing-ruby: FAILED! * build/SPARC/tests/opt/quick/se/50.vortex/sparc/linux/simple-atomic: FAILED! * build/SPARC/tests/opt/quick/se/40.m5threads-test-atomic/sparc/linux/simple-atomic-mp: FAILED! * build/SPARC/tests/opt/quick/se/00.hello/sparc/linux/simple-atomic: FAILED! * build/SPARC/tests/opt/quick/se/40.m5threads-test-atomic/sparc/linux/simple-timing-mp: FAILED! * build/X86/tests/opt/quick/se/00.hello/x86/linux/simple-timing-ruby: FAILED! * build/X86/tests/opt/quick/se/10.mcf/x86/linux/simple-atomic: FAILED! * build/X86/tests/opt/quick/se/00.hello/x86/linux/simple-atomic: FAILED! * build/X86/tests/opt/quick/se/00.hello/x86/linux/o3-timing: FAILED! * build/X86/tests/opt/quick/se/03.learning-gem5/x86/linux/learning-gem5-p1-simple: FAILED! * build/X86/tests/opt/quick/se/00.hello/x86/linux/simple-timing: FAILED! * build/X86/tests/opt/quick/se/70.twolf/x86/linux/simple-atomic: FAILED! * build/X86/tests/opt/quick/se/03.learning-gem5/x86/linux/learning-gem5-p1-two-level: FAILED! * build/X86/tests/opt/quick/se/70.twolf/x86/linux/simple-timing: FAILED! * build/ARM/tests/opt/quick/se/50.vortex/arm/linux/simple-atomic: FAILED! * build/ARM/tests/opt/quick/se/70.twolf/arm/linux/simple-atomic: FAILED! * build/ARM/tests/opt/quick/se/10.mcf/arm/linux/simple-timing: FAILED! * build/ARM/tests/opt/quick/se/50.vortex/arm/linux/simple-timing: FAILED! * build/ARM/tests/opt/quick/se/10.mcf/arm/linux/simple-atomic: FAILED! * build/ARM/tests/opt/quick/fs/10.linux-boot/arm/linux/realview-simple-atomic-checkpoint: FAILED! * build/ARM/tests/opt/quick/fs/10.linux-boot/arm/linux/realview-simple-atomic-dual: FAILED! * build/ARM/tests/opt/quick/se/00.hello/arm/linux/simple-timing: FAILED! * build/ARM/tests/opt/quick/fs/10.linux-boot/arm/linux/realview-switcheroo-atomic: FAILED! * build/ARM/tests/opt/quick/se/03.learning-gem5/arm/linux/learning-gem5-p1-simple: FAILED! * build/ARM/tests/opt/quick/se/70.twolf/arm/linux/simple-timing: FAILED! * build/ARM/tests/opt/quick/fs/10.linux-boot/arm/linux/realview-simple-timing: FAILED! * build/ARM/tests/opt/
Re: [gem5-dev] Review Request 3792: misc: Update #!env calls for python to explicit version
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3792/#review9346 --- Ship it! Ship It! - Pierre-Yves Péneau On Jan. 27, 2017, 6:32 p.m., Jason Lowe-Power wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3792/ > --- > > (Updated Jan. 27, 2017, 6:32 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > misc: Update #!env calls for python to explicit version > > In some newer Linux distributions, env python default to Python 3.0. This > patch explicitly uses "python2" instead of just "python" for all scripts > that use #! > > Reported-by: Sanchayan Maity > > > Diffs > - > > util/minorview.py cd7f3a1dbf55 > util/o3-pipeview.py cd7f3a1dbf55 > util/oprofile-top.py cd7f3a1dbf55 > util/pbs/job.py cd7f3a1dbf55 > util/pbs/send.py cd7f3a1dbf55 > util/protolib.py cd7f3a1dbf55 > util/qdo cd7f3a1dbf55 > util/regress cd7f3a1dbf55 > util/slicc cd7f3a1dbf55 > util/stats/stats.py cd7f3a1dbf55 > util/streamline/m5stats2streamline.py cd7f3a1dbf55 > util/style.py cd7f3a1dbf55 > util/style/__init__.py cd7f3a1dbf55 > util/style/repo.py cd7f3a1dbf55 > util/style/sort_includes.py cd7f3a1dbf55 > util/style/style.py cd7f3a1dbf55 > util/style/verifiers.py cd7f3a1dbf55 > util/maint/git-patch-to-hg-patch cd7f3a1dbf55 > util/memtest-soak.py cd7f3a1dbf55 > ext/mcpat/regression/regression.py cd7f3a1dbf55 > ext/mcpat/regression/verify_output.py cd7f3a1dbf55 > ext/ply/example/classcalc/calc.py cd7f3a1dbf55 > ext/ply/example/newclasscalc/calc.py cd7f3a1dbf55 > src/unittest/genini.py cd7f3a1dbf55 > tests/testing/__init__.py cd7f3a1dbf55 > tests/testing/helpers.py cd7f3a1dbf55 > tests/testing/results.py cd7f3a1dbf55 > tests/testing/tests.py cd7f3a1dbf55 > tests/testing/units.py cd7f3a1dbf55 > tests/tests.py cd7f3a1dbf55 > util/batch/job.py cd7f3a1dbf55 > util/batch/send.py cd7f3a1dbf55 > util/checkpoint-tester.py cd7f3a1dbf55 > util/compile cd7f3a1dbf55 > util/cpt_upgrader.py cd7f3a1dbf55 > util/decode_inst_dep_trace.py cd7f3a1dbf55 > util/decode_inst_trace.py cd7f3a1dbf55 > util/decode_packet_trace.py cd7f3a1dbf55 > util/dram_lat_mem_rd_plot.py cd7f3a1dbf55 > util/dram_sweep_plot.py cd7f3a1dbf55 > util/encode_inst_dep_trace.py cd7f3a1dbf55 > util/encode_packet_trace.py cd7f3a1dbf55 > util/find_copyrights.py cd7f3a1dbf55 > util/git-pre-commit.py cd7f3a1dbf55 > util/hgstyle.py cd7f3a1dbf55 > > Diff: http://reviews.gem5.org/r/3792/diff/ > > > Testing > --- > > gem5 compiles on arch with this patch and http://reviews.gem5.org/r/3779/. > > Testing done on arch docker image. See > https://hub.docker.com/r/powerjg/arch-dev/. > Run "docker run -v `pwd`:/gem5/ -it powerjg/arch-dev /bin/bash" to > build/run/test gem5. > > > Thanks, > > Jason Lowe-Power > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
