[gem5-dev] Change in gem5/gem5[master]: sim-se: Enhance clone for X86KvmCPU
Alexandru Duțu has uploaded a new patch set (#16) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/12309 ) Change subject: sim-se: Enhance clone for X86KvmCPU .. sim-se: Enhance clone for X86KvmCPU This changeset enables clone to work with X86KvmCPU model, which will allow running multi-threaded applications at near hardware speeds. Even though the application is multi-threaded, the KvmCPU model uses one event queue, therefore, only one hardware thread will be used, through KVM, to simulate multiple application threads. Change-Id: I2879e20518bf6c0c19fbc7e11b1583c22b59ef3b --- M src/arch/x86/process.cc M src/mem/multi_level_page_table.hh M src/mem/page_table.hh M src/sim/process.cc M src/sim/process.hh M src/sim/syscall_emul.hh 6 files changed, 36 insertions(+), 6 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12309 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I2879e20518bf6c0c19fbc7e11b1583c22b59ef3b Gerrit-Change-Number: 12309 Gerrit-PatchSet: 16 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-CC: Jason Lowe-Power Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[refs/meta/config]: Review access change
Rahul Thakur has submitted this change and it was merged. ( https://gem5-review.googlesource.com/c/public/gem5/+/18088 ) Change subject: Review access change .. Review access change Change-Id: I4ec5c15111b91efb0c98a654ba7335c640c079e8 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18088 Reviewed-by: Jason Lowe-Power Reviewed-by: Gabe Black Maintainer: Rahul Thakur --- A groups M project.config 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Jason Lowe-Power: Looks good to me, approved Gabe Black: Looks good to me, approved Rahul Thakur: Looks good to me, approved diff --git a/groups b/groups new file mode 100644 index 000..16dba15 --- /dev/null +++ b/groups @@ -0,0 +1,4 @@ +# UUID Group Name +# +mdb:kokoro mdb/kokoro +mdb:kokoro-dedicated mdb/kokoro-dedicated diff --git a/project.config b/project.config index 9617eda..876c893 100644 --- a/project.config +++ b/project.config @@ -2,3 +2,9 @@ inheritFrom = public [submit] action = rebase always +[access "refs/*"] + read = group mdb/kokoro + read = group mdb/kokoro-dedicated +[access "refs/heads/*"] + label-Verified = -1..+1 group mdb/kokoro + label-Verified = -1..+1 group mdb/kokoro-dedicated -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18088 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I4ec5c15111b91efb0c98a654ba7335c640c079e8 Gerrit-Change-Number: 18088 Gerrit-PatchSet: 2 Gerrit-Owner: Rahul Thakur Gerrit-Assignee: Jason Lowe-Power Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Rahul Thakur Gerrit-MessageType: merged ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[refs/meta/config]: Review access change
Rahul Thakur has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/18088 Change subject: Review access change .. Review access change Change-Id: I4ec5c15111b91efb0c98a654ba7335c640c079e8 --- A groups M project.config 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/groups b/groups new file mode 100644 index 000..16dba15 --- /dev/null +++ b/groups @@ -0,0 +1,4 @@ +# UUID Group Name +# +mdb:kokoro mdb/kokoro +mdb:kokoro-dedicated mdb/kokoro-dedicated diff --git a/project.config b/project.config index 9617eda..876c893 100644 --- a/project.config +++ b/project.config @@ -2,3 +2,9 @@ inheritFrom = public [submit] action = rebase always +[access "refs/*"] + read = group mdb/kokoro + read = group mdb/kokoro-dedicated +[access "refs/heads/*"] + label-Verified = -1..+1 group mdb/kokoro + label-Verified = -1..+1 group mdb/kokoro-dedicated -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18088 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I4ec5c15111b91efb0c98a654ba7335c640c079e8 Gerrit-Change-Number: 18088 Gerrit-PatchSet: 1 Gerrit-Owner: Rahul Thakur Gerrit-MessageType: newchange ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Cron /z/m5/regression/do-regression quick
* build/ALPHA/tests/opt/quick/fs/80.netperf-stream/alpha/linux/twosys-tsunami-simple-atomic: FAILED! * build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-atomic: FAILED! * build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-timing: FAILED! * build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-atomic-dual: FAILED! * build/ALPHA/tests/opt/quick/fs/10.linux-boot/alpha/linux/tsunami-simple-timing-dual: FAILED! * build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64c/minor-timing: FAILED! * build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64c/simple-timing: FAILED! * build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64c/o3-timing: FAILED! * build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64c/simple-timing-ruby: FAILED! * build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64c/simple-atomic: FAILED! * build/RISCV/tests/opt/quick/se/02.insttest/riscv/linux-rv64f/o3-timing: FAILED! * build/HSAIL_X86/tests/opt/quick/se/04.gpu/x86/linux/gpu-ruby-GPU_RfO: FAILED! * build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-simple: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic: CHANGED! * build/ALPHA/tests/opt/quick/se/03.learning-gem5/alpha/linux/learning-gem5-p1-two-level: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing-ruby: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: CHANGED! * build/ALPHA/tests/opt/quick/se/01.hello-2T-smt/alpha/linux/o3-timing-mt: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing: CHANGED! * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-atomic: CHANGED! * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing-ruby: CHANGED! * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/o3-timing: CHANGED! * build/MIPS/tests/opt/quick/se/00.hello/mips/linux/simple-timing: CHANGED! * build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-two-level: CHANGED! * build/MIPS/tests/opt/quick/se/03.learning-gem5/mips/linux/learning-gem5-p1-simple: CHANGED! * build/NULL/tests/opt/quick/se/80.dram-closepage/null/none/dram-lowp: CHANGED! * build/NULL/tests/opt/quick/se/80.dram-openpage/null/none/dram-lowp: CHANGED! * build/NULL/tests/opt/quick/se/70.tgen/null/none/tgen-simple-mem: CHANGED! * build/NULL/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby: CHANGED! * build/NULL/tests/opt/quick/se/70.tgen/null/none/tgen-dram-ctrl: CHANGED! * build/NULL_MOESI_hammer/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby-MOESI_hammer: CHANGED! * build/NULL_MESI_Two_Level/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby-MESI_Two_Level: CHANGED! * build/NULL_MOESI_CMP_directory/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby-MOESI_CMP_directory: CHANGED! * build/NULL_MOESI_CMP_token/tests/opt/quick/se/60.rubytest/null/none/rubytest-ruby-MOESI_CMP_token: CHANGED! * build/POWER/tests/opt/quick/se/00.hello/power/linux/simple-atomic: CHANGED! * build/POWER/tests/opt/quick/se/00.hello/power/linux/o3-timing: CHANGED! * build/SPARC/tests/opt/quick/se/00.hello/sparc/linux/simple-timing-ruby: CHANGED! * build/SPARC/tests/opt/quick/se/03.learning-gem5/sparc/linux/learning-gem5-p1-simple: CHANGED! * build/SPARC/tests/opt/quick/se/00.hello/sparc/linux/simple-atomic: CHANGED! * build/SPARC/tests/opt/quick/se/03.learning-gem5/sparc/linux/learning-gem5-p1-two-level: CHANGED! * build/SPARC/tests/opt/quick/se/00.hello/sparc/linux/simple-timing: CHANGED! * build/SPARC/tests/opt/quick/se/40.m5threads-test-atomic/sparc/linux/simple-atomic-mp: CHANGED! * build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/simple-atomic: CHANGED! * build/SPARC/tests/opt/quick/se/40.m5threads-test-atomic/sparc/linux/simple-timing-mp: CHANGED! * build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/simple-timing: CHANGED! * build/SPARC/tests/opt/quick/se/02.insttest/sparc/linux/o3-timing: CHANGED! * build/SPARC/tests/opt/quick/se/40.m5threads-test-atomic/sparc/linux/o3-timing-mp: CHANGED! * build/SPARC/tests/opt/quick/se/50.vortex/sparc/linux/simple-atomic: CHANGED! * build/SPARC/tests/opt/quick/se/70.twolf/sparc/linux/simple-atomic: CHANGED! * build/SPARC/tests/opt/quick/se/50.vortex/sparc/linux/simple-timing: CHANGED! * build/SPARC/tests/opt/quick/se/10.mcf/sparc/linux/simple-atomic: CHANGED! * build/SPARC/tests/opt/quick/se/70.twolf/sparc/linux/simple-timing: CHANGED! * build/X86/tests/opt/quick/se/03.learning-gem5/x86/linux/learning-gem5-p1-simple: CHANGED! * build/X86/tests/opt/quick/se/00.hello/x86/linux/o3-timing:
[gem5-dev] Change in gem5/gem5[master]: sim-se: Fix invalid delete of params on clone
Jason Lowe-Power has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/18068 Change subject: sim-se: Fix invalid delete of params on clone .. sim-se: Fix invalid delete of params on clone The params pointer is kept by the SimObject and should not be deleted until gem5 exits. In fact, it's used in https://gem5-review.googlesource.com/c/public/gem5/+/12309 which will cause a seg fault if a cloned process calls clone. (I think) Change-Id: I46cc23a09e4e9b6bc2fdcd961148324c41820815 Signed-off-by: Jason Lowe-Power --- M src/sim/syscall_emul.hh 1 file changed, 0 insertions(+), 1 deletion(-) diff --git a/src/sim/syscall_emul.hh b/src/sim/syscall_emul.hh index 0378bd7..b1e15e2 100644 --- a/src/sim/syscall_emul.hh +++ b/src/sim/syscall_emul.hh @@ -1552,7 +1552,6 @@ pp->pid = temp_pid; pp->ppid = (flags & OS::TGT_CLONE_THREAD) ? p->ppid() : p->pid(); Process *cp = pp->create(); -delete pp; Process *owner = ctc->getProcessPtr(); ctc->setProcessPtr(cp); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18068 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I46cc23a09e4e9b6bc2fdcd961148324c41820815 Gerrit-Change-Number: 18068 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Lowe-Power Gerrit-MessageType: newchange ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
