date:20230417

[gem5-dev] Build failed in Jenkins: weekly #118

2023-04-17 Thread jenkins-no-reply--- via gem5-dev

See 

Changes:

[weihanchen] base: Add missing headers in extensible.hh

[gabe.black] dev: Add an "abortPending" method to the DMA port class.

[humzajahangirikram] stdlib: small fix in spec-2006 and spec-2007

[gabe.black] util: Add a missing free() to m5term.

[mkjost] configs: Fix RISCVMatched Test

[gabe.black] base: Add support for unix domain sockets in ListenSocket.

[Bobby R. Bruce] scons: Add '-lstdc++fs' to LIBS env when GCC version < 9

[Bobby R. Bruce] base: Use  include for GCC v7

[gabe.black] mem: Use HostSocket in the SharedMemoryServer.

[rogerycchang] arch-riscv: Fix the address check of pmp

[rogerycchang] arch-riscv: Refactor the shouldCheckPMP function

[gabe.black] base,python: Add a param type for host sockets.

[gabe.black] base: Remove the now unused UnixSocketAddr class and associated 
code.

[gabe.black] arch,base,dev,sim: Convert objects to use the HostSocket param 
type.

[gabe.black] base: fatal() if a socket path doesn't fit in sockaddr_un.sun_path.

[rogerycchang] arch-riscv: Insert symbol table of bootloader into debug symbol 
table

[richard.cooper] python: Fix broken call to m5.fatal in _check_tracing()

[Bobby R. Bruce] scons: Fix "no-duplicate-sources" to include .hh when not set

[richard.cooper] cpu: Add CpuCluster method to allow querying the number of 
CPUs.

[richard.cooper] configs: Update Arm starter_se.py for new CpuCluster 
abstraction

[richard.cooper] arch-arm: Fix formatting of v8 Tarmac Register records

[richard.cooper] arch-arm: Add more detailed debug messages to GICv2.

[richard.cooper] dev-arm: Fix writes to Arm GICv2 GICD_IGROUPRn

[richard.cooper] arch-arm: Add an option to use 64-bit PMU counters

[richard.cooper] configs: Add Tarmac tracing option to the simple Arm configs

[richard.cooper] configs: Make the configuration of the gicv4 parameter robust

[richard.cooper] configs: Add the O3 CPU as an option to baremetal.py

[richard.cooper] configs: Update Arm simple configs to enable --interactive 
option

[richard.cooper] configs: Add --exit-on-uart-eot flag to Arm baremetal.py config

[hoanguyen] scons: Add "--no-duplicate-sources" option to SConstruct in util/


--
[...truncated 296.34 KB...]
 [SO Param] m5.objects.LupioPIC, LupioPIC -> ALL/python/_m5/param_LupioPIC.cc
 [ CXX] ALL/dev/lupio/LupioRNG.py.cc -> .o
 [ CXX] ALL/python/_m5/param_LupioPIC.cc -> .o
 [SO Param] m5.objects.LupioRNG, LupioRNG -> ALL/python/_m5/param_LupioRNG.cc
 [SO Param] m5.objects.LupioRNG, LupioRNG -> ALL/params/LupioRNG.hh
 [ TRACING]  -> ALL/debug/LupioRNG.hh
 [ CXX] ALL/python/_m5/param_LupioRNG.cc -> .o
 [ CXX] ALL/dev/lupio/LupioRTC.py.cc -> .o
 [SO Param] m5.objects.LupioRTC, LupioRTC -> ALL/python/_m5/param_LupioRTC.cc
 [SO Param] m5.objects.LupioRTC, LupioRTC -> ALL/params/LupioRTC.hh
 [ TRACING]  -> ALL/debug/LupioRTC.hh
 [ CXX] ALL/dev/lupio/LupioTMR.py.cc -> .o
 [ CXX] ALL/python/_m5/param_LupioRTC.cc -> .o
 [SO Param] m5.objects.LupioTMR, LupioTMR -> ALL/python/_m5/param_LupioTMR.cc
 [SO Param] m5.objects.LupioTMR, LupioTMR -> ALL/params/LupioTMR.hh
 [ CXX] ALL/dev/lupio/LupioTTY.py.cc -> .o
 [ CXX] ALL/python/_m5/param_LupioTMR.cc -> .o
 [SO Param] m5.objects.LupioTTY, LupioTTY -> ALL/python/_m5/param_LupioTTY.cc
 [ CXX] ALL/dev/lupio/LupioSYS.py.cc -> .o
 [SO Param] m5.objects.LupioTTY, LupioTTY -> ALL/params/LupioTTY.hh
 [ CXX] ALL/python/_m5/param_LupioTTY.cc -> .o
 [SO Param] m5.objects.LupioSYS, LupioSYS -> ALL/python/_m5/param_LupioSYS.cc
 [SO Param] m5.objects.LupioSYS, LupioSYS -> ALL/params/LupioSYS.hh
 [ TRACING]  -> ALL/debug/LupioSYS.hh
 [ TRACING]  -> ALL/debug/LupioBLK.cc
 [ CXX] ALL/python/_m5/param_LupioSYS.cc -> .o
 [ CXX] ALL/debug/LupioBLK.cc -> .o
 [ TRACING]  -> ALL/debug/LupioIPI.cc
 [ TRACING]  -> ALL/debug/LupioIPI.hh
 [ CXX] ALL/debug/LupioIPI.cc -> .o
 [ TRACING]  -> ALL/debug/LupioPIC.cc
 [ TRACING]  -> ALL/debug/LupioPIC.hh
 [ TRACING]  -> ALL/debug/LupioRNG.cc
 [ CXX] ALL/debug/LupioPIC.cc -> .o
 [ CXX] ALL/debug/LupioRNG.cc -> .o
 [ TRACING]  -> ALL/debug/LupioRTC.cc
 [ TRACING]  -> ALL/debug/LupioTMR.cc
 [ CXX] ALL/debug/LupioRTC.cc -> .o
 [ TRACING]  -> ALL/debug/LupioTMR.hh
 [ CXX] ALL/debug/LupioTMR.cc -> .o
 [ TRACING]  -> ALL/debug/LupioTTY.cc
 [ TRACING]  -> ALL/debug/LupioTTY.hh
 [ TRACING]  -> ALL/debug/LupioSYS.cc
 [ CXX] ALL/debug/LupioTTY.cc -> .o
 [ CXX] ALL/debug/LupioSYS.cc -> .o
 [ CXX] ALL/dev/lupio/lupio_blk.cc -> .o
 [ CXX] ALL/dev/lupio/lupio_ipi.cc -> .o
 [ CXX] ALL/dev/lupio/lupio_pic.cc -> .o
 [ CXX] ALL/dev/lupio/lupio_rng.cc -> .o
 [ CXX] ALL/dev/lupio/lupio_rtc.cc -> .o
 [ CXX] ALL/dev/lupio/lupio_tmr.cc -> .o
 [ CXX] ALL/dev/lupio/lupio_tty.cc -> .o
 [ CXX] ALL/dev/lupio/lupio_sys.cc -> .o
 [ CXX] ALL/dev/x86/Pc.py.cc -> .o
 [SO Param] m5.objects.Pc, Pc ->

[gem5-dev] [S] Change in gem5/gem5[develop]: mem-ruby: Not flushing data to memory when there's no dirty block

2023-04-17 Thread Hoa Nguyen (Gerrit) via gem5-dev

Hoa Nguyen has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/69897?usp=email )


Change subject: mem-ruby: Not flushing data to memory when there's no dirty  
block

..

mem-ruby: Not flushing data to memory when there's no dirty block

Currently, taking a checkpoint with a ruby cache involves moving all
the dirty data in cache to memory. This is done by keeping **only**
simulating the cache until all dirty data are flushed to the memory
before taking the checkpoint.

However, when the cache does not have dirty data, it is a problem if
we keep simulating the cache. E.g., calling checkpoint caused the gem5
"empty event queue" assertion fault when running the ruby cache in
atomic_noncaching mode. Since the mode bypasses the cache, all blocks
are invalid and do not contain dirty data. Subsequently, there is no
event placed to the event queue when we keep **only** simulating the
cache before taking the checkpoint.

This patch fixes this problem by checking if there is any actionable
item when trying to move dirty data to memory. If there is no block
contains dirty data, we simply choose not to continue simulating the
cache before taking the checkpoint.

Change-Id: Idfa09be51274c7fc8a340e9e33167f5b32d1b866
Signed-off-by: Hoa Nguyen 
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/69897
Reviewed-by: Jason Lowe-Power 
Tested-by: kokoro 
Maintainer: Bobby Bruce 
---
M src/mem/ruby/system/CacheRecorder.cc
M src/mem/ruby/system/CacheRecorder.hh
M src/mem/ruby/system/RubySystem.cc
3 files changed, 15 insertions(+), 0 deletions(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved
  Bobby Bruce: Looks good to me, approved
  kokoro: Regressions pass




diff --git a/src/mem/ruby/system/CacheRecorder.cc  
b/src/mem/ruby/system/CacheRecorder.cc

index e87b3f2..20a8a30 100644
--- a/src/mem/ruby/system/CacheRecorder.cc
+++ b/src/mem/ruby/system/CacheRecorder.cc
@@ -207,5 +207,11 @@
 return current_size;
 }

+uint64_t
+CacheRecorder::getNumRecords() const
+{
+return m_records.size();
+}
+
 } // namespace ruby
 } // namespace gem5
diff --git a/src/mem/ruby/system/CacheRecorder.hh  
b/src/mem/ruby/system/CacheRecorder.hh

index 8dbd67f..be95590 100644
--- a/src/mem/ruby/system/CacheRecorder.hh
+++ b/src/mem/ruby/system/CacheRecorder.hh
@@ -85,6 +85,8 @@

 uint64_t aggregateRecords(uint8_t **data, uint64_t size);

+uint64_t getNumRecords() const;
+
 /*!
  * Function for flushing the memory contents of the caches to the
  * main memory. It goes through the recorded contents of the caches,
diff --git a/src/mem/ruby/system/RubySystem.cc  
b/src/mem/ruby/system/RubySystem.cc

index 5a81513..b38c903 100644
--- a/src/mem/ruby/system/RubySystem.cc
+++ b/src/mem/ruby/system/RubySystem.cc
@@ -218,6 +218,13 @@
 }
 DPRINTF(RubyCacheTrace, "Cache Trace Complete\n");

+// If there is no dirty block, we don't need to flush the cache
+if (m_cache_recorder->getNumRecords() == 0)
+{
+m_cooldown_enabled = false;
+return;
+}
+
 // save the current tick value
 Tick curtick_original = curTick();
 DPRINTF(RubyCacheTrace, "Recording current tick %ld\n",  
curtick_original);


--
To view, visit  
https://gem5-review.googlesource.com/c/public/gem5/+/69897?usp=email
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Idfa09be51274c7fc8a340e9e33167f5b32d1b866
Gerrit-Change-Number: 69897
Gerrit-PatchSet: 6
Gerrit-Owner: Hoa Nguyen 
Gerrit-Reviewer: Bobby Bruce 
Gerrit-Reviewer: Hoa Nguyen 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org

[gem5-dev] Build failed in Jenkins: compiler-checks #578

2023-04-17 Thread jenkins-no-reply--- via gem5-dev

See 

Changes:


--
[...truncated 1.03 KB...]
 > git checkout -f 851e469e55b69533a36de634bd1d1f424b31b07e # timeout=10
Commit message: "scons: Add "--no-duplicate-sources" option to SConstruct in 
util/"
 > git rev-list --no-walk 851e469e55b69533a36de634bd1d1f424b31b07e # timeout=10
[Checks API] No suitable checks publisher found.
[compiler-checks] $ /bin/sh -xe /tmp/jenkins15142269340596400691.sh
+ ./tests/compiler-tests.sh -j 16
Starting build tests with 'gcc-version-12'...
'gcc-version-12' was found in the comprehensive tests. All ISAs will be built.
  * Building target 'NULL_MESI_Two_Level.opt' with 'gcc-version-12'...
Done.
  * Building target 'NULL_MESI_Two_Level.fast' with 'gcc-version-12'...
Done.
  * Building target 'SPARC.opt' with 'gcc-version-12'...
Done.
  * Building target 'SPARC.fast' with 'gcc-version-12'...
Done.
  * Building target 'Garnet_standalone.opt' with 'gcc-version-12'...
Done.
  * Building target 'Garnet_standalone.fast' with 'gcc-version-12'...
Done.
  * Building target 'X86.opt' with 'gcc-version-12'...
Done.
  * Building target 'X86.fast' with 'gcc-version-12'...
Done.
  * Building target 'POWER.opt' with 'gcc-version-12'...
Done.
  * Building target 'POWER.fast' with 'gcc-version-12'...
Done.
  * Building target 'GCN3_X86.opt' with 'gcc-version-12'...
Done.
  * Building target 'GCN3_X86.fast' with 'gcc-version-12'...
Done.
  * Building target 'NULL_MOESI_CMP_token.opt' with 'gcc-version-12'...
Done.
  * Building target 'NULL_MOESI_CMP_token.fast' with 'gcc-version-12'...
Done.
  * Building target 'ARM_MESI_Three_Level.opt' with 'gcc-version-12'...
Done.
  * Building target 'ARM_MESI_Three_Level.fast' with 'gcc-version-12'...
Done.
  * Building target 'X86_MOESI_AMD_Base.opt' with 'gcc-version-12'...
Done.
  * Building target 'X86_MOESI_AMD_Base.fast' with 'gcc-version-12'...
Done.
  * Building target 'NULL.opt' with 'gcc-version-12'...
Done.
  * Building target 'NULL.fast' with 'gcc-version-12'...
Done.
  * Building target 'NULL_MOESI_hammer.opt' with 'gcc-version-12'...
Done.
  * Building target 'NULL_MOESI_hammer.fast' with 'gcc-version-12'...
Done.
  * Building target 'MIPS.opt' with 'gcc-version-12'...
Done.
  * Building target 'MIPS.fast' with 'gcc-version-12'...
Done.
  * Building target 'ARM.opt' with 'gcc-version-12'...
Done.
  * Building target 'ARM.fast' with 'gcc-version-12'...
Done.
  * Building target 'ALL.opt' with 'gcc-version-12'...
Done.
  * Building target 'ALL.fast' with 'gcc-version-12'...
Done.
  * Building target 'ARM_MOESI_hammer.opt' with 'gcc-version-12'...
Done.
  * Building target 'ARM_MOESI_hammer.fast' with 'gcc-version-12'...
Done.
  * Building target 'X86_MI_example.opt' with 'gcc-version-12'...
Done.
  * Building target 'X86_MI_example.fast' with 'gcc-version-12'...
Done.
  * Building target 'NULL_MOESI_CMP_directory.opt' with 'gcc-version-12'...
Done.
  * Building target 'NULL_MOESI_CMP_directory.fast' with 'gcc-version-12'...
Done.
  * Building target 'ARM_MESI_Three_Level_HTM.opt' with 'gcc-version-12'...
Done.
  * Building target 'ARM_MESI_Three_Level_HTM.fast' with 'gcc-version-12'...
Done.
  * Building target 'RISCV.opt' with 'gcc-version-12'...
Done.
  * Building target 'RISCV.fast' with 'gcc-version-12'...
Done.
Starting build tests with 'gcc-version-11'...
  * Building target 'NULL_MOESI_hammer.opt' with 'gcc-version-11'...
Done.
  * Building target 'NULL_MOESI_hammer.fast' with 'gcc-version-11'...
Done.
Starting build tests with 'gcc-version-10'...
  * Building target 'ARM_MESI_Three_Level.opt' with 'gcc-version-10'...
Done.
  * Building target 'ARM_MESI_Three_Level.fast' with 'gcc-version-10'...
Done.
Starting build tests with 'gcc-version-9'...
  * Building target 'Garnet_standalone.opt' with 'gcc-version-9'...
Done.
  * Building target 'Garnet_standalone.fast' with 'gcc-version-9'...
Done.
Starting build tests with 'gcc-version-8'...
  * Building target 'RISCV.opt' with 'gcc-version-8'...
Done.
  * Building target 'RISCV.fast' with 'gcc-version-8'...
Done.
Starting build tests with 'gcc-version-7'...
  * Building target 'SPARC.opt' with 'gcc-version-7'...
  ! Failed with exit code 2.
  * Building target 'SPARC.fast' with 'gcc-version-7'...
  ! Failed with exit code 2.
Starting build tests with 'clang-version-14'...
'clang-version-14' was found in the comprehensive tests. All ISAs will be built.
  * Building target 'NULL_MOESI_hammer.opt' with 'clang-version-14'...
Done.
  * Building target 'NULL_MOESI_hammer.fast' with 'clang-version-14'...
Done.
  * Building target 'MIPS.opt' with 'clang-version-14'...
Done.
  * Building target 'MIPS.fast' with 'clang-version-14'...
Done.
  * Building target 'ARM_MESI_Three_Level_HTM.opt' with

[gem5-dev] [S] Change in gem5/gem5[develop]: stdlib: Fix SwitchableProcessor use in SE mode

2023-04-17 Thread Bobby Bruce (Gerrit) via gem5-dev

Bobby Bruce has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/68997?usp=email )


Change subject: stdlib: Fix SwitchableProcessor use in SE mode
..

stdlib: Fix SwitchableProcessor use in SE mode

The SwitchableProcessors in the standard library have switched-in and
switched-out cores. The `get_cores` API in the stdlib only returns
switched-in cores. In most uses this is desirable.

In the case of setting workloads in SE mode it's necessary to set the
workload to every core, switched-in and switched-out. As the `get_cores`
function was used for this, SwitchableProcessors were failing when used
in SE Mode.

This patch checks the processor type and, if a SwitchableProcessor, uses
the SwitchableProcessor's special `_all_cores` function which gets all
the cores, regardless as to their switched-in/switched-out status.

Issue-on: https://gem5.atlassian.net/browse/GEM5-1320

Change-Id: I0b7a699ac6196e827667955bef7afa37b2648744
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/68997
Reviewed-by: Jason Lowe-Power 
Tested-by: kokoro 
Maintainer: Bobby Bruce 
Reviewed-by: Bobby Bruce 
---
M src/python/gem5/components/boards/se_binary_workload.py
1 file changed, 19 insertions(+), 2 deletions(-)

Approvals:
  Bobby Bruce: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass
  Jason Lowe-Power: Looks good to me, approved




diff --git a/src/python/gem5/components/boards/se_binary_workload.py  
b/src/python/gem5/components/boards/se_binary_workload.py

index 98fe840..c62a1b6 100644
--- a/src/python/gem5/components/boards/se_binary_workload.py
+++ b/src/python/gem5/components/boards/se_binary_workload.py
@@ -35,6 +35,8 @@
 SimpointDirectoryResource,
 )

+from ..processors.switchable_processor import SwitchableProcessor
+
 from gem5.resources.elfie import ELFieInfo
 from gem5.resources.looppoint import Looppoint

@@ -112,8 +114,23 @@
 if env_list is not None:
 process.env = env_list

-for core in self.get_processor().get_cores():
-core.set_workload(process)
+if isinstance(self.get_processor(), SwitchableProcessor):
+# This is a hack to get switchable processors working  
correctly in
+# SE mode. The "get_cores" API for processors only gets the  
current

+# switched-in cores and, in most cases, this is what the script
+# required. In the case there are switched-out cores via the
+# SwitchableProcessor, we sometimes need to apply things to ALL
+# cores (switched-in or switched-out). In this case we have an
+# `__all_cores` function. Here we must apply the process to  
every

+# core.
+#
+# A better API for this which avoids `isinstance` checks would  
be

+# welcome.
+for core in self.get_processor()._all_cores():
+core.set_workload(process)
+else:
+for core in self.get_processor().get_cores():
+core.set_workload(process)

 # Set whether to exit on work items for the se_workload
 self.exit_on_work_items = exit_on_work_items

--
To view, visit  
https://gem5-review.googlesource.com/c/public/gem5/+/68997?usp=email
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I0b7a699ac6196e827667955bef7afa37b2648744
Gerrit-Change-Number: 68997
Gerrit-PatchSet: 4
Gerrit-Owner: Bobby Bruce 
Gerrit-Reviewer: Bobby Bruce 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: kokoro 
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org

[gem5-dev] Build failed in Jenkins: weekly #118

[gem5-dev] [S] Change in gem5/gem5[develop]: mem-ruby: Not flushing data to memory when there's no dirty block

[gem5-dev] Build failed in Jenkins: compiler-checks #578

[gem5-dev] [S] Change in gem5/gem5[develop]: stdlib: Fix SwitchableProcessor use in SE mode

4 matches

Site Navigation

Mail list logo

Footer information