[gem5-dev] Change in gem5/gem5[master]: sim-se: Enhance clone for X86KvmCPU
quot;KVM CPU model is not supported for this ISA"); +#endif +} else { +TheISA::PCState cpc = tc->pcState(); +cpc.advance(); +ctc->pcState(cpc); +} ctc->activate(); return cp->pid(); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18268 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I2b2a7b1edb1c56eeb9c4fa0553cd236029cd53f8 Gerrit-Change-Number: 18268 Gerrit-PatchSet: 4 Gerrit-Owner: Alexandru Duțu Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: kokoro Gerrit-MessageType: merged ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: Enhance clone for X86KvmCPU
Hello Jason Lowe-Power, kokoro, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/18268 to look at the new patch set (#3). Change subject: sim-se: Enhance clone for X86KvmCPU .. sim-se: Enhance clone for X86KvmCPU This changeset enables clone to work with X86KvmCPU model, which will allow running multi-threaded applications at near hardware speeds. Even though the application is multi-threaded, the KvmCPU model uses one event queue, therefore, only one hardware thread will be used, through KVM, to simulate multiple application threads. Change-Id: I2b2a7b1edb1c56eeb9c4fa0553cd236029cd53f8 --- M src/arch/x86/process.cc M src/mem/multi_level_page_table.hh M src/mem/page_table.hh M src/sim/process.cc M src/sim/process.hh M src/sim/syscall_emul.hh 6 files changed, 37 insertions(+), 6 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18268 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I2b2a7b1edb1c56eeb9c4fa0553cd236029cd53f8 Gerrit-Change-Number: 18268 Gerrit-PatchSet: 3 Gerrit-Owner: Alexandru Duțu Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: kokoro Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: Enhance clone for X86KvmCPU
Hello Jason Lowe-Power, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/18268 to look at the new patch set (#2). Change subject: sim-se: Enhance clone for X86KvmCPU .. sim-se: Enhance clone for X86KvmCPU This changeset enables clone to work with X86KvmCPU model, which will allow running multi-threaded applications at near hardware speeds. Even though the application is multi-threaded, the KvmCPU model uses one event queue, therefore, only one hardware thread will be used, through KVM, to simulate multiple application threads. Change-Id: I2b2a7b1edb1c56eeb9c4fa0553cd236029cd53f8 --- M src/arch/x86/process.cc M src/mem/multi_level_page_table.hh M src/mem/page_table.hh M src/sim/process.cc M src/sim/process.hh M src/sim/syscall_emul.hh 6 files changed, 37 insertions(+), 6 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18268 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I2b2a7b1edb1c56eeb9c4fa0553cd236029cd53f8 Gerrit-Change-Number: 18268 Gerrit-PatchSet: 2 Gerrit-Owner: Alexandru Duțu Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Jason Lowe-Power Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: Enhance clone for X86KvmCPU
ps://gem5-review.googlesource.com/c/public/gem5/+/18268 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I2b2a7b1edb1c56eeb9c4fa0553cd236029cd53f8 Gerrit-Change-Number: 18268 Gerrit-PatchSet: 1 Gerrit-Owner: Alexandru Duțu Gerrit-MessageType: newchange ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: add socket ioctls
Alexandru Duțu has uploaded a new patch set (#21) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/12123 ) Change subject: sim-se: add socket ioctls .. sim-se: add socket ioctls The OpenMPI 1.8.2 runtime needs the ioctl code included in this patch to issue socket operations on the host machine. Change-Id: I687b31f375a846f0bab2debd9b9472605a4d2c7d --- M src/sim/syscall_emul.hh 1 file changed, 57 insertions(+), 10 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12123 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I687b31f375a846f0bab2debd9b9472605a4d2c7d Gerrit-Change-Number: 12123 Gerrit-PatchSet: 21 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Brandon Potter Gerrit-Reviewer: Hoa Nguyen Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: John Alsop Gerrit-Reviewer: kokoro Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: create Proc out files in out dir
Alexandru Duțu has uploaded a new patch set (#20) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/12122 ) Change subject: sim-se: create Proc out files in out dir .. sim-se: create Proc out files in out dir Redirected output files from Process objects were being created in the current directory instead of in the output directory. Change-Id: Ieb6ab5556fbcc811f4f24910da247d4dcdbc71bd --- M src/sim/fd_array.cc 1 file changed, 3 insertions(+), 1 deletion(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12122 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Ieb6ab5556fbcc811f4f24910da247d4dcdbc71bd Gerrit-Change-Number: 12122 Gerrit-PatchSet: 20 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Brandon Potter Gerrit-Reviewer: John Alsop Gerrit-CC: Jason Lowe-Power Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: add a faux-filesystem
Alexandru Duțu has uploaded a new patch set (#18) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/12119 ) Change subject: sim-se: add a faux-filesystem .. sim-se: add a faux-filesystem This change introduces the concept of a faux-filesystem. The faux-filesystem creates a directory structure in m5out (or whatever output dir the user specifies) where system calls may be redirected. This is useful to avoid non-determinism when reading files with varying path names (e.g., variations from run-to-run if the simulation is scheduled on a cluster where paths may change). Also, this changeset allows circumventing host pseudofiles which have information specific to the host processor (such as cache hierarchy or processor information). Bypassing host pseudofiles can be useful when executing runtimes in the absence of an operating system kernel since runtimes may try to query standard files (i.e. /proc or /sys) which are not relevant to an application executing in syscall emulation mode. Change-Id: I90821b3b403168b904a662fa98b85def1628621c --- A configs/common/FileSystemConfig.py M configs/common/Options.py M configs/example/se.py A src/doc/se-files.txt M src/kern/linux/linux.cc M src/sim/Process.py A src/sim/RedirectPath.py M src/sim/SConscript M src/sim/System.py M src/sim/process.cc M src/sim/process.hh A src/sim/redirect_path.cc A src/sim/redirect_path.hh M src/sim/syscall_emul.cc M src/sim/syscall_emul.hh M src/sim/system.cc M src/sim/system.hh 17 files changed, 755 insertions(+), 94 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12119 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I90821b3b403168b904a662fa98b85def1628621c Gerrit-Change-Number: 12119 Gerrit-PatchSet: 18 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Anthony Gutierrez Gerrit-Reviewer: Brandon Potter Gerrit-Reviewer: Ciro Santilli Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: kokoro Gerrit-CC: Andreas Sandberg Gerrit-CC: Giacomo Travaglini Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: configs: faux-filesystem fix w/ ruby in se mode
Alexandru Duțu has uploaded a new patch set (#20) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/12121 ) Change subject: configs: faux-filesystem fix w/ ruby in se mode .. configs: faux-filesystem fix w/ ruby in se mode These changes are needed so that the config scripts can report cache hierarchy information to the faux filesystem. This is useful for the ROCm runtime when it reads psuedofiles from the host filesytem from "/proc". Change-Id: Iad3e6c088d47c9b93979f584de748367eae8259b --- M configs/ruby/MESI_Three_Level.py M configs/ruby/MESI_Two_Level.py M configs/ruby/MI_example.py M configs/ruby/MOESI_CMP_directory.py M configs/ruby/MOESI_CMP_token.py M configs/ruby/MOESI_hammer.py M configs/ruby/Ruby.py M configs/topologies/BaseTopology.py M configs/topologies/Cluster.py M configs/topologies/Crossbar.py M configs/topologies/CrossbarGarnet.py M configs/topologies/MeshDirCorners_XY.py M configs/topologies/Mesh_XY.py M configs/topologies/Mesh_westfirst.py M configs/topologies/Pt2Pt.py 15 files changed, 235 insertions(+), 10 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12121 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Iad3e6c088d47c9b93979f584de748367eae8259b Gerrit-Change-Number: 12121 Gerrit-PatchSet: 20 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: John Alsop Gerrit-CC: Giacomo Travaglini Gerrit-CC: Jason Lowe-Power Gerrit-CC: Nikos Nikoleris Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se, tests: add a new sim-se test
Alexandru Duțu has uploaded a new patch set (#9) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/17112 ) Change subject: sim-se, tests: add a new sim-se test .. sim-se, tests: add a new sim-se test This changeset adds a test to check the redirection features added in faux-filesystem changeset. The test contains a "chdir" system call to "/proc" which should be redirected to "$(gem5-dir)/m5out/fs/proc" (as specified by the config files). After "chdir", the test subsequently outputs the "/proc/cpuinfo" file which should output a configuration of a fake cpu with values set by a Python configuration file. Note, the test will call "clone" once. To avoid a runtime error, make sure that you run this test with "-n2" supplied to the "config/example/se.py" script. Change-Id: I505b046b7a4feddfa93a6ef0f0773ac43078cc94 --- A tests/test-progs/chdir-print/Makefile A tests/test-progs/chdir-print/README.txt A tests/test-progs/chdir-print/chdir-print.c 3 files changed, 77 insertions(+), 0 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17112 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I505b046b7a4feddfa93a6ef0f0773ac43078cc94 Gerrit-Change-Number: 17112 Gerrit-PatchSet: 9 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Brandon Potter Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: John Alsop Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: add new getpgrp system call
Alexandru Duțu has uploaded a new patch set (#9) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/17111 ) Change subject: sim-se: add new getpgrp system call .. sim-se: add new getpgrp system call This changeset adds new (relatively simple) system call support. The getpgrp call returns a thread context's pgid. Change-Id: I361bdbfb9c01b761ddd5a4923d23f86971f8d614 --- M src/arch/x86/linux/process.cc M src/sim/syscall_emul.cc M src/sim/syscall_emul.hh 3 files changed, 11 insertions(+), 1 deletion(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17111 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I361bdbfb9c01b761ddd5a4923d23f86971f8d614 Gerrit-Change-Number: 17111 Gerrit-PatchSet: 9 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Ayaz Akram Gerrit-Reviewer: John Alsop Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: fstat64 bugfix
Alexandru Duțu has uploaded a new patch set (#9) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/17110 ) Change subject: sim-se: fstat64 bugfix .. sim-se: fstat64 bugfix The fstat64 system call does an upcast on entries in the file descriptor array to check if the file descriptor has a backing host-filesystem file opened. It does so because it needs to pass the host fd into the fstat call (since we rely on the host filesystem to service filesystem system calls). The upcast was overly specific. This changeset alters the system call to use the most general base class of the file descriptor entries that can satisfy the code. Change-Id: I10daf820257cea4d678ee6917e01e9cc9cd1cf5e --- M src/sim/syscall_emul.hh 1 file changed, 1 insertion(+), 1 deletion(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17110 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I10daf820257cea4d678ee6917e01e9cc9cd1cf5e Gerrit-Change-Number: 17110 Gerrit-PatchSet: 9 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: John Alsop Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: add new option to getrlimit syscall
Alexandru Duțu has uploaded a new patch set (#9) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/17109 ) Change subject: sim-se: add new option to getrlimit syscall .. sim-se: add new option to getrlimit syscall The NPROC option was not serviced by the getrlimit syscall. This changeset adds in the necessary code to service the option. Change-Id: I679d3949c3bbb0628188f4e33034028d7726fdcb --- M src/sim/syscall_emul.hh 1 file changed, 6 insertions(+), 0 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17109 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I679d3949c3bbb0628188f4e33034028d7726fdcb Gerrit-Change-Number: 17109 Gerrit-PatchSet: 9 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: John Alsop Gerrit-Reviewer: Matt Sinclair Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: small performance optimization
Alexandru Duțu has uploaded a new patch set (#9) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/17108 ) Change subject: sim-se: small performance optimization .. sim-se: small performance optimization A local variable was being set inside a loop when it should have been set outside the loop. This changeset moves the variable to the appropriate place. Change-Id: If7655b501bd819c39d35dea4c316b4b9ed3173a2 --- M src/sim/process.cc 1 file changed, 1 insertion(+), 1 deletion(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17108 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: If7655b501bd819c39d35dea4c316b4b9ed3173a2 Gerrit-Change-Number: 17108 Gerrit-PatchSet: 9 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: John Alsop Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: do not redirect for /proc/self/exe
Alexandru Duțu has uploaded a new patch set (#19) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/12312 ) Change subject: sim-se: do not redirect for /proc/self/exe .. sim-se: do not redirect for /proc/self/exe Change-Id: I38286282759963f479efe97db5818a32b3a7dd73 --- M src/sim/syscall_emul.cc 1 file changed, 2 insertions(+), 3 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12312 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I38286282759963f479efe97db5818a32b3a7dd73 Gerrit-Change-Number: 12312 Gerrit-PatchSet: 19 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: John Alsop Gerrit-Reviewer: Matt Sinclair Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: enhance clone for X86KvmCPU
Alexandru Duțu has uploaded a new patch set (#20) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/12309 ) Change subject: sim-se: enhance clone for X86KvmCPU .. sim-se: enhance clone for X86KvmCPU This changeset enables clone to work with X86KvmCPU model, which will allow running multi-threaded applications at near hardware speeds. Even though the application is multi-threaded, the KvmCPU model uses one event queue, therefore, only one hardware thread will be used, through KVM, to simulate multiple application threads. Change-Id: I2879e20518bf6c0c19fbc7e11b1583c22b59ef3b --- M src/arch/x86/process.cc M src/mem/multi_level_page_table.hh M src/mem/page_table.hh M src/sim/process.cc M src/sim/process.hh M src/sim/syscall_emul.hh 6 files changed, 41 insertions(+), 7 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12309 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I2879e20518bf6c0c19fbc7e11b1583c22b59ef3b Gerrit-Change-Number: 12309 Gerrit-PatchSet: 20 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: John Alsop Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: generate /proc/self/maps file
Alexandru Duțu has uploaded a new patch set (#19) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/12311 ) Change subject: sim-se: generate /proc/self/maps file .. sim-se: generate /proc/self/maps file This change generates /proc/self/maps for the currently running process. It assummes a system with one process and one thread per process. This is needed by the OpenCL runtime, as it calls pthread_getattr_np. Change-Id: Iee0f35842ef5571f6b0717194bc746a585a945e6 --- M configs/common/FileSystemConfig.py M src/arch/alpha/process.cc M src/arch/x86/process.cc M src/kern/linux/linux.cc M src/kern/linux/linux.hh M src/mem/vma.hh M src/sim/mem_state.cc M src/sim/mem_state.hh M src/sim/syscall_emul.hh 9 files changed, 89 insertions(+), 21 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12311 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: Iee0f35842ef5571f6b0717194bc746a585a945e6 Gerrit-Change-Number: 12311 Gerrit-PatchSet: 19 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: John Alsop Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: adding pipe2 syscall
Alexandru Duțu has uploaded a new patch set (#19) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/12310 ) Change subject: sim-se: adding pipe2 syscall .. sim-se: adding pipe2 syscall pipe2 builds on top of the pipe syscall implementation by adding some extra flags for the files (to avoid have to make separate calls to fcntl). Change-Id: I88cf6f1387b9d14e60b33a32db412da9ed93a3e6 --- M src/arch/x86/linux/process.cc M src/sim/syscall_emul.cc M src/sim/syscall_emul.hh 3 files changed, 63 insertions(+), 6 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12310 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I88cf6f1387b9d14e60b33a32db412da9ed93a3e6 Gerrit-Change-Number: 12310 Gerrit-PatchSet: 19 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: John Alsop Gerrit-Reviewer: Matt Sinclair Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: Enhance clone for X86KvmCPU
Alexandru Duțu has uploaded a new patch set (#19) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/12309 ) Change subject: sim-se: Enhance clone for X86KvmCPU .. sim-se: Enhance clone for X86KvmCPU This changeset enables clone to work with X86KvmCPU model, which will allow running multi-threaded applications at near hardware speeds. Even though the application is multi-threaded, the KvmCPU model uses one event queue, therefore, only one hardware thread will be used, through KVM, to simulate multiple application threads. Change-Id: I2879e20518bf6c0c19fbc7e11b1583c22b59ef3b --- M src/arch/x86/process.cc M src/mem/multi_level_page_table.hh M src/mem/page_table.hh M src/sim/process.cc M src/sim/process.hh M src/sim/syscall_emul.hh 6 files changed, 41 insertions(+), 7 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12309 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I2879e20518bf6c0c19fbc7e11b1583c22b59ef3b Gerrit-Change-Number: 12309 Gerrit-PatchSet: 19 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: John Alsop Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: sim-se: Enhance clone for X86KvmCPU
Alexandru Duțu has uploaded a new patch set (#16) to the change originally created by Brandon Potter. ( https://gem5-review.googlesource.com/c/public/gem5/+/12309 ) Change subject: sim-se: Enhance clone for X86KvmCPU .. sim-se: Enhance clone for X86KvmCPU This changeset enables clone to work with X86KvmCPU model, which will allow running multi-threaded applications at near hardware speeds. Even though the application is multi-threaded, the KvmCPU model uses one event queue, therefore, only one hardware thread will be used, through KVM, to simulate multiple application threads. Change-Id: I2879e20518bf6c0c19fbc7e11b1583c22b59ef3b --- M src/arch/x86/process.cc M src/mem/multi_level_page_table.hh M src/mem/page_table.hh M src/sim/process.cc M src/sim/process.hh M src/sim/syscall_emul.hh 6 files changed, 36 insertions(+), 6 deletions(-) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12309 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I2879e20518bf6c0c19fbc7e11b1583c22b59ef3b Gerrit-Change-Number: 12309 Gerrit-PatchSet: 16 Gerrit-Owner: Brandon Potter Gerrit-Reviewer: Alexandru Duțu Gerrit-CC: Jason Lowe-Power Gerrit-MessageType: newpatchset ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: gpu-compute: Remove unneeded Request::setVirt call
Alexandru Duțu has submitted this change and it was merged. ( https://gem5-review.googlesource.com/11549 ) Change subject: gpu-compute: Remove unneeded Request::setVirt call .. gpu-compute: Remove unneeded Request::setVirt call This sets the members of a Request object to the values they already hold, except the atomicOpFunctor which is set to nullptr. This call introduces a bug for atomics and is not useful for non-atomic requests. This changeset is also adding the wave PC and instruction sequence number to the Request object. Change-Id: I62f7b4a597483b0aa848a0cfbc72181e1063f56a Reviewed-on: https://gem5-review.googlesource.com/11549 Reviewed-by: Jason Lowe-Power Reviewed-by: Anthony Gutierrez Reviewed-by: Matt Sinclair Maintainer: Anthony Gutierrez --- M src/gpu-compute/compute_unit.cc 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Jason Lowe-Power: Looks good to me, approved Anthony Gutierrez: Looks good to me, approved; Looks good to me, approved Matt Sinclair: Looks good to me, approved diff --git a/src/gpu-compute/compute_unit.cc b/src/gpu-compute/compute_unit.cc index 1a174c9..fd328ad 100644 --- a/src/gpu-compute/compute_unit.cc +++ b/src/gpu-compute/compute_unit.cc @@ -747,9 +747,10 @@ updatePageDivergenceDist(tmp_vaddr); -pkt->req->setVirt(pkt->req->getAsid(), tmp_vaddr, pkt->req->getSize(), - pkt->req->getFlags(), pkt->req->masterId(), - pkt->req->getPC()); +// set PC in request +pkt->req->setPC(gpuDynInst->wavefront()->pc()); + +pkt->req->setReqInstSeqNum(gpuDynInst->seqNum()); // figure out the type of the request to set read/write BaseTLB::Mode TLB_mode; -- To view, visit https://gem5-review.googlesource.com/11549 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I62f7b4a597483b0aa848a0cfbc72181e1063f56a Gerrit-Change-Number: 11549 Gerrit-PatchSet: 2 Gerrit-Owner: Alexandru Duțu Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Anthony Gutierrez Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Matt Sinclair Gerrit-MessageType: merged ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in gem5/gem5[master]: gpu-compute: Remove unneeded Request::setVirt call
Alexandru Duțu has uploaded this change for review. ( https://gem5-review.googlesource.com/11549 Change subject: gpu-compute: Remove unneeded Request::setVirt call .. gpu-compute: Remove unneeded Request::setVirt call This sets the members of a Request object to the values they already hold, except the atomicOpFunctor which is set to nullptr. This call introduces a bug for atomics and is not useful for non-atomic requests. This changeset is also adding the wave PC and instruction sequence number to the Request object. Change-Id: I62f7b4a597483b0aa848a0cfbc72181e1063f56a --- M src/gpu-compute/compute_unit.cc 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gpu-compute/compute_unit.cc b/src/gpu-compute/compute_unit.cc index 1a174c9..fd328ad 100644 --- a/src/gpu-compute/compute_unit.cc +++ b/src/gpu-compute/compute_unit.cc @@ -747,9 +747,10 @@ updatePageDivergenceDist(tmp_vaddr); -pkt->req->setVirt(pkt->req->getAsid(), tmp_vaddr, pkt->req->getSize(), - pkt->req->getFlags(), pkt->req->masterId(), - pkt->req->getPC()); +// set PC in request +pkt->req->setPC(gpuDynInst->wavefront()->pc()); + +pkt->req->setReqInstSeqNum(gpuDynInst->seqNum()); // figure out the type of the request to set read/write BaseTLB::Mode TLB_mode; -- To view, visit https://gem5-review.googlesource.com/11549 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I62f7b4a597483b0aa848a0cfbc72181e1063f56a Gerrit-Change-Number: 11549 Gerrit-PatchSet: 1 Gerrit-Owner: Alexandru Duțu Gerrit-MessageType: newchange ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in public/gem5[master]: scons: No error for unused functions
Alexandru Duțu has uploaded this change for review. ( https://gem5-review.googlesource.com/9561 Change subject: scons: No error for unused functions .. scons: No error for unused functions Change-Id: I46093466135572fc1543682923d39521456d85f0 --- M SConstruct 1 file changed, 1 insertion(+), 0 deletions(-) diff --git a/SConstruct b/SConstruct index 8fde133..da1ba8d 100755 --- a/SConstruct +++ b/SConstruct @@ -367,6 +367,7 @@ main.Append(CCFLAGS=['-Werror', '-Wno-error=deprecated-declarations', '-Wno-error=deprecated', + '-Wno-error=unused-function' ]) else: print(termcap.Yellow + termcap.Bold + 'Error' + termcap.Normal, end=' ') -- To view, visit https://gem5-review.googlesource.com/9561 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-Change-Id: I46093466135572fc1543682923d39521456d85f0 Gerrit-Change-Number: 9561 Gerrit-PatchSet: 1 Gerrit-Owner: Alexandru DuțuGerrit-MessageType: newchange ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in public/gem5[master]: syscall_emul: Argument retrieval bug fix
Alexandru Duțu has submitted this change and it was merged. ( https://gem5-review.googlesource.com/3040 ) Change subject: syscall_emul: Argument retrieval bug fix .. syscall_emul: Argument retrieval bug fix This commit fixes a stack-buffer underflow by fixing the way the array is indexed. Change-Id: I44400e2b99a2f8e1f48f673cd110b9dcd6480a72 Reviewed-on: https://gem5-review.googlesource.com/3040 Reviewed-by: Jason Lowe-PowerReviewed-by: Andreas Sandberg Reviewed-by: Curtis Dunham Maintainer: Brandon Potter --- M src/sim/syscall_desc.cc 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jason Lowe-Power: Looks good to me, approved Andreas Sandberg: Looks good to me, approved Curtis Dunham: Looks good to me, approved Brandon Potter: Looks good to me, approved diff --git a/src/sim/syscall_desc.cc b/src/sim/syscall_desc.cc index 13b5190..3696c17 100644 --- a/src/sim/syscall_desc.cc +++ b/src/sim/syscall_desc.cc @@ -54,11 +54,11 @@ /** * Step through the first six parameters for the system call and * retrieve their values. Note that index is incremented as a - * side-effect of the getSyscallArg method which is why the LHS - * needs the "-1". + * side-effect of the getSyscallArg method. */ -for (int index = 0; index < 6; ) -arg[index - 1] = process->getSyscallArg(tc, index); +int index = 0; +for (int i = 0; i < 6; i++) +arg[i] = process->getSyscallArg(tc, index); /** * Linux supports up to six system call arguments through registers -- To view, visit https://gem5-review.googlesource.com/3040 To unsubscribe, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I44400e2b99a2f8e1f48f673cd110b9dcd6480a72 Gerrit-Change-Number: 3040 Gerrit-PatchSet: 5 Gerrit-Owner: Alexandru Duțu Gerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Brandon Potter Gerrit-Reviewer: Curtis Dunham Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in public/gem5[master]: syscall_emul: Argument retrieval bug fix
Hello Jason Lowe-Power, Curtis Dunham, Tony Gutierrez, Andreas Sandberg, Brandon Potter, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/3040 to look at the new patch set (#4). Change subject: syscall_emul: Argument retrieval bug fix .. syscall_emul: Argument retrieval bug fix This commit fixes a stack-buffer underflow by fixing the way the array is indexed. Change-Id: I44400e2b99a2f8e1f48f673cd110b9dcd6480a72 --- M src/sim/syscall_desc.cc 1 file changed, 4 insertions(+), 4 deletions(-) -- To view, visit https://gem5-review.googlesource.com/3040 To unsubscribe, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I44400e2b99a2f8e1f48f673cd110b9dcd6480a72 Gerrit-Change-Number: 3040 Gerrit-PatchSet: 4 Gerrit-Owner: Alexandru DuțuGerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Brandon Potter Gerrit-Reviewer: Curtis Dunham Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in public/gem5[master]: syscall_emul: Argument retrieval bug fix
Hello Jason Lowe-Power, Tony Gutierrez, Brandon Potter, I'd like you to reexamine a change. Please visit https://gem5-review.googlesource.com/3040 to look at the new patch set (#3). Change subject: syscall_emul: Argument retrieval bug fix .. syscall_emul: Argument retrieval bug fix This commit fixes a stack-buffer underflow by fixing the way the array is indexed. Change-Id: I44400e2b99a2f8e1f48f673cd110b9dcd6480a72 --- M src/sim/syscall_desc.cc 1 file changed, 4 insertions(+), 5 deletions(-) -- To view, visit https://gem5-review.googlesource.com/3040 To unsubscribe, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I44400e2b99a2f8e1f48f673cd110b9dcd6480a72 Gerrit-Change-Number: 3040 Gerrit-PatchSet: 3 Gerrit-Owner: Alexandru DuțuGerrit-Reviewer: Alexandru Duțu Gerrit-Reviewer: Brandon Potter Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in public/gem5[master]: syscall_emul: Argument retrieval bug fix
Alexandru Duțu has uploaded a new patch set (#2). ( https://gem5-review.googlesource.com/3040 ) Change subject: syscall_emul: Argument retrieval bug fix .. syscall_emul: Argument retrieval bug fix This commit fixes a stack-buffer underflow by fixing the way the array is indexed. Change-Id: I44400e2b99a2f8e1f48f673cd110b9dcd6480a72 --- M src/sim/syscall_desc.cc 1 file changed, 3 insertions(+), 5 deletions(-) -- To view, visit https://gem5-review.googlesource.com/3040 To unsubscribe, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I44400e2b99a2f8e1f48f673cd110b9dcd6480a72 Gerrit-Change-Number: 3040 Gerrit-PatchSet: 2 Gerrit-Owner: Alexandru Duțu___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Change in public/gem5[master]: syscall_emul: Argument retrieval bug fix This commit fixes a...
Alexandru Duțu has uploaded this change for review. ( https://gem5-review.googlesource.com/3040 Change subject: syscall_emul: Argument retrieval bug fix This commit fixes a stack-buffer underflow by fixing the way the array is indexed. .. syscall_emul: Argument retrieval bug fix This commit fixes a stack-buffer underflow by fixing the way the array is indexed. Change-Id: I44400e2b99a2f8e1f48f673cd110b9dcd6480a72 --- M src/sim/syscall_desc.cc 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/sim/syscall_desc.cc b/src/sim/syscall_desc.cc index 13b5190..7c948fa 100644 --- a/src/sim/syscall_desc.cc +++ b/src/sim/syscall_desc.cc @@ -53,12 +53,10 @@ /** * Step through the first six parameters for the system call and - * retrieve their values. Note that index is incremented as a - * side-effect of the getSyscallArg method which is why the LHS - * needs the "-1". + * retrieve their values. */ -for (int index = 0; index < 6; ) -arg[index - 1] = process->getSyscallArg(tc, index); +for (int i = 0, index = 0; i < 6; i++) +arg[i] = process->getSyscallArg(tc, index); /** * Linux supports up to six system call arguments through registers -- To view, visit https://gem5-review.googlesource.com/3040 To unsubscribe, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I44400e2b99a2f8e1f48f673cd110b9dcd6480a72 Gerrit-Change-Number: 3040 Gerrit-PatchSet: 1 Gerrit-Owner: Alexandru Duțu___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev