[gem5-dev] [M] Change in gem5/gem5[develop]: tests: Remove tests requiring comp of novel ISAs in long
Bobby Bruce has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/65193?usp=email ) Change subject: tests: Remove tests requiring comp of novel ISAs in long .. tests: Remove tests requiring comp of novel ISAs in long The only tests requiring the the compilation of SPARC, MIPS, and POWER for the long/nightly suite were "tests/gem5/multi_isa/test_multi_isa.py" and "gem5/stdlib/test_requires.py". As compilation of gem5 is quite costly, it'd best we simply remove these tests. They are minor and not very important. Compilation of these ISAs will continue to be tested via the compilation tests. Change-Id: I98b33eec5d0adb144109d32851033380f1641ad4 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/65193 Reviewed-by: Jason Lowe-Power Maintainer: Bobby Bruce Tested-by: kokoro --- M tests/gem5/multi_isa/test_multi_isa.py M tests/gem5/stdlib/test_requires.py 2 files changed, 76 insertions(+), 39 deletions(-) Approvals: Jason Lowe-Power: Looks good to me, approved Bobby Bruce: Looks good to me, approved kokoro: Regressions pass diff --git a/tests/gem5/multi_isa/test_multi_isa.py b/tests/gem5/multi_isa/test_multi_isa.py index 2c6a96c..7d278b7 100644 --- a/tests/gem5/multi_isa/test_multi_isa.py +++ b/tests/gem5/multi_isa/test_multi_isa.py @@ -38,35 +38,42 @@ for isa in isa_map.keys(): -gem5_verify_config( -name=f"runtime-isa-check_{isa}-compiled-alone", -verifiers=(), -fixtures=(), -config=joinpath( - config.base_dir, "tests", "gem5", "configs", "runtime_isa_check.py" -), -config_args=["-e", isa], -valid_isas=(isa_map[isa],), -valid_hosts=constants.supported_hosts, -length=constants.long_tag, -) +if isa in ("x86", "arm", "riscv"): +# We only do these checks for X86, ARM, and RISCV to save compiling +# other ISAs. +gem5_verify_config( +name=f"runtime-isa-check_{isa}-compiled-alone", +verifiers=(), +fixtures=(), +config=joinpath( +config.base_dir, +"tests", +"gem5", +"configs", +"runtime_isa_check.py", +), +config_args=["-e", isa], +valid_isas=(isa_map[isa],), +valid_hosts=constants.supported_hosts, +length=constants.long_tag, +) -gem5_verify_config( -name=f"supported-isas-check_{isa}-compiled-alone", -verifiers=(), -fixtures=(), -config=joinpath( -config.base_dir, -"tests", -"gem5", -"configs", -"supported_isa_check.py", -), -config_args=["-e", isa], -valid_isas=(isa_map[isa],), -valid_hosts=constants.supported_hosts, -length=constants.long_tag, -) +gem5_verify_config( +name=f"supported-isas-check_{isa}-compiled-alone", +verifiers=(), +fixtures=(), +config=joinpath( +config.base_dir, +"tests", +"gem5", +"configs", +"supported_isa_check.py", +), +config_args=["-e", isa], +valid_isas=(isa_map[isa],), +valid_hosts=constants.supported_hosts, +length=constants.long_tag, +) if isa != "null": # The null isa is not "supported" in a case where other ISAs are diff --git a/tests/gem5/stdlib/test_requires.py b/tests/gem5/stdlib/test_requires.py index 293eb3d..b729050 100644 --- a/tests/gem5/stdlib/test_requires.py +++ b/tests/gem5/stdlib/test_requires.py @@ -47,17 +47,24 @@ } for isa in isa_map.keys(): -gem5_verify_config( -name=f"requires-isa-{isa}", -verifiers=(), -fixtures=(), -config=joinpath( - config.base_dir, "tests", "gem5", "configs", "requires_check.py" -), -config_args=["-i", isa], -valid_isas=(isa_map[isa],), -length=length_map[isa], -) +if isa in ("x86", "arm", "riscv"): +# We only do these checks for X86, ARM, and RISCV to save compiling +# other ISAs. +gem5_verify_config( +name=f"requires-isa-{isa}", +verifiers=(), +fixtures=(), +config=joinpath( +config.base_dir, +"tests", +"gem5", +"configs", +"requires_check.py", +), +config_args=["-i", isa], +valid_isas=(isa_map[isa],), +length=length_map[isa], +) if isa != "null": gem5_verify_config( -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/65193?usp=email To unsubscribe, or for help writing mail filters, visit
[gem5-dev] [M] Change in gem5/gem5[develop]: tests: Remove tests requiring comp of novel ISAs in long
Bobby Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/65193?usp=email ) Change subject: tests: Remove tests requiring comp of novel ISAs in long .. tests: Remove tests requiring comp of novel ISAs in long The only tests requiring the the compilation of SPARC, MIPS, and POWER for the long/nightly suite were "tests/gem5/multi_isa/test_multi_isa.py" and "gem5/stdlib/test_requires.py". As compilation of gem5 is quite costly, it'd best we simply remove these tests. They are minor and not very important. Compilation of these ISAs will continue to be tested via the compilation tests. Change-Id: I98b33eec5d0adb144109d32851033380f1641ad4 --- M tests/gem5/multi_isa/test_multi_isa.py M tests/gem5/stdlib/test_requires.py 2 files changed, 72 insertions(+), 39 deletions(-) diff --git a/tests/gem5/multi_isa/test_multi_isa.py b/tests/gem5/multi_isa/test_multi_isa.py index 2c6a96c..7d278b7 100644 --- a/tests/gem5/multi_isa/test_multi_isa.py +++ b/tests/gem5/multi_isa/test_multi_isa.py @@ -38,35 +38,42 @@ for isa in isa_map.keys(): -gem5_verify_config( -name=f"runtime-isa-check_{isa}-compiled-alone", -verifiers=(), -fixtures=(), -config=joinpath( - config.base_dir, "tests", "gem5", "configs", "runtime_isa_check.py" -), -config_args=["-e", isa], -valid_isas=(isa_map[isa],), -valid_hosts=constants.supported_hosts, -length=constants.long_tag, -) +if isa in ("x86", "arm", "riscv"): +# We only do these checks for X86, ARM, and RISCV to save compiling +# other ISAs. +gem5_verify_config( +name=f"runtime-isa-check_{isa}-compiled-alone", +verifiers=(), +fixtures=(), +config=joinpath( +config.base_dir, +"tests", +"gem5", +"configs", +"runtime_isa_check.py", +), +config_args=["-e", isa], +valid_isas=(isa_map[isa],), +valid_hosts=constants.supported_hosts, +length=constants.long_tag, +) -gem5_verify_config( -name=f"supported-isas-check_{isa}-compiled-alone", -verifiers=(), -fixtures=(), -config=joinpath( -config.base_dir, -"tests", -"gem5", -"configs", -"supported_isa_check.py", -), -config_args=["-e", isa], -valid_isas=(isa_map[isa],), -valid_hosts=constants.supported_hosts, -length=constants.long_tag, -) +gem5_verify_config( +name=f"supported-isas-check_{isa}-compiled-alone", +verifiers=(), +fixtures=(), +config=joinpath( +config.base_dir, +"tests", +"gem5", +"configs", +"supported_isa_check.py", +), +config_args=["-e", isa], +valid_isas=(isa_map[isa],), +valid_hosts=constants.supported_hosts, +length=constants.long_tag, +) if isa != "null": # The null isa is not "supported" in a case where other ISAs are diff --git a/tests/gem5/stdlib/test_requires.py b/tests/gem5/stdlib/test_requires.py index 293eb3d..b729050 100644 --- a/tests/gem5/stdlib/test_requires.py +++ b/tests/gem5/stdlib/test_requires.py @@ -47,17 +47,24 @@ } for isa in isa_map.keys(): -gem5_verify_config( -name=f"requires-isa-{isa}", -verifiers=(), -fixtures=(), -config=joinpath( - config.base_dir, "tests", "gem5", "configs", "requires_check.py" -), -config_args=["-i", isa], -valid_isas=(isa_map[isa],), -length=length_map[isa], -) +if isa in ("x86", "arm", "riscv"): +# We only do these checks for X86, ARM, and RISCV to save compiling +# other ISAs. +gem5_verify_config( +name=f"requires-isa-{isa}", +verifiers=(), +fixtures=(), +config=joinpath( +config.base_dir, +"tests", +"gem5", +"configs", +"requires_check.py", +), +config_args=["-i", isa], +valid_isas=(isa_map[isa],), +length=length_map[isa], +) if isa != "null": gem5_verify_config( -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/65193?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I98b33eec5d0adb144109d32851033380f1641ad4 Gerrit-Change-Number: 65193 Gerrit-PatchSet: 1 Gerrit-Owner: Bobby Bruce Gerrit-MessageType: newchange