[gem5-dev] Change in gem5/gem5[develop]: arch-power: Replace the Loader namespace with loader.

2021-10-13 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/51527 )



Change subject: arch-power: Replace the Loader namespace with loader.
..

arch-power: Replace the Loader namespace with loader.

The Loader namespace is deprecated, and is replaced with loader.

Change-Id: Ic973eefd55c6f8a43d3d41346b8b6e4795e19e55
---
M src/arch/power/insts/integer.cc
M src/arch/power/insts/integer.hh
M src/arch/power/insts/mem.cc
M src/arch/power/insts/mem.hh
4 files changed, 39 insertions(+), 28 deletions(-)



diff --git a/src/arch/power/insts/integer.cc  
b/src/arch/power/insts/integer.cc

index cf065a1..b1f10f4 100644
--- a/src/arch/power/insts/integer.cc
+++ b/src/arch/power/insts/integer.cc
@@ -117,7 +117,7 @@

 std::string
 IntArithOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printSecondSrc = true;
@@ -175,7 +175,7 @@

 std::string
 IntImmArithOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool negateImm = false;
@@ -235,7 +235,7 @@

 std::string
 IntDispArithOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printSrcs = true;
@@ -280,7 +280,7 @@

 std::string
 IntLogicOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printSecondSrc = true;
@@ -344,7 +344,7 @@

 std::string
 IntImmLogicOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printRegs = true;
@@ -392,7 +392,7 @@

 std::string
 IntCompOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printFieldPrefix = false;
@@ -445,7 +445,7 @@

 std::string
 IntImmCompOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printFieldPrefix = false;
@@ -494,7 +494,7 @@

 std::string
 IntImmCompLogicOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printFieldPrefix = false;
@@ -604,7 +604,7 @@

 std::string
 IntConcatShiftOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printSecondSrc = true;
@@ -751,7 +751,7 @@

 std::string
 IntConcatRotateOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printSecondSrc = false;
@@ -832,7 +832,7 @@

 std::string
 IntTrapOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::string ext;
 std::stringstream ss;
@@ -883,7 +883,7 @@

 std::string
 IntImmTrapOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::string ext;
 std::stringstream ss;
diff --git a/src/arch/power/insts/integer.hh  
b/src/arch/power/insts/integer.hh

index 1c298a0..9417810 100644
--- a/src/arch/power/insts/integer.hh
+++ b/src/arch/power/insts/integer.hh
@@ -364,7 +364,7 @@
 }

 std::string generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const override;
+Addr pc, const loader::SymbolTable *symtab) const override;
 };


@@ -385,7 +385,7 @@
 }

 std::string generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const override;
+Addr pc, const loader::SymbolTable *symtab) const override;
 };


@@ -406,7 +406,7 @@
 }

 std::string generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const override;
+Addr pc, const loader::SymbolTable *symtab) const override;
 };


@@ -429,7 +429,7 @@
 }

 std::string generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const override;
+Addr pc, const loader::SymbolTable *symtab) const override;
 };


@@ -450,7 +450,7 @@
 }

 std::string generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const override;

[gem5-dev] Change in gem5/gem5[develop]: arch-power: Replace the Loader namespace with loader.

2021-10-13 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/51527 )


Change subject: arch-power: Replace the Loader namespace with loader.
..

arch-power: Replace the Loader namespace with loader.

The Loader namespace is deprecated, and is replaced with loader.

Change-Id: Ic973eefd55c6f8a43d3d41346b8b6e4795e19e55
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/51527
Reviewed-by: Boris Shingarov 
Reviewed-by: Daniel Carvalho 
Maintainer: Gabe Black 
Tested-by: kokoro 
---
M src/arch/power/insts/integer.cc
M src/arch/power/insts/integer.hh
M src/arch/power/insts/mem.cc
M src/arch/power/insts/mem.hh
4 files changed, 44 insertions(+), 28 deletions(-)

Approvals:
  Boris Shingarov: Looks good to me, approved
  Daniel Carvalho: Looks good to me, approved
  Gabe Black: Looks good to me, approved
  kokoro: Regressions pass




diff --git a/src/arch/power/insts/integer.cc  
b/src/arch/power/insts/integer.cc

index cf065a1..b1f10f4 100644
--- a/src/arch/power/insts/integer.cc
+++ b/src/arch/power/insts/integer.cc
@@ -117,7 +117,7 @@

 std::string
 IntArithOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printSecondSrc = true;
@@ -175,7 +175,7 @@

 std::string
 IntImmArithOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool negateImm = false;
@@ -235,7 +235,7 @@

 std::string
 IntDispArithOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printSrcs = true;
@@ -280,7 +280,7 @@

 std::string
 IntLogicOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printSecondSrc = true;
@@ -344,7 +344,7 @@

 std::string
 IntImmLogicOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printRegs = true;
@@ -392,7 +392,7 @@

 std::string
 IntCompOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printFieldPrefix = false;
@@ -445,7 +445,7 @@

 std::string
 IntImmCompOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printFieldPrefix = false;
@@ -494,7 +494,7 @@

 std::string
 IntImmCompLogicOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printFieldPrefix = false;
@@ -604,7 +604,7 @@

 std::string
 IntConcatShiftOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printSecondSrc = true;
@@ -751,7 +751,7 @@

 std::string
 IntConcatRotateOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::stringstream ss;
 bool printSecondSrc = false;
@@ -832,7 +832,7 @@

 std::string
 IntTrapOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::string ext;
 std::stringstream ss;
@@ -883,7 +883,7 @@

 std::string
 IntImmTrapOp::generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const
+Addr pc, const loader::SymbolTable *symtab) const
 {
 std::string ext;
 std::stringstream ss;
diff --git a/src/arch/power/insts/integer.hh  
b/src/arch/power/insts/integer.hh

index 1c298a0..9417810 100644
--- a/src/arch/power/insts/integer.hh
+++ b/src/arch/power/insts/integer.hh
@@ -364,7 +364,7 @@
 }

 std::string generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const override;
+Addr pc, const loader::SymbolTable *symtab) const override;
 };


@@ -385,7 +385,7 @@
 }

 std::string generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const override;
+Addr pc, const loader::SymbolTable *symtab) const override;
 };


@@ -406,7 +406,7 @@
 }

 std::string generateDisassembly(
-Addr pc, const Loader::SymbolTable *symtab) const override;
+Addr pc, const loader::SymbolTable *symtab) const override;
 };


@@ -429,7 +429,7 @@