[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Detect when entering virtual 8086 mode.

2022-03-14 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/55810 )


 (

11 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the  
submitted one.

 )Change subject: arch-x86: Detect when entering virtual 8086 mode.
..

arch-x86: Detect when entering virtual 8086 mode.

If we're entering virtual 8086 mode, panic. Some aspects of that mode
may actually work, but since it's essentially untested, lets be extra
cautious.

Change-Id: I78bbfcb75db8370f4271c75caabc0ec53f75a884
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/55810
Reviewed-by: Matthew Poremba 
Maintainer: Gabe Black 
Tested-by: kokoro 
---
M src/arch/x86/isa.cc
1 file changed, 23 insertions(+), 0 deletions(-)

Approvals:
  Matthew Poremba: Looks good to me, approved
  Gabe Black: Looks good to me, approved
  kokoro: Regressions pass




diff --git a/src/arch/x86/isa.cc b/src/arch/x86/isa.cc
index 713346e..f426137 100644
--- a/src/arch/x86/isa.cc
+++ b/src/arch/x86/isa.cc
@@ -318,6 +318,12 @@
 break;
   case MISCREG_CR8:
 break;
+  case MISCREG_RFLAGS:
+{
+RFLAGS rflags = val;
+panic_if(rflags.vm, "Virtual 8086 mode is not supported.");
+break;
+}
   case MISCREG_CS_ATTR:
 {
 SegAttr toggled = regVal[miscReg] ^ val;

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55810
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I78bbfcb75db8370f4271c75caabc0ec53f75a884
Gerrit-Change-Number: 55810
Gerrit-PatchSet: 14
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bradford Beckmann 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Matt Sinclair 
Gerrit-Reviewer: Matthew Poremba 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Detect when entering virtual 8086 mode.

2022-01-23 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/55810 )



Change subject: arch-x86: Detect when entering virtual 8086 mode.
..

arch-x86: Detect when entering virtual 8086 mode.

If we're entering virtual 8086 mode, panic. Some aspects of that mode
may actually work, but since it's essentially untested, lets be extra
cautious.

Change-Id: I78bbfcb75db8370f4271c75caabc0ec53f75a884
---
M src/arch/x86/isa.cc
1 file changed, 19 insertions(+), 0 deletions(-)



diff --git a/src/arch/x86/isa.cc b/src/arch/x86/isa.cc
index 89e0d29..2d7c4df 100644
--- a/src/arch/x86/isa.cc
+++ b/src/arch/x86/isa.cc
@@ -314,6 +314,12 @@
 break;
   case MISCREG_CR8:
 break;
+  case MISCREG_RFLAGS:
+{
+RFLAGS rflags = val;
+panic_if(rflags.vm, "Virtual 8086 mode is not supported.");
+break;
+}
   case MISCREG_CS_ATTR:
 {
 SegAttr toggled = regVal[miscReg] ^ val;

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55810
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I78bbfcb75db8370f4271c75caabc0ec53f75a884
Gerrit-Change-Number: 55810
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s