[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Respect LDT and TR bases in long mode.

2022-02-23 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/57049 )


Change subject: arch-x86: Respect LDT and TR bases in long mode.
..

arch-x86: Respect LDT and TR bases in long mode.

The LDT and TR bases *are* respected in 64 bit mode, so the base values
need to be set as specified.

Change-Id: Ieb1b58511d9651e6e59be199059b9d2b8c670472
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/57049
Maintainer: Gabe Black 
Tested-by: kokoro 
Reviewed-by: Bobby Bruce 
Maintainer: Bobby Bruce 
---
M src/arch/x86/fs_workload.cc
1 file changed, 18 insertions(+), 3 deletions(-)

Approvals:
  Bobby Bruce: Looks good to me, approved; Looks good to me, approved
  Gabe Black: Looks good to me, approved
  kokoro: Regressions pass




diff --git a/src/arch/x86/fs_workload.cc b/src/arch/x86/fs_workload.cc
index dd71222..90df698 100644
--- a/src/arch/x86/fs_workload.cc
+++ b/src/arch/x86/fs_workload.cc
@@ -66,9 +66,7 @@
SegDescriptor desc, bool longmode)
 {
 bool honorBase = !longmode || seg == SEGMENT_REG_FS ||
-  seg == SEGMENT_REG_GS ||
-  seg == SEGMENT_REG_TSL ||
-  seg == SYS_SEGMENT_REG_TR;
+  seg == SEGMENT_REG_GS;

 SegAttr attr = 0;


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/57049
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ieb1b58511d9651e6e59be199059b9d2b8c670472
Gerrit-Change-Number: 57049
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bobby Bruce 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Respect LDT and TR bases in long mode.

2022-02-22 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/57049 )



Change subject: arch-x86: Respect LDT and TR bases in long mode.
..

arch-x86: Respect LDT and TR bases in long mode.

The LDT and TR bases *are* respected in 64 bit mode, so the base values
need to be set as specified.

Change-Id: Ieb1b58511d9651e6e59be199059b9d2b8c670472
---
M src/arch/x86/fs_workload.cc
1 file changed, 13 insertions(+), 3 deletions(-)



diff --git a/src/arch/x86/fs_workload.cc b/src/arch/x86/fs_workload.cc
index dd71222..90df698 100644
--- a/src/arch/x86/fs_workload.cc
+++ b/src/arch/x86/fs_workload.cc
@@ -66,9 +66,7 @@
SegDescriptor desc, bool longmode)
 {
 bool honorBase = !longmode || seg == SEGMENT_REG_FS ||
-  seg == SEGMENT_REG_GS ||
-  seg == SEGMENT_REG_TSL ||
-  seg == SYS_SEGMENT_REG_TR;
+  seg == SEGMENT_REG_GS;

 SegAttr attr = 0;


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/57049
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ieb1b58511d9651e6e59be199059b9d2b8c670472
Gerrit-Change-Number: 57049
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s