[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Use the right bits in the page table walker.

2022-03-14 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/55812 )


 (

11 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the  
submitted one.

 )Change subject: arch-x86: Use the right bits in the page table walker.
..

arch-x86: Use the right bits in the page table walker.

In the section of the page table walker which processes a non-PAE,
non-PSE page directory entry, use the right bits of the virtual address
to figure out what to load next.

Change-Id: I7be3339c24253aa5594f564087eb9a234c370325
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/55812
Reviewed-by: Matthew Poremba 
Maintainer: Gabe Black 
Tested-by: kokoro 
---
M src/arch/x86/pagetable_walker.cc
1 file changed, 18 insertions(+), 1 deletion(-)

Approvals:
  Matthew Poremba: Looks good to me, approved
  Gabe Black: Looks good to me, approved
  kokoro: Regressions pass




diff --git a/src/arch/x86/pagetable_walker.cc  
b/src/arch/x86/pagetable_walker.cc

index 47be278..78d10d0 100644
--- a/src/arch/x86/pagetable_walker.cc
+++ b/src/arch/x86/pagetable_walker.cc
@@ -477,7 +477,7 @@
 }
 // 4 KB page
 entry.logBytes = 12;
-nextRead = mbits(pte, 31, 12) + vaddr.norml2 * dataSize;
+nextRead = mbits(pte, 31, 12) + vaddr.norml1 * dataSize;
 nextState = PTE;
 break;
   case PTE:

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55812
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I7be3339c24253aa5594f564087eb9a234c370325
Gerrit-Change-Number: 55812
Gerrit-PatchSet: 14
Gerrit-Owner: Gabe Black 
Gerrit-Reviewer: Bradford Beckmann 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Matt Sinclair 
Gerrit-Reviewer: Matthew Poremba 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Use the right bits in the page table walker.

2022-01-23 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/55812 )



Change subject: arch-x86: Use the right bits in the page table walker.
..

arch-x86: Use the right bits in the page table walker.

In the section of the page table walker which processes a non-PAE,
non-PSE page directory entry, use the right bits of the virtual address
to figure out what to load next.

Change-Id: I7be3339c24253aa5594f564087eb9a234c370325
---
M src/arch/x86/pagetable_walker.cc
1 file changed, 14 insertions(+), 1 deletion(-)



diff --git a/src/arch/x86/pagetable_walker.cc  
b/src/arch/x86/pagetable_walker.cc

index 6c22858..0aa9e75 100644
--- a/src/arch/x86/pagetable_walker.cc
+++ b/src/arch/x86/pagetable_walker.cc
@@ -476,7 +476,7 @@
 }
 // 4 KB page
 entry.logBytes = 12;
-nextRead = mbits(pte, 31, 12) + vaddr.norml2 * dataSize;
+nextRead = mbits(pte, 31, 12) + vaddr.norml1 * dataSize;
 nextState = PTE;
 break;
   case PTE:

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55812
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I7be3339c24253aa5594f564087eb9a234c370325
Gerrit-Change-Number: 55812
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s