[gem5-dev] Change in gem5/gem5[develop]: base: Add XOR and modulo operator to ChannelAddr

2021-02-09 Thread Ciro Santilli (Gerrit) via gem5-dev 
Ciro Santilli has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/39235 )


Change subject: base: Add XOR and modulo operator to ChannelAddr
..

base: Add XOR and modulo operator to ChannelAddr

Channel address class did not offer bitwise
XOR and modulo operation. These two functions
where now added to the ChannelAddr class.

Change-Id: I02a5e49e9700cc5283415c921a25989a130e5d07
Reviewed-by: Andreas Sandberg 
Reviewed-by: Ciro Santilli 
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/39235
Reviewed-by: Daniel Carvalho 
Reviewed-by: Jason Lowe-Power 
Reviewed-by: Bobby R. Bruce 
Maintainer: Jason Lowe-Power 
Tested-by: kokoro 
---
M src/base/channel_addr.hh
1 file changed, 9 insertions(+), 1 deletion(-)

Approvals:
  Jason Lowe-Power: Looks good to me, but someone else must approve; Looks  
good to me, approved

  Daniel Carvalho: Looks good to me, but someone else must approve
  Bobby R. Bruce: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/base/channel_addr.hh b/src/base/channel_addr.hh
index 2cfe380..55d227b 100644
--- a/src/base/channel_addr.hh
+++ b/src/base/channel_addr.hh
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019 ARM Limited
+ * Copyright (c) 2019, 2021 ARM Limited
  * All rights reserved
  *
  * The license below extends only to copyright in the software and shall
@@ -93,6 +93,14 @@
 return ChannelAddr(a << b);
 }

+constexpr ChannelAddr operator^(const int b) const {
+return ChannelAddr(a ^ b);
+}
+
+constexpr ChannelAddr operator%(const int b) const {
+return ChannelAddr(a % b);
+}
+
 constexpr ChannelAddr operator*(const Type &b) const {
 return ChannelAddr(a * b);
 }

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/39235
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I02a5e49e9700cc5283415c921a25989a130e5d07
Gerrit-Change-Number: 39235
Gerrit-PatchSet: 2
Gerrit-Owner: Ciro Santilli 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Ciro Santilli 
Gerrit-Reviewer: Daniel Carvalho 
Gerrit-Reviewer: Giacomo Travaglini 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Richard Cooper 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Add XOR and modulo operator to ChannelAddr

2021-01-15 Thread Ciro Santilli (Gerrit) via gem5-dev 

Attention is currently required from: Andreas Sandberg.
Hello Andreas Sandberg,

I'd like you to do a code review. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/39235

to review the following change.


Change subject: base: Add XOR and modulo operator to ChannelAddr
..

base: Add XOR and modulo operator to ChannelAddr

Channel address class did not offer bitwise
XOR and modulo operation. These two functions
where now added to the ChannelAddr class.

Change-Id: I02a5e49e9700cc5283415c921a25989a130e5d07
Reviewed-by: Andreas Sandberg 
Reviewed-by: Ciro Santilli 
---
M src/base/channel_addr.hh
1 file changed, 9 insertions(+), 1 deletion(-)



diff --git a/src/base/channel_addr.hh b/src/base/channel_addr.hh
index 2cfe380..55d227b 100644
--- a/src/base/channel_addr.hh
+++ b/src/base/channel_addr.hh
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019 ARM Limited
+ * Copyright (c) 2019, 2021 ARM Limited
  * All rights reserved
  *
  * The license below extends only to copyright in the software and shall
@@ -93,6 +93,14 @@
 return ChannelAddr(a << b);
 }

+constexpr ChannelAddr operator^(const int b) const {
+return ChannelAddr(a ^ b);
+}
+
+constexpr ChannelAddr operator%(const int b) const {
+return ChannelAddr(a % b);
+}
+
 constexpr ChannelAddr operator*(const Type &b) const {
 return ChannelAddr(a * b);
 }

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/39235
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I02a5e49e9700cc5283415c921a25989a130e5d07
Gerrit-Change-Number: 39235
Gerrit-PatchSet: 1
Gerrit-Owner: Ciro Santilli 
Gerrit-Reviewer: Andreas Sandberg 
Gerrit-Attention: Andreas Sandberg 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s