Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/40615 )
Change subject: base: Replace a "panic" in cprintf with an M5_UNREACHABLE.
..
base: Replace a "panic" in cprintf with an M5_UNREACHABLE.
The panic was just to signal that a point in the code should be
unreachable, and brought with it a thread of dependencies which would
bring in more and more extra files as it was followed.
Change-Id: I46fb99b91929dca78a6547bdc7635aab9a63a9f3
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/40615
Tested-by: kokoro
Reviewed-by: Daniel Carvalho
Reviewed-by: Jason Lowe-Power
Maintainer: Jason Lowe-Power
---
M src/base/cprintf.cc
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
Daniel Carvalho: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/cprintf.cc b/src/base/cprintf.cc
index 03fa3cb..7a3e958 100644
--- a/src/base/cprintf.cc
+++ b/src/base/cprintf.cc
@@ -33,7 +33,6 @@
#include
#include "base/compiler.hh"
-#include "base/logging.hh"
namespace cp
{
@@ -239,7 +238,7 @@
break;
case '%':
-panic("we shouldn't get here");
+M5_UNREACHABLE;
break;
default:
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/40615
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I46fb99b91929dca78a6547bdc7635aab9a63a9f3
Gerrit-Change-Number: 40615
Gerrit-PatchSet: 3
Gerrit-Owner: Gabe Black
Gerrit-Reviewer: Bobby R. Bruce
Gerrit-Reviewer: Daniel Carvalho
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-Reviewer: kokoro
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
