[gem5-dev] Change in gem5/gem5[develop]: cpu: Fixed unused var error when with fast builds

2020-09-10 Thread Bobby R. Bruce (Gerrit) via gem5-dev
Bobby R. Bruce has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/34256 )


Change subject: cpu: Fixed unused var error when with fast builds
..

cpu: Fixed unused var error when with fast builds

As `is_htm_speculative` is only used in assert statements, it is
considered unused during the `.fast` compilation. This commit adds the
`M5_USED_VAR` macro.

This caused our compiler tests to fail:
https://www.mail-archive.com/gem5-dev@gem5.org/msg35913.html

Change-Id: I00d187d1a31d065c236ac29a657bd479ad4b03bc
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34256
Maintainer: Bobby R. Bruce 
Reviewed-by: Gabe Black 
Tested-by: kokoro 
---
M src/cpu/simple/timing.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Gabe Black: Looks good to me, approved
  Bobby R. Bruce: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/cpu/simple/timing.cc b/src/cpu/simple/timing.cc
index f22c58d..820bede 100644
--- a/src/cpu/simple/timing.cc
+++ b/src/cpu/simple/timing.cc
@@ -947,7 +947,7 @@
 // hardware transactional memory

 SimpleExecContext *t_info = threadInfo[curThread];
-const bool is_htm_speculative =
+const bool is_htm_speculative M5_VAR_USED =
 t_info->inHtmTransactionalState();

 // received a response from the dcache: complete the load or store

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/34256
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I00d187d1a31d065c236ac29a657bd479ad4b03bc
Gerrit-Change-Number: 34256
Gerrit-PatchSet: 2
Gerrit-Owner: Bobby R. Bruce 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Gabe Black 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: Timothy Hayes 
Gerrit-Reviewer: kokoro 
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: cpu: Fixed unused var error when with fast builds

2020-09-09 Thread Bobby R. Bruce (Gerrit) via gem5-dev
Bobby R. Bruce has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/34256 )



Change subject: cpu: Fixed unused var error when with fast builds
..

cpu: Fixed unused var error when with fast builds

As `is_htm_speculative` is only used in assert statements, it is
considered unused during the `.fast` compilation. This commit adds the
`M5_USED_VAR` macro.

This caused our compiler tests to fail:
https://www.mail-archive.com/gem5-dev@gem5.org/msg35913.html

Change-Id: I00d187d1a31d065c236ac29a657bd479ad4b03bc
---
M src/cpu/simple/timing.cc
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/cpu/simple/timing.cc b/src/cpu/simple/timing.cc
index f22c58d..820bede 100644
--- a/src/cpu/simple/timing.cc
+++ b/src/cpu/simple/timing.cc
@@ -947,7 +947,7 @@
 // hardware transactional memory

 SimpleExecContext *t_info = threadInfo[curThread];
-const bool is_htm_speculative =
+const bool is_htm_speculative M5_VAR_USED =
 t_info->inHtmTransactionalState();

 // received a response from the dcache: complete the load or store

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/34256
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I00d187d1a31d065c236ac29a657bd479ad4b03bc
Gerrit-Change-Number: 34256
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby R. Bruce 
Gerrit-MessageType: newchange
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s