Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/55805 )
(
11 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: dev,arch-x86: Make the I8042 reset settings more
realistic.
..
dev,arch-x86: Make the I8042 reset settings more realistic.
When powered on, the "passed self test" bit should not be set. It should
only be set once the I8042 has actually been told to do a self test.
Also the mouse and keyboard should be disabled. With them disabled their
interrupts won't matter, but we might as well leave those disabled as
well.
Change-Id: Ief1ab30365a0a8ea0a116e52c16dcccf441515ec
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/55805
Reviewed-by: Matthew Poremba
Maintainer: Gabe Black
Tested-by: kokoro
---
M src/dev/x86/i8042.cc
1 file changed, 21 insertions(+), 4 deletions(-)
Approvals:
Matthew Poremba: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/dev/x86/i8042.cc b/src/dev/x86/i8042.cc
index 7aed0ee..268d090 100644
--- a/src/dev/x86/i8042.cc
+++ b/src/dev/x86/i8042.cc
@@ -55,13 +55,11 @@
fatal_if(!mouse, "The i8042 model requires a mouse instance");
fatal_if(!keyboard, "The i8042 model requires a keyboard instance");
-statusReg.passedSelfTest = 1;
-statusReg.commandLast = 1;
statusReg.keyboardUnlocked = 1;
commandByte.convertScanCodes = 1;
-commandByte.passedSelfTest = 1;
-commandByte.keyboardFullInt = 1;
+commandByte.disableMouse = 1;
+commandByte.disableKeyboard = 1;
for (int i = 0; i < p.port_keyboard_int_pin_connection_count; i++) {
keyboardIntPin.push_back(new IntSourcePin(
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55805
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ief1ab30365a0a8ea0a116e52c16dcccf441515ec
Gerrit-Change-Number: 55805
Gerrit-PatchSet: 13
Gerrit-Owner: Gabe Black
Gerrit-Reviewer: Bradford Beckmann
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Matt Sinclair
Gerrit-Reviewer: Matthew Poremba
Gerrit-Reviewer: kokoro
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
