Hoa Nguyen has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/55863 )
Change subject: stdlib: Remove final decorator from abstract board
..
stdlib: Remove final decorator from abstract board
@typing.final was not introduced until python3.8.
Change-Id: I65a5f4b5655d2ad80f7b566f9cea8e2371b3be62
Signed-off-by: Hoa Nguyen
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/55863
Reviewed-by: Jason Lowe-Power
Maintainer: Jason Lowe-Power
Tested-by: kokoro
---
M src/python/gem5/components/boards/abstract_board.py
1 file changed, 17 insertions(+), 2 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/python/gem5/components/boards/abstract_board.py
b/src/python/gem5/components/boards/abstract_board.py
index a27cecd..30fbfca 100644
--- a/src/python/gem5/components/boards/abstract_board.py
+++ b/src/python/gem5/components/boards/abstract_board.py
@@ -37,7 +37,7 @@
VoltageDomain,
)
-from typing import List, final
+from typing import List
class AbstractBoard(System):
@@ -236,7 +236,6 @@
"""
raise NotImplementedError
-@final
def _connect_things(self) -> None:
"""Connects all the components to the board.
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/55863
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I65a5f4b5655d2ad80f7b566f9cea8e2371b3be62
Gerrit-Change-Number: 55863
Gerrit-PatchSet: 2
Gerrit-Owner: Hoa Nguyen
Gerrit-Reviewer: Bobby Bruce
Gerrit-Reviewer: Hoa Nguyen
Gerrit-Reviewer: Jason Lowe-Power
Gerrit-Reviewer: kokoro
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
