Yu-hsin Wang has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/32735 )
Change subject: systemc: Send response to TLM side if a packet does not
need response
..
systemc: Send response to TLM side if a packet does not need response
A completed TLM transaction includes request and response parts.
Currently, if a gem5 packet does not need a reponse, the bridge would not
send BEGIN_RESP to its upstream. It causes stuck on TLM side.
To fix this problem, the bridge should send BEGIN_RESP by itself in this
case.
Change-Id: I318dec21bc3f291693715c0d70bc624addf05076
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32735
Reviewed-by: Gabe Black
Tested-by: kokoro
Maintainer: Gabe Black
---
M src/systemc/tlm_bridge/tlm_to_gem5.cc
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
Objections:
Matthias Jung: I would prefer this is not merged as is
diff --git a/src/systemc/tlm_bridge/tlm_to_gem5.cc
b/src/systemc/tlm_bridge/tlm_to_gem5.cc
index e6cb483..2bfbcc4 100644
--- a/src/systemc/tlm_bridge/tlm_to_gem5.cc
+++ b/src/systemc/tlm_bridge/tlm_to_gem5.cc
@@ -162,8 +162,15 @@
auto tlmSenderState = new TlmSenderState(trans);
pkt->pushSenderState(tlmSenderState);
+// If the packet doesn't need a response, we should send BEGIN_RESP by
+// ourselves.
+bool needsResponse = pkt->needsResponse();
if (bmp.sendTimingReq(pkt)) { // port is free -> send END_REQ
immediately
sendEndReq(trans);
+if (!needsResponse) {
+auto delay = sc_core::SC_ZERO_TIME;
+sendBeginResp(trans, delay);
+}
trans.release();
} else { // port is blocked -> wait for retry before sending END_REQ
waitForRetry = true;
@@ -429,12 +436,19 @@
sc_assert(pendingRequest != nullptr);
sc_assert(pendingPacket != nullptr);
+// If the packet doesn't need a response, we should send BEGIN_RESP by
+// ourselves.
+bool needsResponse = pendingPacket->needsResponse();
if (bmp.sendTimingReq(pendingPacket)) {
waitForRetry = false;
pendingPacket = nullptr;
auto &trans = *pendingRequest;
sendEndReq(trans);
+if (!needsResponse) {
+auto delay = sc_core::SC_ZERO_TIME;
+sendBeginResp(trans, delay);
+}
trans.release();
pendingRequest = nullptr;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32735
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I318dec21bc3f291693715c0d70bc624addf05076
Gerrit-Change-Number: 32735
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-hsin Wang
Gerrit-Reviewer: Christian Menard
Gerrit-Reviewer: Earl Ou
Gerrit-Reviewer: Gabe Black
Gerrit-Reviewer: Matthias Jung
Gerrit-Reviewer: Yu-hsin Wang
Gerrit-Reviewer: kokoro
Gerrit-CC: Jui-min Lee
Gerrit-MessageType: merged
___
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
