subject:"\[gem5\-dev\] Change in gem5\/gem5\[master\]\: base\: Remove tests making use of Big\/LittleEndianOrder Namespace"

[gem5-dev] Change in gem5/gem5[master]: base: Remove tests making use of Big/LittleEndianOrder Namespace

2019-11-21 Thread Giacomo Travaglini (Gerrit)

Giacomo Travaglini has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/22943 )


Change subject: base: Remove tests making use of Big/LittleEndianOrder  
Namespace

..

base: Remove tests making use of Big/LittleEndianOrder Namespace

Unit tests are currently broken.
commit d40f0bc579fb8b10da7181d3a144cd3e9a0a0e59 is removing the
BigEndianOrder and LittleEndianOrder namespace.
Therefore we shouldn't test them and their helpers.

Change-Id: I68a45f264b782334d0a0f725c2c435c27337e757
Signed-off-by: Giacomo Travaglini 
Reviewed-by: Nikos Nikoleris 
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/22943
Reviewed-by: Bobby R. Bruce 
Reviewed-by: Gabe Black 
Maintainer: Bobby R. Bruce 
Tested-by: kokoro 
---
M src/sim/byteswap.test.cc
1 file changed, 0 insertions(+), 452 deletions(-)

Approvals:
  Gabe Black: Looks good to me, approved
  Bobby R. Bruce: Looks good to me, approved; Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/sim/byteswap.test.cc b/src/sim/byteswap.test.cc
index ef41437..8ebc584 100644
--- a/src/sim/byteswap.test.cc
+++ b/src/sim/byteswap.test.cc
@@ -337,455 +337,3 @@
 EXPECT_EQ(0x, letobe((uint16_t)0x));
 EXPECT_EQ(0xa0a0, letobe((uint16_t)0xa0a0));
 }
-
-TEST(ByteswapTest, beg_gtole)
-{
-EXPECT_EQ(0x0123456789abcdef,
-BigEndianGuest::gtole((uint64_t)0xefcdab8967452301));
-EXPECT_EQ(0xfedcba9876543210,
-BigEndianGuest::gtole((uint64_t)0x1032547698badcfe));
-EXPECT_EQ(0x0b1cb071b77141b1,
-BigEndianGuest::gtole((uint64_t)0xb14171b771b01c0b));
-EXPECT_EQ(0x,
-BigEndianGuest::gtole((uint64_t)0x));
-EXPECT_EQ(0x,
-BigEndianGuest::gtole((uint64_t)0x));
-EXPECT_EQ(0xa0a0a0a0a0a0a0a0,
-BigEndianGuest::gtole((uint64_t)0xa0a0a0a0a0a0a0a0));
-EXPECT_EQ(0x0123cdef, BigEndianGuest::gtole((uint32_t)0xefcd2301));
-EXPECT_EQ(0xfedc3210, BigEndianGuest::gtole((uint32_t)0x1032dcfe));
-EXPECT_EQ(0x0b1c41b1, BigEndianGuest::gtole((uint32_t)0xb1411c0b));
-EXPECT_EQ(0x, BigEndianGuest::gtole((uint32_t)0x));
-EXPECT_EQ(0x, BigEndianGuest::gtole((uint32_t)0x));
-EXPECT_EQ(0xa0a0a0a0, BigEndianGuest::gtole((uint32_t)0xa0a0a0a0));
-EXPECT_EQ(0x01ef, BigEndianGuest::gtole((uint16_t)0xef01));
-EXPECT_EQ(0xfe10, BigEndianGuest::gtole((uint16_t)0x10fe));
-EXPECT_EQ(0x0bb1, BigEndianGuest::gtole((uint16_t)0xb10b));
-EXPECT_EQ(0x00ff, BigEndianGuest::gtole((uint16_t)0xff00));
-EXPECT_EQ(0x, BigEndianGuest::gtole((uint16_t)0x));
-EXPECT_EQ(0xa0a0, BigEndianGuest::gtole((uint16_t)0xa0a0));
-}
-
-TEST(ByteswapTest, beg_letog)
-{
-EXPECT_EQ(0x0123456789abcdef,
-BigEndianGuest::letog((uint64_t)0xefcdab8967452301));
-EXPECT_EQ(0xfedcba9876543210,
-BigEndianGuest::letog((uint64_t)0x1032547698badcfe));
-EXPECT_EQ(0x0b1cb071b77141b1,
-BigEndianGuest::letog((uint64_t)0xb14171b771b01c0b));
-EXPECT_EQ(0x,
-BigEndianGuest::letog((uint64_t)0x));
-EXPECT_EQ(0x,
-BigEndianGuest::letog((uint64_t)0x));
-EXPECT_EQ(0xa0a0a0a0a0a0a0a0,
-BigEndianGuest::letog((uint64_t)0xa0a0a0a0a0a0a0a0));
-EXPECT_EQ(0x0123cdef, BigEndianGuest::letog((uint32_t)0xefcd2301));
-EXPECT_EQ(0xfedc3210, BigEndianGuest::letog((uint32_t)0x1032dcfe));
-EXPECT_EQ(0x0b1c41b1, BigEndianGuest::letog((uint32_t)0xb1411c0b));
-EXPECT_EQ(0x, BigEndianGuest::letog((uint32_t)0x));
-EXPECT_EQ(0x, BigEndianGuest::letog((uint32_t)0x));
-EXPECT_EQ(0xa0a0a0a0, BigEndianGuest::letog((uint32_t)0xa0a0a0a0));
-EXPECT_EQ(0x01ef, BigEndianGuest::letog((uint16_t)0xef01));
-EXPECT_EQ(0xfe10, BigEndianGuest::letog((uint16_t)0x10fe));
-EXPECT_EQ(0x0bb1, BigEndianGuest::letog((uint16_t)0xb10b));
-EXPECT_EQ(0x00ff, BigEndianGuest::letog((uint16_t)0xff00));
-EXPECT_EQ(0x, BigEndianGuest::letog((uint16_t)0x));
-EXPECT_EQ(0xa0a0, BigEndianGuest::letog((uint16_t)0xa0a0));
-}
-
-TEST(ByteswapTest, beg_gtobe)
-{
-EXPECT_EQ(0xefcdab8967452301,
-BigEndianGuest::gtobe((uint64_t)0xefcdab8967452301));
-EXPECT_EQ(0x1032547698badcfe,
-BigEndianGuest::gtobe((uint64_t)0x1032547698badcfe));
-EXPECT_EQ(0xb14171b771b01c0b,
-BigEndianGuest::gtobe((uint64_t)0xb14171b771b01c0b));
-EXPECT_EQ(0x,
-BigEndianGuest::gtobe((uint64_t)0x));
-EXPECT_EQ(0x,
-BigEndianGuest::gtobe((uint64_t)0x));
-EXPECT_EQ(0xa0a0a0a0a0a0a0a0,
-BigEndianGuest::gtobe((uint64_t)0xa0a0a0a0a0a0a0a0));
-EXPECT_EQ(0xefcd2301, BigEndianGuest::gtobe((uint32_t)0xefcd2301));
-EXPECT_EQ(0x1032dcfe, BigEndianGuest::gtobe(

[gem5-dev] Change in gem5/gem5[master]: base: Remove tests making use of Big/LittleEndianOrder Namespace

2019-11-20 Thread Giacomo Travaglini (Gerrit)


Hello Nikos Nikoleris,

I'd like you to do a code review. Please visit

https://gem5-review.googlesource.com/c/public/gem5/+/22943

to review the following change.


Change subject: base: Remove tests making use of Big/LittleEndianOrder  
Namespace

..

base: Remove tests making use of Big/LittleEndianOrder Namespace

Unit tests are currently broken.
commit d40f0bc579fb8b10da7181d3a144cd3e9a0a0e59 is removing the
BigEndianOrder and LittleEndianOrder namespace.
Therefore we shouldn't test them and their helpers.

Change-Id: I68a45f264b782334d0a0f725c2c435c27337e757
Signed-off-by: Giacomo Travaglini 
Reviewed-by: Nikos Nikoleris 
---
M src/sim/byteswap.test.cc
1 file changed, 0 insertions(+), 452 deletions(-)



diff --git a/src/sim/byteswap.test.cc b/src/sim/byteswap.test.cc
index ef41437..8ebc584 100644
--- a/src/sim/byteswap.test.cc
+++ b/src/sim/byteswap.test.cc
@@ -337,455 +337,3 @@
 EXPECT_EQ(0x, letobe((uint16_t)0x));
 EXPECT_EQ(0xa0a0, letobe((uint16_t)0xa0a0));
 }
-
-TEST(ByteswapTest, beg_gtole)
-{
-EXPECT_EQ(0x0123456789abcdef,
-BigEndianGuest::gtole((uint64_t)0xefcdab8967452301));
-EXPECT_EQ(0xfedcba9876543210,
-BigEndianGuest::gtole((uint64_t)0x1032547698badcfe));
-EXPECT_EQ(0x0b1cb071b77141b1,
-BigEndianGuest::gtole((uint64_t)0xb14171b771b01c0b));
-EXPECT_EQ(0x,
-BigEndianGuest::gtole((uint64_t)0x));
-EXPECT_EQ(0x,
-BigEndianGuest::gtole((uint64_t)0x));
-EXPECT_EQ(0xa0a0a0a0a0a0a0a0,
-BigEndianGuest::gtole((uint64_t)0xa0a0a0a0a0a0a0a0));
-EXPECT_EQ(0x0123cdef, BigEndianGuest::gtole((uint32_t)0xefcd2301));
-EXPECT_EQ(0xfedc3210, BigEndianGuest::gtole((uint32_t)0x1032dcfe));
-EXPECT_EQ(0x0b1c41b1, BigEndianGuest::gtole((uint32_t)0xb1411c0b));
-EXPECT_EQ(0x, BigEndianGuest::gtole((uint32_t)0x));
-EXPECT_EQ(0x, BigEndianGuest::gtole((uint32_t)0x));
-EXPECT_EQ(0xa0a0a0a0, BigEndianGuest::gtole((uint32_t)0xa0a0a0a0));
-EXPECT_EQ(0x01ef, BigEndianGuest::gtole((uint16_t)0xef01));
-EXPECT_EQ(0xfe10, BigEndianGuest::gtole((uint16_t)0x10fe));
-EXPECT_EQ(0x0bb1, BigEndianGuest::gtole((uint16_t)0xb10b));
-EXPECT_EQ(0x00ff, BigEndianGuest::gtole((uint16_t)0xff00));
-EXPECT_EQ(0x, BigEndianGuest::gtole((uint16_t)0x));
-EXPECT_EQ(0xa0a0, BigEndianGuest::gtole((uint16_t)0xa0a0));
-}
-
-TEST(ByteswapTest, beg_letog)
-{
-EXPECT_EQ(0x0123456789abcdef,
-BigEndianGuest::letog((uint64_t)0xefcdab8967452301));
-EXPECT_EQ(0xfedcba9876543210,
-BigEndianGuest::letog((uint64_t)0x1032547698badcfe));
-EXPECT_EQ(0x0b1cb071b77141b1,
-BigEndianGuest::letog((uint64_t)0xb14171b771b01c0b));
-EXPECT_EQ(0x,
-BigEndianGuest::letog((uint64_t)0x));
-EXPECT_EQ(0x,
-BigEndianGuest::letog((uint64_t)0x));
-EXPECT_EQ(0xa0a0a0a0a0a0a0a0,
-BigEndianGuest::letog((uint64_t)0xa0a0a0a0a0a0a0a0));
-EXPECT_EQ(0x0123cdef, BigEndianGuest::letog((uint32_t)0xefcd2301));
-EXPECT_EQ(0xfedc3210, BigEndianGuest::letog((uint32_t)0x1032dcfe));
-EXPECT_EQ(0x0b1c41b1, BigEndianGuest::letog((uint32_t)0xb1411c0b));
-EXPECT_EQ(0x, BigEndianGuest::letog((uint32_t)0x));
-EXPECT_EQ(0x, BigEndianGuest::letog((uint32_t)0x));
-EXPECT_EQ(0xa0a0a0a0, BigEndianGuest::letog((uint32_t)0xa0a0a0a0));
-EXPECT_EQ(0x01ef, BigEndianGuest::letog((uint16_t)0xef01));
-EXPECT_EQ(0xfe10, BigEndianGuest::letog((uint16_t)0x10fe));
-EXPECT_EQ(0x0bb1, BigEndianGuest::letog((uint16_t)0xb10b));
-EXPECT_EQ(0x00ff, BigEndianGuest::letog((uint16_t)0xff00));
-EXPECT_EQ(0x, BigEndianGuest::letog((uint16_t)0x));
-EXPECT_EQ(0xa0a0, BigEndianGuest::letog((uint16_t)0xa0a0));
-}
-
-TEST(ByteswapTest, beg_gtobe)
-{
-EXPECT_EQ(0xefcdab8967452301,
-BigEndianGuest::gtobe((uint64_t)0xefcdab8967452301));
-EXPECT_EQ(0x1032547698badcfe,
-BigEndianGuest::gtobe((uint64_t)0x1032547698badcfe));
-EXPECT_EQ(0xb14171b771b01c0b,
-BigEndianGuest::gtobe((uint64_t)0xb14171b771b01c0b));
-EXPECT_EQ(0x,
-BigEndianGuest::gtobe((uint64_t)0x));
-EXPECT_EQ(0x,
-BigEndianGuest::gtobe((uint64_t)0x));
-EXPECT_EQ(0xa0a0a0a0a0a0a0a0,
-BigEndianGuest::gtobe((uint64_t)0xa0a0a0a0a0a0a0a0));
-EXPECT_EQ(0xefcd2301, BigEndianGuest::gtobe((uint32_t)0xefcd2301));
-EXPECT_EQ(0x1032dcfe, BigEndianGuest::gtobe((uint32_t)0x1032dcfe));
-EXPECT_EQ(0xb1411c0b, BigEndianGuest::gtobe((uint32_t)0xb1411c0b));
-EXPECT_EQ(0x, BigEndianGuest::gtobe((uint32_t)0x));
-EXPECT_EQ(0x, BigEndianGuest::gtobe((uint32_t)0x));
-EXPECT_EQ(0xa0a0a0a0

[gem5-dev] Change in gem5/gem5[master]: base: Remove tests making use of Big/LittleEndianOrder Namespace

[gem5-dev] Change in gem5/gem5[master]: base: Remove tests making use of Big/LittleEndianOrder Namespace

2 matches

Site Navigation

Mail list logo

Footer information