[gem5-dev] Change in gem5/gem5[master]: dev-virtio: don't set the 9p default root

2019-12-13 Thread Ciro Santilli (Gerrit)
Ciro Santilli has submitted this change. (  
https://gem5-review.googlesource.com/c/public/gem5/+/22828 )


Change subject: dev-virtio: don't set the 9p default root
..

dev-virtio: don't set the 9p default root

It is better to force users to explicitly set this argument, since
it is unlikely that we will find one safe option for all users.

Change-Id: I612520a44efd205a029a40cd13402584d16e1d88
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/22828
Tested-by: kokoro 
Reviewed-by: Bobby R. Bruce 
Reviewed-by: Jason Lowe-Power 
Maintainer: Jason Lowe-Power 
---
M src/dev/virtio/VirtIO9P.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
  Bobby R. Bruce: Looks good to me, approved
  kokoro: Regressions pass



diff --git a/src/dev/virtio/VirtIO9P.py b/src/dev/virtio/VirtIO9P.py
index 55008ae..7c5e132 100644
--- a/src/dev/virtio/VirtIO9P.py
+++ b/src/dev/virtio/VirtIO9P.py
@@ -60,7 +60,7 @@
 cxx_header = 'dev/virtio/fs9p.hh'

 diod = Param.String("diod", "Path to diod, optionally in PATH")
-root = Param.String("/tmp", "Path to export through diod")
+root = Param.String("Path to export through diod")
 socketPath = Param.String("Unused socket to diod")

 class VirtIO9PSocket(VirtIO9PProxy):

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/22828
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I612520a44efd205a029a40cd13402584d16e1d88
Gerrit-Change-Number: 22828
Gerrit-PatchSet: 6
Gerrit-Owner: Ciro Santilli 
Gerrit-Reviewer: Bobby R. Bruce 
Gerrit-Reviewer: Ciro Santilli 
Gerrit-Reviewer: Jason Lowe-Power 
Gerrit-Reviewer: kokoro 
Gerrit-CC: Giacomo Travaglini 
Gerrit-MessageType: merged
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Change in gem5/gem5[master]: dev-virtio: don't set the 9p default root

2019-11-14 Thread Ciro Santilli (Gerrit)
Ciro Santilli has uploaded this change for review. (  
https://gem5-review.googlesource.com/c/public/gem5/+/22828 )



Change subject: dev-virtio: don't set the 9p default root
..

dev-virtio: don't set the 9p default root

It is better to force users to explicitly set this argument, since
it is unlikely that we will find one safe option for all users.

Change-Id: I612520a44efd205a029a40cd13402584d16e1d88
---
M src/dev/virtio/VirtIO9P.py
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/src/dev/virtio/VirtIO9P.py b/src/dev/virtio/VirtIO9P.py
index 55008ae..7c5e132 100644
--- a/src/dev/virtio/VirtIO9P.py
+++ b/src/dev/virtio/VirtIO9P.py
@@ -60,7 +60,7 @@
 cxx_header = 'dev/virtio/fs9p.hh'

 diod = Param.String("diod", "Path to diod, optionally in PATH")
-root = Param.String("/tmp", "Path to export through diod")
+root = Param.String("Path to export through diod")
 socketPath = Param.String("Unused socket to diod")

 class VirtIO9PSocket(VirtIO9PProxy):

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/22828
To unsubscribe, or for help writing mail filters, visit  
https://gem5-review.googlesource.com/settings


Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I612520a44efd205a029a40cd13402584d16e1d88
Gerrit-Change-Number: 22828
Gerrit-PatchSet: 1
Gerrit-Owner: Ciro Santilli 
Gerrit-MessageType: newchange
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev