[gem5-dev] Review Request 2500: mem: Relax packet src/dest check and shift onus to crossbar
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2500/ --- Review request for Default. Repository: gem5 Description --- Changeset 10550:7636a5c1b905 --- mem: Relax packet src/dest check and shift onus to crossbar This patch allows objects to get the src/dest of a packet even if it is not set to a valid port id. This simplifies (ab)using the bridge as a buffer and latency adapter in situations where the neighbouring MemObjects are not crossbars. The checks that were done in the packet are now shifted to the crossbar where the fields are used to index into the port arrays. Thus, the carrier of the information is not burdened with checking, and the crossbar can check not only that the destination is set, but also that the port index is within limits. Diffs - src/mem/bridge.cc 1a9e235cab09 src/mem/cache/cache_impl.hh 1a9e235cab09 src/mem/coherent_xbar.cc 1a9e235cab09 src/mem/noncoherent_xbar.cc 1a9e235cab09 src/mem/packet.hh 1a9e235cab09 Diff: http://reviews.gem5.org/r/2500/diff/ Testing --- Thanks, Andreas Hansson ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2500: mem: Relax packet src/dest check and shift onus to crossbar
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2500/#review5508 --- Ship it! Ship It! - Nilay Vaish On Nov. 17, 2014, 6:17 a.m., Andreas Hansson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2500/ > --- > > (Updated Nov. 17, 2014, 6:17 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 10550:7636a5c1b905 > --- > mem: Relax packet src/dest check and shift onus to crossbar > > This patch allows objects to get the src/dest of a packet even if it > is not set to a valid port id. This simplifies (ab)using the bridge as > a buffer and latency adapter in situations where the neighbouring > MemObjects are not crossbars. > > The checks that were done in the packet are now shifted to the > crossbar where the fields are used to index into the port > arrays. Thus, the carrier of the information is not burdened with > checking, and the crossbar can check not only that the destination is > set, but also that the port index is within limits. > > > Diffs > - > > src/mem/bridge.cc 1a9e235cab09 > src/mem/cache/cache_impl.hh 1a9e235cab09 > src/mem/coherent_xbar.cc 1a9e235cab09 > src/mem/noncoherent_xbar.cc 1a9e235cab09 > src/mem/packet.hh 1a9e235cab09 > > Diff: http://reviews.gem5.org/r/2500/diff/ > > > Testing > --- > > > Thanks, > > Andreas Hansson > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2500: mem: Relax packet src/dest check and shift onus to crossbar
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2500/#review5579 --- Ship it! Ship It! - Steve Reinhardt On Nov. 16, 2014, 10:17 p.m., Andreas Hansson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2500/ > --- > > (Updated Nov. 16, 2014, 10:17 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 10550:7636a5c1b905 > --- > mem: Relax packet src/dest check and shift onus to crossbar > > This patch allows objects to get the src/dest of a packet even if it > is not set to a valid port id. This simplifies (ab)using the bridge as > a buffer and latency adapter in situations where the neighbouring > MemObjects are not crossbars. > > The checks that were done in the packet are now shifted to the > crossbar where the fields are used to index into the port > arrays. Thus, the carrier of the information is not burdened with > checking, and the crossbar can check not only that the destination is > set, but also that the port index is within limits. > > > Diffs > - > > src/mem/bridge.cc 1a9e235cab09 > src/mem/cache/cache_impl.hh 1a9e235cab09 > src/mem/coherent_xbar.cc 1a9e235cab09 > src/mem/noncoherent_xbar.cc 1a9e235cab09 > src/mem/packet.hh 1a9e235cab09 > > Diff: http://reviews.gem5.org/r/2500/diff/ > > > Testing > --- > > > Thanks, > > Andreas Hansson > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
