Re: [gem5-dev] Review Request 2503: config: SystemC Gem5Control top level additions

2014-11-28 Thread Andreas Hansson via gem5-dev 
Hi Nilay,

I welcome anyone to invest the effort.

Andreas

On 11/28/14, 3:05 PM, "Nilay Vaish"  wrote:

>On Tue, 25 Nov 2014, Andreas Hansson wrote:
>
>>
>>
>>> On Nov. 25, 2014, 9:52 p.m., Nilay Vaish wrote:
 I don't know what are we trying to achieve by interfacing gem5 and
SystemC.  But the patch seems fine to me.
>>
>> I would think roughly 90% of all the SoC model components in the world
>> are written using SystemC as it is the de facto modeling framework (and
>> an IEEE standard). Thus, interfacing gem5 with SystemC opens up for a
>> wide variety of use cases that were not possible before. Makes sense?
>
>If 90% of all SoC development is done using SystemC, why would you not
>want to write the entire simulator using SystemC?
>
>--
>Nilay
>


-- IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium.  Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered 
in England & Wales, Company No:  2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, 
Registered in England & Wales, Company No:  2548782

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 2503: config: SystemC Gem5Control top level additions

2014-11-28 Thread Nilay Vaish via gem5-dev 

On Tue, 25 Nov 2014, Andreas Hansson wrote:





On Nov. 25, 2014, 9:52 p.m., Nilay Vaish wrote:

I don't know what are we trying to achieve by interfacing gem5 and SystemC.  
But the patch seems fine to me.


I would think roughly 90% of all the SoC model components in the world 
are written using SystemC as it is the de facto modeling framework (and 
an IEEE standard). Thus, interfacing gem5 with SystemC opens up for a 
wide variety of use cases that were not possible before. Makes sense?


If 90% of all SoC development is done using SystemC, why would you not 
want to write the entire simulator using SystemC?


--
Nilay
___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 2503: config: SystemC Gem5Control top level additions

2014-11-25 Thread Andreas Hansson via gem5-dev 


> On Nov. 25, 2014, 9:52 p.m., Nilay Vaish wrote:
> > I don't know what are we trying to achieve by interfacing gem5 and SystemC. 
> >  But the patch seems fine to me.

I would think roughly 90% of all the SoC model components in the world are 
written using SystemC as it is the de facto modeling framework (and an IEEE 
standard). Thus, interfacing gem5 with SystemC opens up for a wide variety of 
use cases that were not possible before. Makes sense?


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2503/#review5538
---


On Nov. 17, 2014, 6:18 a.m., Andreas Hansson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2503/
> ---
> 
> (Updated Nov. 17, 2014, 6:18 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 10554:f6e35a3dcc8f
> ---
> config: SystemC Gem5Control top level additions
> 
> This patch cleans up a few style issues and adds a few capabilities to the
> SystemC top level 'Gem5Control/Gem5System' mechanism.  These include:
> 
> 1) A space to store/retrieve a version string for a model
> 2) A mechanism for registering functions to be called at the end of
> elaboration to perform simulation setup tasks in SystemC
> 3) Adding setGDBRemotePort to the Gem5Control
> 4) Changing the sc_set_time_resolution behaviour to instead check that
> the SystemC time resolution is already acceptable
> 
> 
> Diffs
> -
> 
>   util/systemc/sc_gem5_control.hh 1a9e235cab09 
>   util/systemc/sc_gem5_control.cc 1a9e235cab09 
> 
> Diff: http://reviews.gem5.org/r/2503/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 2503: config: SystemC Gem5Control top level additions

2014-11-25 Thread Nilay Vaish via gem5-dev 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2503/#review5538
---

Ship it!


I don't know what are we trying to achieve by interfacing gem5 and SystemC.  
But the patch seems fine to me.


util/systemc/sc_gem5_control.hh


What is this version for?



util/systemc/sc_gem5_control.hh


Can you elaborate on what an elaboration is?  I am guessing it to be a 
SystemC term.



util/systemc/sc_gem5_control.cc


I am not against this indentation, but I think the norm is to align the 
arguments vertically.  


 

- Nilay Vaish


On Nov. 17, 2014, 6:18 a.m., Andreas Hansson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2503/
> ---
> 
> (Updated Nov. 17, 2014, 6:18 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 10554:f6e35a3dcc8f
> ---
> config: SystemC Gem5Control top level additions
> 
> This patch cleans up a few style issues and adds a few capabilities to the
> SystemC top level 'Gem5Control/Gem5System' mechanism.  These include:
> 
> 1) A space to store/retrieve a version string for a model
> 2) A mechanism for registering functions to be called at the end of
> elaboration to perform simulation setup tasks in SystemC
> 3) Adding setGDBRemotePort to the Gem5Control
> 4) Changing the sc_set_time_resolution behaviour to instead check that
> the SystemC time resolution is already acceptable
> 
> 
> Diffs
> -
> 
>   util/systemc/sc_gem5_control.hh 1a9e235cab09 
>   util/systemc/sc_gem5_control.cc 1a9e235cab09 
> 
> Diff: http://reviews.gem5.org/r/2503/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Andreas Hansson
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 2503: config: SystemC Gem5Control top level additions

2014-11-16 Thread Andreas Hansson via gem5-dev 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2503/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 10554:f6e35a3dcc8f
---
config: SystemC Gem5Control top level additions

This patch cleans up a few style issues and adds a few capabilities to the
SystemC top level 'Gem5Control/Gem5System' mechanism.  These include:

1) A space to store/retrieve a version string for a model
2) A mechanism for registering functions to be called at the end of
elaboration to perform simulation setup tasks in SystemC
3) Adding setGDBRemotePort to the Gem5Control
4) Changing the sc_set_time_resolution behaviour to instead check that
the SystemC time resolution is already acceptable


Diffs
-

  util/systemc/sc_gem5_control.hh 1a9e235cab09 
  util/systemc/sc_gem5_control.cc 1a9e235cab09 

Diff: http://reviews.gem5.org/r/2503/diff/


Testing
---


Thanks,

Andreas Hansson

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev