[gem5-dev] Review Request 2520: x86: i8042: Add VNC keyboard input support.

2014-11-22 Thread Gabe Black via gem5-dev 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2520/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 10556:76e90695e93b
---
x86: i8042: Add VNC keyboard input support.

This fixes up and fleshes out the keyboard model within the i8042 so that it
can return keyboard input realistically enough to satisfy the kernel.

One notable change was to turn off the convertScanCodes bit. That bit
basically enables a compatibility mode which makes the keyboard return
scancodes from set 1 which the XT computer used. We want to turn off that
translation so that we get scancode set 2, the standard set which was used by
the AT computer. That's also what the existing X11 keycode => scancode
function developed for ARM returns.


Diffs
-

  src/dev/x86/i8042.hh 6317351a288c0349c5855c7431bc1eeade61605c 
  src/dev/x86/i8042.cc 6317351a288c0349c5855c7431bc1eeade61605c 

Diff: http://reviews.gem5.org/r/2520/diff/


Testing
---


Thanks,

Gabe Black

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 2520: x86: i8042: Add VNC keyboard input support.

2014-11-25 Thread Nilay Vaish via gem5-dev 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2520/#review5545
---

Ship it!


Seems fine.

- Nilay Vaish


On Nov. 22, 2014, 1:32 p.m., Gabe Black wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2520/
> ---
> 
> (Updated Nov. 22, 2014, 1:32 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 10556:76e90695e93b
> ---
> x86: i8042: Add VNC keyboard input support.
> 
> This fixes up and fleshes out the keyboard model within the i8042 so that it
> can return keyboard input realistically enough to satisfy the kernel.
> 
> One notable change was to turn off the convertScanCodes bit. That bit
> basically enables a compatibility mode which makes the keyboard return
> scancodes from set 1 which the XT computer used. We want to turn off that
> translation so that we get scancode set 2, the standard set which was used by
> the AT computer. That's also what the existing X11 keycode => scancode
> function developed for ARM returns.
> 
> 
> Diffs
> -
> 
>   src/dev/x86/i8042.hh 6317351a288c0349c5855c7431bc1eeade61605c 
>   src/dev/x86/i8042.cc 6317351a288c0349c5855c7431bc1eeade61605c 
> 
> Diff: http://reviews.gem5.org/r/2520/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabe Black
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 2520: x86: i8042: Add VNC keyboard input support.

2014-11-26 Thread Andreas Hansson via gem5-dev 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2520/#review5554
---



src/dev/x86/i8042.cc


for (auto& k : keys)
   bufferData(&k, 1)


I would suggest "x86, dev" as the keyword(s)

- Andreas Hansson


On Nov. 22, 2014, 1:32 p.m., Gabe Black wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2520/
> ---
> 
> (Updated Nov. 22, 2014, 1:32 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 10556:76e90695e93b
> ---
> x86: i8042: Add VNC keyboard input support.
> 
> This fixes up and fleshes out the keyboard model within the i8042 so that it
> can return keyboard input realistically enough to satisfy the kernel.
> 
> One notable change was to turn off the convertScanCodes bit. That bit
> basically enables a compatibility mode which makes the keyboard return
> scancodes from set 1 which the XT computer used. We want to turn off that
> translation so that we get scancode set 2, the standard set which was used by
> the AT computer. That's also what the existing X11 keycode => scancode
> function developed for ARM returns.
> 
> 
> Diffs
> -
> 
>   src/dev/x86/i8042.hh 6317351a288c0349c5855c7431bc1eeade61605c 
>   src/dev/x86/i8042.cc 6317351a288c0349c5855c7431bc1eeade61605c 
> 
> Diff: http://reviews.gem5.org/r/2520/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabe Black
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 2520: x86: i8042: Add VNC keyboard input support.

2014-11-26 Thread Gabe Black via gem5-dev 


> On Nov. 26, 2014, 10:49 a.m., Andreas Hansson wrote:
> > src/dev/x86/i8042.cc, line 261
> > 
> >
> > for (auto& k : keys)
> >bufferData(&k, 1)

What is this sorcery? :-) Seriously though, what's this from? Does gcc 0.1 or 
whatever minimum version we support handle that?


- Gabe


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2520/#review5554
---


On Nov. 22, 2014, 1:32 p.m., Gabe Black wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2520/
> ---
> 
> (Updated Nov. 22, 2014, 1:32 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 10556:76e90695e93b
> ---
> x86: i8042: Add VNC keyboard input support.
> 
> This fixes up and fleshes out the keyboard model within the i8042 so that it
> can return keyboard input realistically enough to satisfy the kernel.
> 
> One notable change was to turn off the convertScanCodes bit. That bit
> basically enables a compatibility mode which makes the keyboard return
> scancodes from set 1 which the XT computer used. We want to turn off that
> translation so that we get scancode set 2, the standard set which was used by
> the AT computer. That's also what the existing X11 keycode => scancode
> function developed for ARM returns.
> 
> 
> Diffs
> -
> 
>   src/dev/x86/i8042.hh 6317351a288c0349c5855c7431bc1eeade61605c 
>   src/dev/x86/i8042.cc 6317351a288c0349c5855c7431bc1eeade61605c 
> 
> Diff: http://reviews.gem5.org/r/2520/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabe Black
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 2520: x86: i8042: Add VNC keyboard input support.

2014-11-26 Thread Andreas Hansson via gem5-dev 


> On Nov. 26, 2014, 10:49 a.m., Andreas Hansson wrote:
> > src/dev/x86/i8042.cc, line 261
> > 
> >
> > for (auto& k : keys)
> >bufferData(&k, 1)
> 
> Gabe Black wrote:
> What is this sorcery? :-) Seriously though, what's this from? Does gcc 
> 0.1 or whatever minimum version we support handle that?

c++ 11

And yes, gcc 4.6 supports range-based for loops.

Welcome to the future...if you are so inclined :-)


- Andreas


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2520/#review5554
---


On Nov. 22, 2014, 1:32 p.m., Gabe Black wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2520/
> ---
> 
> (Updated Nov. 22, 2014, 1:32 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 10556:76e90695e93b
> ---
> x86: i8042: Add VNC keyboard input support.
> 
> This fixes up and fleshes out the keyboard model within the i8042 so that it
> can return keyboard input realistically enough to satisfy the kernel.
> 
> One notable change was to turn off the convertScanCodes bit. That bit
> basically enables a compatibility mode which makes the keyboard return
> scancodes from set 1 which the XT computer used. We want to turn off that
> translation so that we get scancode set 2, the standard set which was used by
> the AT computer. That's also what the existing X11 keycode => scancode
> function developed for ARM returns.
> 
> 
> Diffs
> -
> 
>   src/dev/x86/i8042.hh 6317351a288c0349c5855c7431bc1eeade61605c 
>   src/dev/x86/i8042.cc 6317351a288c0349c5855c7431bc1eeade61605c 
> 
> Diff: http://reviews.gem5.org/r/2520/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gabe Black
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev