Re: [gem5-dev] Review Request 2528: config: make M5_PATH a real search path
> On Nov. 23, 2014, 7:49 p.m., Ali Saidi wrote: > > seems fine, but i've never been thrilled about the use of a builtin > > function file() as an identifier/parameter in this code good point. i'll do a rename in a separate patch. - Steve --- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2528/#review5531 --- On Nov. 23, 2014, 6:48 p.m., Steve Reinhardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2528/ > --- > > (Updated Nov. 23, 2014, 6:48 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 10559:ad009eb6579b > --- > config: make M5_PATH a real search path > > Although you can put a list of colon-separated directory names > in M5_PATH, the current code just takes the first one that > exists and assumes all files must live there. This change > makes the code search the specified list of directories > for each individual binary or disk image that's requested. > > The main motivation is that the x86/Alpha binaries and the > ARM binaries are in separate downloads, and thus naturally > end up in separate directories. With this change, you can > have M5_PATH point to those two directories, then run any > FS regression test without changing M5_PATH. Currently, > you either have to merge the two download directories > or change M5_PATH (or do something else I haven't figured out). > > > Diffs > - > > configs/common/SysPaths.py 426665ec11a925e983edbd94d4941615c5dd25fe > > Diff: http://reviews.gem5.org/r/2528/diff/ > > > Testing > --- > > > Thanks, > > Steve Reinhardt > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2528: config: make M5_PATH a real search path
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2528/#review5603 --- Ship it! Ship It! - Nilay Vaish On Nov. 24, 2014, 2:48 a.m., Steve Reinhardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2528/ > --- > > (Updated Nov. 24, 2014, 2:48 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 10559:ad009eb6579b > --- > config: make M5_PATH a real search path > > Although you can put a list of colon-separated directory names > in M5_PATH, the current code just takes the first one that > exists and assumes all files must live there. This change > makes the code search the specified list of directories > for each individual binary or disk image that's requested. > > The main motivation is that the x86/Alpha binaries and the > ARM binaries are in separate downloads, and thus naturally > end up in separate directories. With this change, you can > have M5_PATH point to those two directories, then run any > FS regression test without changing M5_PATH. Currently, > you either have to merge the two download directories > or change M5_PATH (or do something else I haven't figured out). > > > Diffs > - > > configs/common/SysPaths.py 426665ec11a925e983edbd94d4941615c5dd25fe > > Diff: http://reviews.gem5.org/r/2528/diff/ > > > Testing > --- > > > Thanks, > > Steve Reinhardt > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 2528: config: make M5_PATH a real search path
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2528/#review5531 --- seems fine, but i've never been thrilled about the use of a builtin function file() as an identifier/parameter in this code - Ali Saidi On Nov. 24, 2014, 2:48 a.m., Steve Reinhardt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2528/ > --- > > (Updated Nov. 24, 2014, 2:48 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 10559:ad009eb6579b > --- > config: make M5_PATH a real search path > > Although you can put a list of colon-separated directory names > in M5_PATH, the current code just takes the first one that > exists and assumes all files must live there. This change > makes the code search the specified list of directories > for each individual binary or disk image that's requested. > > The main motivation is that the x86/Alpha binaries and the > ARM binaries are in separate downloads, and thus naturally > end up in separate directories. With this change, you can > have M5_PATH point to those two directories, then run any > FS regression test without changing M5_PATH. Currently, > you either have to merge the two download directories > or change M5_PATH (or do something else I haven't figured out). > > > Diffs > - > > configs/common/SysPaths.py 426665ec11a925e983edbd94d4941615c5dd25fe > > Diff: http://reviews.gem5.org/r/2528/diff/ > > > Testing > --- > > > Thanks, > > Steve Reinhardt > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Review Request 2528: config: make M5_PATH a real search path
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2528/ --- Review request for Default. Repository: gem5 Description --- Changeset 10559:ad009eb6579b --- config: make M5_PATH a real search path Although you can put a list of colon-separated directory names in M5_PATH, the current code just takes the first one that exists and assumes all files must live there. This change makes the code search the specified list of directories for each individual binary or disk image that's requested. The main motivation is that the x86/Alpha binaries and the ARM binaries are in separate downloads, and thus naturally end up in separate directories. With this change, you can have M5_PATH point to those two directories, then run any FS regression test without changing M5_PATH. Currently, you either have to merge the two download directories or change M5_PATH (or do something else I haven't figured out). Diffs - configs/common/SysPaths.py 426665ec11a925e983edbd94d4941615c5dd25fe Diff: http://reviews.gem5.org/r/2528/diff/ Testing --- Thanks, Steve Reinhardt ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
