Re: [gem5-dev] Review Request 2674: cpu: o3: remove member variable squashCounter

[Andreas Hansson via gem5-dev]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2674/#review5919
---

Ship it!


Ship It!

- Andreas Hansson


On Feb. 28, 2015, 10:37 p.m., Nilay Vaish wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/2674/
> ---
> 
> (Updated Feb. 28, 2015, 10:37 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 10709:e490e8f78f64
> ---
> cpu: o3: remove member variable squashCounter
> The variable is used in only one place and a whole new function 
> setNextStatus()
> has been defined just to compute the value of the variable.  Instead of 
> calling
> the function, the value is now computed in the loop that preceded the function
> call.
> 
> 
> Diffs
> -
> 
>   src/cpu/o3/commit.hh 4206946d60fe 
>   src/cpu/o3/commit_impl.hh 4206946d60fe 
> 
> Diff: http://reviews.gem5.org/r/2674/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nilay Vaish
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 2674: cpu: o3: remove member variable squashCounter

[Nilay Vaish via gem5-dev]

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2674/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 10709:e490e8f78f64
---
cpu: o3: remove member variable squashCounter
The variable is used in only one place and a whole new function setNextStatus()
has been defined just to compute the value of the variable.  Instead of calling
the function, the value is now computed in the loop that preceded the function
call.


Diffs
-

  src/cpu/o3/commit.hh 4206946d60fe 
  src/cpu/o3/commit_impl.hh 4206946d60fe 

Diff: http://reviews.gem5.org/r/2674/diff/


Testing
---


Thanks,

Nilay Vaish

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev