Re: [gem5-dev] Review Request 3642: gpu-compute: move disassemle() implementation to GPUStaticInst

2016-10-04 Thread Jason Lowe-Power

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3642/#review8769
---

Ship it!


Ship It!

- Jason Lowe-Power


On Oct. 4, 2016, 5:48 p.m., Tony Gutierrez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3642/
> ---
> 
> (Updated Oct. 4, 2016, 5:48 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11661:d57db184b648
> ---
> gpu-compute: move disassemle() implementation to GPUStaticInst
> 
> move the implementation for generating GPU disassembly from the HSAIL
> static instruction class to the base GPU static instruction class. the
> implementation does not change across GPU ISAs.
> 
> 
> Diffs
> -
> 
>   src/arch/hsail/insts/gpu_static_inst.hh 
> b29aca3fcb75f5ad92429001ab11c65b2f9635b0 
>   src/arch/hsail/insts/gpu_static_inst.cc 
> b29aca3fcb75f5ad92429001ab11c65b2f9635b0 
>   src/gpu-compute/gpu_static_inst.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 
>   src/gpu-compute/gpu_static_inst.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 
> 
> Diff: http://reviews.gem5.org/r/3642/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tony Gutierrez
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


[gem5-dev] Review Request 3642: gpu-compute: move disassemle() implementation to GPUStaticInst

2016-10-04 Thread Tony Gutierrez

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3642/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11661:d57db184b648
---
gpu-compute: move disassemle() implementation to GPUStaticInst

move the implementation for generating GPU disassembly from the HSAIL
static instruction class to the base GPU static instruction class. the
implementation does not change across GPU ISAs.


Diffs
-

  src/arch/hsail/insts/gpu_static_inst.hh 
b29aca3fcb75f5ad92429001ab11c65b2f9635b0 
  src/arch/hsail/insts/gpu_static_inst.cc 
b29aca3fcb75f5ad92429001ab11c65b2f9635b0 
  src/gpu-compute/gpu_static_inst.hh b29aca3fcb75f5ad92429001ab11c65b2f9635b0 
  src/gpu-compute/gpu_static_inst.cc b29aca3fcb75f5ad92429001ab11c65b2f9635b0 

Diff: http://reviews.gem5.org/r/3642/diff/


Testing
---


Thanks,

Tony Gutierrez

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev