Re: [gem5-dev] Review Request 3695: misc: final cleanup of the TLM modules

2016-11-20 Thread Andreas Hansson 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3695/#review9126
---


Thanks for sorting all this out.

Could you extend the patch description as there is a lot going on in this 
patch, both in terms of refactoring and adding new functionality? In the future 
it would be good to split these changes, e.g. "use pkg-config for SystemC 
example", "make command line interface modular" etc.

- Andreas Hansson


On Nov. 10, 2016, 5:07 p.m., Christian Menard wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3695/
> ---
> 
> (Updated Nov. 10, 2016, 5:07 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11709:a64e6cc90f4e
> ---
> misc: final cleanup of the TLM modules
> 
> Introduce new transactor modules. These modules rerpresent the gem5 TLM ports
> in the SystemC world. Common code in the examples is moved to a common dir.
> 
> 
> Diffs
> -
> 
>   util/tlm/examples/common/cli_parser.hh PRE-CREATION 
>   util/tlm/examples/common/cli_parser.cc PRE-CREATION 
>   util/tlm/examples/common/report_handler.hh PRE-CREATION 
>   util/tlm/examples/common/report_handler.cc PRE-CREATION 
>   util/tlm/examples/master_port/SConstruct PRE-CREATION 
>   util/tlm/examples/master_port/main.cc PRE-CREATION 
>   util/tlm/examples/master_port/tlm.py PRE-CREATION 
>   util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION 
>   util/tlm/examples/slave_port/SConstruct PRE-CREATION 
>   util/tlm/examples/slave_port/main.cc PRE-CREATION 
>   util/tlm/examples/slave_port/sc_target.cc PRE-CREATION 
>   util/tlm/examples/slave_port/tlm.py PRE-CREATION 
>   util/tlm/gem5_master_transactor.hh PRE-CREATION 
>   util/tlm/gem5_master_transactor.cc PRE-CREATION 
>   util/tlm/gem5_slave_transactor.hh PRE-CREATION 
>   util/tlm/gem5_slave_transactor.cc PRE-CREATION 
>   util/tlm/sc_master_port.hh PRE-CREATION 
>   util/tlm/sc_master_port.cc PRE-CREATION 
>   util/tlm/sc_slave_port.hh PRE-CREATION 
>   util/tlm/sc_slave_port.cc PRE-CREATION 
>   util/tlm/sim_control.hh PRE-CREATION 
>   util/tlm/sim_control.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3695/diff/
> 
> 
> Testing
> ---
> 
> Examples compile and run.
> 
> 
> Thanks,
> 
> Christian Menard
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3695: misc: final cleanup of the TLM modules

2016-11-10 Thread Christian Menard 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3695/
---

(Updated Nov. 10, 2016, 5:07 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11709:a64e6cc90f4e
---
misc: final cleanup of the TLM modules

Introduce new transactor modules. These modules rerpresent the gem5 TLM ports
in the SystemC world. Common code in the examples is moved to a common dir.


Diffs (updated)
-

  util/tlm/examples/common/cli_parser.hh PRE-CREATION 
  util/tlm/examples/common/cli_parser.cc PRE-CREATION 
  util/tlm/examples/common/report_handler.hh PRE-CREATION 
  util/tlm/examples/common/report_handler.cc PRE-CREATION 
  util/tlm/examples/master_port/SConstruct PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/master_port/tlm.py PRE-CREATION 
  util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION 
  util/tlm/examples/slave_port/SConstruct PRE-CREATION 
  util/tlm/examples/slave_port/main.cc PRE-CREATION 
  util/tlm/examples/slave_port/sc_target.cc PRE-CREATION 
  util/tlm/examples/slave_port/tlm.py PRE-CREATION 
  util/tlm/gem5_master_transactor.hh PRE-CREATION 
  util/tlm/gem5_master_transactor.cc PRE-CREATION 
  util/tlm/gem5_slave_transactor.hh PRE-CREATION 
  util/tlm/gem5_slave_transactor.cc PRE-CREATION 
  util/tlm/sc_master_port.hh PRE-CREATION 
  util/tlm/sc_master_port.cc PRE-CREATION 
  util/tlm/sc_slave_port.hh PRE-CREATION 
  util/tlm/sc_slave_port.cc PRE-CREATION 
  util/tlm/sim_control.hh PRE-CREATION 
  util/tlm/sim_control.cc PRE-CREATION 

Diff: http://reviews.gem5.org/r/3695/diff/


Testing
---

Examples compile and run.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3695: misc: final cleanup of the TLM modules

2016-11-09 Thread Christian Menard 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3695/
---

(Updated Nov. 9, 2016, 1:06 p.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11709:97644a2264f0
---
misc: final cleanup of the TLM modules

Introduce new transactor modules. These modules rerpresent the gem5 TLM ports
in the SystemC world. Common code in the examples is moved to a common dir.


Diffs (updated)
-

  util/tlm/examples/common/report_handler.cc PRE-CREATION 
  util/tlm/examples/master_port/SConstruct PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/master_port/tlm.py PRE-CREATION 
  util/tlm/examples/common/cli_parser.hh PRE-CREATION 
  util/tlm/examples/common/cli_parser.cc PRE-CREATION 
  util/tlm/examples/common/report_handler.hh PRE-CREATION 
  util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION 
  util/tlm/examples/slave_port/SConstruct PRE-CREATION 
  util/tlm/examples/slave_port/main.cc PRE-CREATION 
  util/tlm/examples/slave_port/sc_target.cc PRE-CREATION 
  util/tlm/examples/slave_port/tlm.py PRE-CREATION 
  util/tlm/gem5_master_transactor.hh PRE-CREATION 
  util/tlm/gem5_master_transactor.cc PRE-CREATION 
  util/tlm/gem5_slave_transactor.hh PRE-CREATION 
  util/tlm/gem5_slave_transactor.cc PRE-CREATION 
  util/tlm/sc_master_port.hh PRE-CREATION 
  util/tlm/sc_master_port.cc PRE-CREATION 
  util/tlm/sc_slave_port.hh PRE-CREATION 
  util/tlm/sc_slave_port.cc PRE-CREATION 
  util/tlm/sim_control.hh PRE-CREATION 
  util/tlm/sim_control.cc PRE-CREATION 

Diff: http://reviews.gem5.org/r/3695/diff/


Testing
---

Examples compile and run.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3695: misc: final cleanup of the TLM modules

2016-11-09 Thread Christian Menard 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3695/
---

(Updated Nov. 9, 2016, 11:02 a.m.)


Review request for Default.


Repository: gem5


Description
---

Changeset 11709:252a9a8975d9
---
misc: final cleanup of the TLM modules

Introduce new transactor modules. These modules rerpresent the gem5 TLM ports
in the SystemC world. Common code in the examples is moved to a common dir.


Diffs
-

  util/tlm/examples/common/cli_parser.hh PRE-CREATION 
  util/tlm/examples/common/cli_parser.cc PRE-CREATION 
  util/tlm/examples/common/report_handler.hh PRE-CREATION 
  util/tlm/examples/common/report_handler.cc PRE-CREATION 
  util/tlm/examples/master_port/SConstruct PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/master_port/tlm.py PRE-CREATION 
  util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION 
  util/tlm/examples/slave_port/SConstruct PRE-CREATION 
  util/tlm/examples/slave_port/main.cc PRE-CREATION 
  util/tlm/examples/slave_port/sc_target.cc PRE-CREATION 
  util/tlm/examples/slave_port/tlm.py PRE-CREATION 
  util/tlm/gem5_master_transactor.hh PRE-CREATION 
  util/tlm/gem5_master_transactor.cc PRE-CREATION 
  util/tlm/gem5_slave_transactor.hh PRE-CREATION 
  util/tlm/gem5_slave_transactor.cc PRE-CREATION 
  util/tlm/sc_master_port.hh PRE-CREATION 
  util/tlm/sc_master_port.cc PRE-CREATION 
  util/tlm/sc_slave_port.hh PRE-CREATION 
  util/tlm/sc_slave_port.cc PRE-CREATION 
  util/tlm/sim_control.hh PRE-CREATION 
  util/tlm/sim_control.cc PRE-CREATION 

Diff: http://reviews.gem5.org/r/3695/diff/


Testing
---

Examples compile and run.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3695: misc: final cleanup of the TLM modules

2016-11-09 Thread Christian Menard 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3695/
---

(Updated Nov. 9, 2016, 11:02 a.m.)


Review request for Default.


Repository: gem5


Description (updated)
---

Changeset 11709:252a9a8975d9
---
misc: final cleanup of the TLM modules

Introduce new transactor modules. These modules rerpresent the gem5 TLM ports
in the SystemC world. Common code in the examples is moved to a common dir.


Diffs (updated)
-

  util/tlm/examples/common/cli_parser.hh PRE-CREATION 
  util/tlm/examples/common/cli_parser.cc PRE-CREATION 
  util/tlm/examples/common/report_handler.hh PRE-CREATION 
  util/tlm/examples/common/report_handler.cc PRE-CREATION 
  util/tlm/examples/master_port/SConstruct PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/master_port/tlm.py PRE-CREATION 
  util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION 
  util/tlm/examples/slave_port/SConstruct PRE-CREATION 
  util/tlm/examples/slave_port/main.cc PRE-CREATION 
  util/tlm/examples/slave_port/sc_target.cc PRE-CREATION 
  util/tlm/examples/slave_port/tlm.py PRE-CREATION 
  util/tlm/gem5_master_transactor.hh PRE-CREATION 
  util/tlm/gem5_master_transactor.cc PRE-CREATION 
  util/tlm/gem5_slave_transactor.hh PRE-CREATION 
  util/tlm/gem5_slave_transactor.cc PRE-CREATION 
  util/tlm/sc_master_port.hh PRE-CREATION 
  util/tlm/sc_master_port.cc PRE-CREATION 
  util/tlm/sc_slave_port.hh PRE-CREATION 
  util/tlm/sc_slave_port.cc PRE-CREATION 
  util/tlm/sim_control.hh PRE-CREATION 
  util/tlm/sim_control.cc PRE-CREATION 

Diff: http://reviews.gem5.org/r/3695/diff/


Testing
---

Examples compile and run.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3695: misc: final cleanup of the TLM modules

2016-11-07 Thread Christian Menard 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3695/#review9025
---



util/tlm/gem5_master_transactor.hh (line 1)


Add more comments and update the README


- Christian Menard


On Nov. 7, 2016, 4:43 p.m., Christian Menard wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3695/
> ---
> 
> (Updated Nov. 7, 2016, 4:43 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11709:bb031d9ed718
> ---
> misc: final cleanup of the TLM modules
> 
> Introduce new transactor modules. These modules rerpresent the gem5 TLM ports
> in the SystemC world. Common code in the examples is moved to a common dir.
> 
> 
> Diffs
> -
> 
>   util/tlm/sc_master_port.hh PRE-CREATION 
>   util/tlm/sc_master_port.cc PRE-CREATION 
>   util/tlm/sc_slave_port.hh PRE-CREATION 
>   util/tlm/sc_slave_port.cc PRE-CREATION 
>   util/tlm/sim_control.hh PRE-CREATION 
>   util/tlm/sim_control.cc PRE-CREATION 
>   util/tlm/examples/slave_port/tlm.py PRE-CREATION 
>   util/tlm/gem5_master_transactor.hh PRE-CREATION 
>   util/tlm/gem5_master_transactor.cc PRE-CREATION 
>   util/tlm/examples/master_port/main.cc PRE-CREATION 
>   util/tlm/examples/master_port/tlm.py PRE-CREATION 
>   util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION 
>   util/tlm/examples/slave_port/SConstruct PRE-CREATION 
>   util/tlm/examples/slave_port/main.cc PRE-CREATION 
>   util/tlm/examples/slave_port/sc_target.cc PRE-CREATION 
>   util/tlm/examples/common/cli_parser.hh PRE-CREATION 
>   util/tlm/examples/common/cli_parser.cc PRE-CREATION 
>   util/tlm/examples/common/report_handler.hh PRE-CREATION 
>   util/tlm/examples/common/report_handler.cc PRE-CREATION 
>   util/tlm/examples/master_port/SConstruct PRE-CREATION 
>   util/tlm/gem5_slave_transactor.hh PRE-CREATION 
>   util/tlm/gem5_slave_transactor.cc PRE-CREATION 
> 
> Diff: http://reviews.gem5.org/r/3695/diff/
> 
> 
> Testing
> ---
> 
> Examples compile and run.
> 
> 
> Thanks,
> 
> Christian Menard
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3695: misc: final cleanup of the TLM modules

2016-11-07 Thread Christian Menard 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3695/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11709:bb031d9ed718
---
misc: final cleanup of the TLM modules

Introduce new transactor modules. These modules rerpresent the gem5 TLM ports
in the SystemC world. Common code in the examples is moved to a common dir.


Diffs
-

  util/tlm/sc_master_port.hh PRE-CREATION 
  util/tlm/sc_master_port.cc PRE-CREATION 
  util/tlm/sc_slave_port.hh PRE-CREATION 
  util/tlm/sc_slave_port.cc PRE-CREATION 
  util/tlm/sim_control.hh PRE-CREATION 
  util/tlm/sim_control.cc PRE-CREATION 
  util/tlm/examples/slave_port/tlm.py PRE-CREATION 
  util/tlm/gem5_master_transactor.hh PRE-CREATION 
  util/tlm/gem5_master_transactor.cc PRE-CREATION 
  util/tlm/examples/master_port/main.cc PRE-CREATION 
  util/tlm/examples/master_port/tlm.py PRE-CREATION 
  util/tlm/examples/master_port/traffic_generator.cc PRE-CREATION 
  util/tlm/examples/slave_port/SConstruct PRE-CREATION 
  util/tlm/examples/slave_port/main.cc PRE-CREATION 
  util/tlm/examples/slave_port/sc_target.cc PRE-CREATION 
  util/tlm/examples/common/cli_parser.hh PRE-CREATION 
  util/tlm/examples/common/cli_parser.cc PRE-CREATION 
  util/tlm/examples/common/report_handler.hh PRE-CREATION 
  util/tlm/examples/common/report_handler.cc PRE-CREATION 
  util/tlm/examples/master_port/SConstruct PRE-CREATION 
  util/tlm/gem5_slave_transactor.hh PRE-CREATION 
  util/tlm/gem5_slave_transactor.cc PRE-CREATION 

Diff: http://reviews.gem5.org/r/3695/diff/


Testing
---

Examples compile and run.


Thanks,

Christian Menard

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev