Re: [gem5-dev] Review Request 3697: style: [PATCH 16/22] correct some style issues
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3697/#review9062 --- Ship it! Ship It! - Michael LeBeane On Nov. 7, 2016, 10:05 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3697/ > --- > > (Updated Nov. 7, 2016, 10:05 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11705:baf743047c38 > --- > style: [PATCH 16/22] correct some style issues > > > Diffs > - > > src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/base/loader/object_file.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/base/loader/elf_object.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > > Diff: http://reviews.gem5.org/r/3697/diff/ > > > Testing > --- > > > Thanks, > > Brandon Potter > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3697: style: [PATCH 16/22] correct some style issues
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3697/#review9037 --- Ship it! Ship It! - Tony Gutierrez On Nov. 7, 2016, 2:05 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3697/ > --- > > (Updated Nov. 7, 2016, 2:05 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11705:baf743047c38 > --- > style: [PATCH 16/22] correct some style issues > > > Diffs > - > > src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/base/loader/object_file.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/base/loader/elf_object.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > > Diff: http://reviews.gem5.org/r/3697/diff/ > > > Testing > --- > > > Thanks, > > Brandon Potter > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3697: style: [PATCH 16/22] correct some style issues
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3697/#review9028 --- Ship it! 10 points for pedantry. I guess things like this need to cleaned up at some point. Thanks! - Jason Lowe-Power On Nov. 7, 2016, 10:05 p.m., Brandon Potter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3697/ > --- > > (Updated Nov. 7, 2016, 10:05 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11705:baf743047c38 > --- > style: [PATCH 16/22] correct some style issues > > > Diffs > - > > src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/base/loader/object_file.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/base/loader/elf_object.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 > src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 > > Diff: http://reviews.gem5.org/r/3697/diff/ > > > Testing > --- > > > Thanks, > > Brandon Potter > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Review Request 3697: style: [PATCH 16/22] correct some style issues
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3697/ --- Review request for Default. Repository: gem5 Description --- Changeset 11705:baf743047c38 --- style: [PATCH 16/22] correct some style issues Diffs - src/sim/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/base/loader/object_file.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/base/loader/elf_object.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/x86/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/arch/x86/linux/process.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/syscall_emul.cc 4a86763c0b30cccba0f56c7f48637a46a4663b06 src/sim/syscall_emul.hh 4a86763c0b30cccba0f56c7f48637a46a4663b06 Diff: http://reviews.gem5.org/r/3697/diff/ Testing --- Thanks, Brandon Potter ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
