Re: [gem5-dev] Review Request 3739: gpu-compute: init valid field of GpuTlbEntry in default ctor
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3739/#review9142 --- Ship it! This fixed a ubsan error I was seeing. - Joe Gross On Nov. 21, 2016, 12:46 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3739/ > --- > > (Updated Nov. 21, 2016, 12:46 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11902:877b71cb546d > --- > gpu-compute: init valid field of GpuTlbEntry in default ctor > > valid field for GpuTlbEntry is not set in the default ctor, which can > lead to strange behavior, and is also flagged by UBSAN. > > > Diffs > - > > src/gpu-compute/gpu_tlb.hh 9e5050028323260c6d2211d7158ac4a4145ed8bc > > Diff: http://reviews.gem5.org/r/3739/diff/ > > > Testing > --- > > > Thanks, > > Tony Gutierrez > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3739: gpu-compute: init valid field of GpuTlbEntry in default ctor
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3739/ --- (Updated Nov. 21, 2016, 10:46 a.m.) Review request for Default. Repository: gem5 Description (updated) --- Changeset 11902:877b71cb546d --- gpu-compute: init valid field of GpuTlbEntry in default ctor valid field for GpuTlbEntry is not set in the default ctor, which can lead to strange behavior, and is also flagged by UBSAN. Diffs - src/gpu-compute/gpu_tlb.hh 9e5050028323260c6d2211d7158ac4a4145ed8bc Diff: http://reviews.gem5.org/r/3739/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Review Request 3739: gpu-compute: init valid field of GpuTlbEntry in default ctor
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3739/ --- Review request for Default. Repository: gem5 Description --- Changeset 11902:877b71cb546d --- gpu-compute: init valid field of GpuTlbEntry in default ctor the default ctor for GpuTlbEntry is not set in the default ctor, which can lead to strange behavior, and is also flagged by UBSAN. Diffs - src/gpu-compute/gpu_tlb.hh 9e5050028323260c6d2211d7158ac4a4145ed8bc Diff: http://reviews.gem5.org/r/3739/diff/ Testing --- Thanks, Tony Gutierrez ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
