Re: [gem5-dev] Review Request 3741: ruby: add default ctor for MachineID type

2016-11-21 Thread Joe Gross

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3741/#review9147
---

Ship it!


Ship It!

- Joe Gross


On Nov. 21, 2016, 1:24 p.m., Tony Gutierrez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3741/
> ---
> 
> (Updated Nov. 21, 2016, 1:24 p.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11903:5fc941f6049b
> ---
> ruby: add default ctor for MachineID type
> 
> not all uses of MachineID initialize its fields, so here we add a default
> ctor.
> 
> 
> Diffs
> -
> 
>   src/mem/ruby/common/MachineID.hh 9e5050028323260c6d2211d7158ac4a4145ed8bc 
> 
> Diff: http://reviews.gem5.org/r/3741/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Tony Gutierrez
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev


[gem5-dev] Review Request 3741: ruby: add default ctor for MachineID type

2016-11-21 Thread Tony Gutierrez

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3741/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11903:5fc941f6049b
---
ruby: add default ctor for MachineID type

not all uses of MachineID initialize its fields, so here we add a default
ctor.


Diffs
-

  src/mem/ruby/common/MachineID.hh 9e5050028323260c6d2211d7158ac4a4145ed8bc 

Diff: http://reviews.gem5.org/r/3741/diff/


Testing
---


Thanks,

Tony Gutierrez

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev