Re: [gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/#review9146 --- Ship it! Ship It! - Joe Gross On Nov. 21, 2016, 4:32 p.m., Matthew Poremba wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3742/ > --- > > (Updated Nov. 21, 2016, 4:32 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11711:7a987e64e013 > --- > ruby: Fix overflow reported by ASAN in MessageBuffer. > > In MessageBuffer the m_not_avail_count member is incremented but not used. > This causes an overflow reported by ASAN. This patch changes from an int to > Stats::Scalar, since the count is useful in debugging finite MessageBuffers. > > > Diffs > - > > src/mem/ruby/network/MessageBuffer.hh > 9e5050028323260c6d2211d7158ac4a4145ed8bc > src/mem/ruby/network/MessageBuffer.cc > 9e5050028323260c6d2211d7158ac4a4145ed8bc > > Diff: http://reviews.gem5.org/r/3742/diff/ > > > Testing > --- > > > Thanks, > > Matthew Poremba > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/#review9145 --- Ship it! Ship It! - Jason Lowe-Power On Nov. 21, 2016, 10:32 p.m., Matthew Poremba wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3742/ > --- > > (Updated Nov. 21, 2016, 10:32 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11711:7a987e64e013 > --- > ruby: Fix overflow reported by ASAN in MessageBuffer. > > In MessageBuffer the m_not_avail_count member is incremented but not used. > This causes an overflow reported by ASAN. This patch changes from an int to > Stats::Scalar, since the count is useful in debugging finite MessageBuffers. > > > Diffs > - > > src/mem/ruby/network/MessageBuffer.hh > 9e5050028323260c6d2211d7158ac4a4145ed8bc > src/mem/ruby/network/MessageBuffer.cc > 9e5050028323260c6d2211d7158ac4a4145ed8bc > > Diff: http://reviews.gem5.org/r/3742/diff/ > > > Testing > --- > > > Thanks, > > Matthew Poremba > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/#review9144 --- Ship it! Ship It! - Tony Gutierrez On Nov. 21, 2016, 2:32 p.m., Matthew Poremba wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3742/ > --- > > (Updated Nov. 21, 2016, 2:32 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11711:7a987e64e013 > --- > ruby: Fix overflow reported by ASAN in MessageBuffer. > > In MessageBuffer the m_not_avail_count member is incremented but not used. > This causes an overflow reported by ASAN. This patch changes from an int to > Stats::Scalar, since the count is useful in debugging finite MessageBuffers. > > > Diffs > - > > src/mem/ruby/network/MessageBuffer.hh > 9e5050028323260c6d2211d7158ac4a4145ed8bc > src/mem/ruby/network/MessageBuffer.cc > 9e5050028323260c6d2211d7158ac4a4145ed8bc > > Diff: http://reviews.gem5.org/r/3742/diff/ > > > Testing > --- > > > Thanks, > > Matthew Poremba > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/#review9143 --- Ship it! Ship It! - Brad Beckmann On Nov. 21, 2016, 10:32 p.m., Matthew Poremba wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3742/ > --- > > (Updated Nov. 21, 2016, 10:32 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11711:7a987e64e013 > --- > ruby: Fix overflow reported by ASAN in MessageBuffer. > > In MessageBuffer the m_not_avail_count member is incremented but not used. > This causes an overflow reported by ASAN. This patch changes from an int to > Stats::Scalar, since the count is useful in debugging finite MessageBuffers. > > > Diffs > - > > src/mem/ruby/network/MessageBuffer.hh > 9e5050028323260c6d2211d7158ac4a4145ed8bc > src/mem/ruby/network/MessageBuffer.cc > 9e5050028323260c6d2211d7158ac4a4145ed8bc > > Diff: http://reviews.gem5.org/r/3742/diff/ > > > Testing > --- > > > Thanks, > > Matthew Poremba > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/ --- Review request for Default. Repository: gem5 Description --- Changeset 11711:7a987e64e013 --- ruby: Fix overflow reported by ASAN in MessageBuffer. In MessageBuffer the m_not_avail_count member is incremented but not used. This causes an overflow reported by ASAN. This patch changes from an int to Stats::Scalar, since the count is useful in debugging finite MessageBuffers. Diffs - src/mem/ruby/network/MessageBuffer.hh 9e5050028323260c6d2211d7158ac4a4145ed8bc src/mem/ruby/network/MessageBuffer.cc 9e5050028323260c6d2211d7158ac4a4145ed8bc Diff: http://reviews.gem5.org/r/3742/diff/ Testing --- Thanks, Matthew Poremba ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
