Re: [gem5-dev] Review Request 3768: sim: Remove redundant export_method_cxx_predecls
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3768/#review9225 --- Ship it! Ship It! - Jason Lowe-Power On Dec. 20, 2016, 8:07 a.m., Andreas Sandberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3768/ > --- > > (Updated Dec. 20, 2016, 8:07 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11768:e22181336f15 > --- > sim: Remove redundant export_method_cxx_predecls > > The headers declared in export_method_cxx_predecls are redundant since a > SimObject's main header is automatically included. > > Change-Id: Ied9e84630b36960e54efe91d16f8c66fba7e0da0 > Signed-off-by: Andreas Sandberg > Reviewed-by: Curtis Dunham > > > Diffs > - > > src/arch/arm/ArmSystem.py 6ef6e5dbff2d > src/cpu/kvm/BaseKvmCPU.py 6ef6e5dbff2d > src/python/m5/SimObject.py 6ef6e5dbff2d > src/sim/System.py 6ef6e5dbff2d > > Diff: http://reviews.gem5.org/r/3768/diff/ > > > Testing > --- > > > Thanks, > > Andreas Sandberg > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] Review Request 3768: sim: Remove redundant export_method_cxx_predecls
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3768/#review9223 --- Ship it! Ship It! - Joe Gross On Dec. 20, 2016, 2:07 a.m., Andreas Sandberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3768/ > --- > > (Updated Dec. 20, 2016, 2:07 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > --- > > Changeset 11768:e22181336f15 > --- > sim: Remove redundant export_method_cxx_predecls > > The headers declared in export_method_cxx_predecls are redundant since a > SimObject's main header is automatically included. > > Change-Id: Ied9e84630b36960e54efe91d16f8c66fba7e0da0 > Signed-off-by: Andreas Sandberg > Reviewed-by: Curtis Dunham > > > Diffs > - > > src/arch/arm/ArmSystem.py 6ef6e5dbff2d > src/cpu/kvm/BaseKvmCPU.py 6ef6e5dbff2d > src/python/m5/SimObject.py 6ef6e5dbff2d > src/sim/System.py 6ef6e5dbff2d > > Diff: http://reviews.gem5.org/r/3768/diff/ > > > Testing > --- > > > Thanks, > > Andreas Sandberg > > ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] Review Request 3768: sim: Remove redundant export_method_cxx_predecls
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3768/ --- Review request for Default. Repository: gem5 Description --- Changeset 11768:e22181336f15 --- sim: Remove redundant export_method_cxx_predecls The headers declared in export_method_cxx_predecls are redundant since a SimObject's main header is automatically included. Change-Id: Ied9e84630b36960e54efe91d16f8c66fba7e0da0 Signed-off-by: Andreas Sandberg Reviewed-by: Curtis Dunham Diffs - src/arch/arm/ArmSystem.py 6ef6e5dbff2d src/cpu/kvm/BaseKvmCPU.py 6ef6e5dbff2d src/python/m5/SimObject.py 6ef6e5dbff2d src/sim/System.py 6ef6e5dbff2d Diff: http://reviews.gem5.org/r/3768/diff/ Testing --- Thanks, Andreas Sandberg ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
