Re: [gem5-dev] Review Request 3801: misc: fix building issue (undefined variables)

2017-02-03 Thread Pierre-Yves Péneau 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3801/
---

(Updated Feb. 3, 2017, 10:02 a.m.)


Review request for Default.


Repository: gem5


Description
---

Changeset 11808:e0730e1d7afa
---
misc: fix building issue (undefined variables)

Signed-off-by: Pierre-Yves Péneau 


Diffs (updated)
-

  src/mem/comm_monitor.cc 63325e5b0a9d 

Diff: http://reviews.gem5.org/r/3801/diff/


Testing
---


Thanks,

Pierre-Yves Péneau

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3801: misc: fix building issue (undefined variables)

2017-02-03 Thread Andreas Hansson 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3801/#review9386
---


Thanks for fixing. Could you make it "mem:" and also include CommMonitor in the 
description. I also expect this is due to unused variables in fast builds? Not 
undefined variables.

- Andreas Hansson


On Feb. 3, 2017, 8:37 a.m., Pierre-Yves Péneau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3801/
> ---
> 
> (Updated Feb. 3, 2017, 8:37 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11808:e0730e1d7afa
> ---
> misc: fix building issue (undefined variables)
> 
> Signed-off-by: Pierre-Yves Péneau 
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 63325e5b0a9d 
> 
> Diff: http://reviews.gem5.org/r/3801/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pierre-Yves Péneau
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3801: misc: fix building issue (undefined variables)

2017-02-03 Thread Andreas Hansson 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3801/#review9385
---



src/mem/comm_monitor.cc (line 276)


the (const bool) part seems excessive


- Andreas Hansson


On Feb. 3, 2017, 8:37 a.m., Pierre-Yves Péneau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/3801/
> ---
> 
> (Updated Feb. 3, 2017, 8:37 a.m.)
> 
> 
> Review request for Default.
> 
> 
> Repository: gem5
> 
> 
> Description
> ---
> 
> Changeset 11808:e0730e1d7afa
> ---
> misc: fix building issue (undefined variables)
> 
> Signed-off-by: Pierre-Yves Péneau 
> 
> 
> Diffs
> -
> 
>   src/mem/comm_monitor.cc 63325e5b0a9d 
> 
> Diff: http://reviews.gem5.org/r/3801/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pierre-Yves Péneau
> 
>

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev

[gem5-dev] Review Request 3801: misc: fix building issue (undefined variables)

2017-02-03 Thread Pierre-Yves Péneau 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3801/
---

Review request for Default.


Repository: gem5


Description
---

Changeset 11808:e0730e1d7afa
---
misc: fix building issue (undefined variables)

Signed-off-by: Pierre-Yves Péneau 


Diffs
-

  src/mem/comm_monitor.cc 63325e5b0a9d 

Diff: http://reviews.gem5.org/r/3801/diff/


Testing
---


Thanks,

Pierre-Yves Péneau

___
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev