changeset 5777a3e55603 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=5777a3e55603
description:
ruby: remove the function functionalReadBuffers()
This function was added when I had incorrectly arrived at the conclusion
that such a function can improve the chances of a functional read
succeeding.
As was later realized, this is not possible in the current setup.
While the
code using this function was dropped long back, this function was not.
Hence
the patch.
diffstat:
src/mem/ruby/slicc_interface/AbstractController.hh | 7 +----
src/mem/slicc/symbols/StateMachine.py | 24 ----------------------
2 files changed, 2 insertions(+), 29 deletions(-)
diffs (58 lines):
diff -r 13312d6e1caf -r 5777a3e55603
src/mem/ruby/slicc_interface/AbstractController.hh
--- a/src/mem/ruby/slicc_interface/AbstractController.hh Thu Nov 06
05:42:20 2014 -0600
+++ b/src/mem/ruby/slicc_interface/AbstractController.hh Thu Nov 06
05:42:20 2014 -0600
@@ -76,11 +76,8 @@
virtual void recordCacheTrace(int cntrl, CacheRecorder* tr) = 0;
virtual Sequencer* getSequencer() const = 0;
- //! These functions are used by ruby system to read/write the message
- //! queues that exist with in the controller.
- //! The boolean return value indicates if the read was performed
- //! successfully.
- virtual bool functionalReadBuffers(PacketPtr&) = 0;
+ //! These functions are used by ruby system to read/write the data blocks
+ //! that exist with in the controller.
virtual void functionalRead(const Address &addr, PacketPtr) = 0;
//! The return value indicates the number of messages written with the
//! data from the packet.
diff -r 13312d6e1caf -r 5777a3e55603 src/mem/slicc/symbols/StateMachine.py
--- a/src/mem/slicc/symbols/StateMachine.py Thu Nov 06 05:42:20 2014 -0600
+++ b/src/mem/slicc/symbols/StateMachine.py Thu Nov 06 05:42:20 2014 -0600
@@ -285,7 +285,6 @@
void recordCacheTrace(int cntrl, CacheRecorder* tr);
Sequencer* getSequencer() const;
- bool functionalReadBuffers(PacketPtr&);
uint32_t functionalWriteBuffers(PacketPtr&);
void countTransition(${ident}_State state, ${ident}_Event event);
@@ -988,29 +987,6 @@
for func in self.functions:
code(func.generateCode())
- # Function for functional reads from messages buffered in the
controller
- code('''
-bool
-$c_ident::functionalReadBuffers(PacketPtr& pkt)
-{
-''')
- for var in self.objects:
- vtype = var.type
- if vtype.isBuffer:
- vid = "m_%s_ptr" % var.ident
- code('if ($vid->functionalRead(pkt)) { return true; }')
-
- for var in self.config_parameters:
- vtype = var.type_ast.type
- if vtype.isBuffer:
- vid = "m_%s_ptr" % var.ident
- code('if ($vid->functionalRead(pkt)) { return true; }')
-
- code('''
- return false;
-}
-''')
-
# Function for functional writes to messages buffered in the controller
code('''
uint32_t
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
