Re: [gem5-dev] how to post diff files on review board
Thanks for the pointer Nilay, I will look into review board extension. I think my last try worked, not quite sure what was different though. On Dec 4, 2014, at 10:30 AM, Nilay Vaish via gem5-dev wrote: > I think the problem you are experiencing happens when reviewboard is unable > to figure out the version of the repo on which to apply your patch. > > Initially I also used to use the web interface posting reviews. But now I > use the reviewboard extension of mercurial. I find it less error prone. For > a new review request, I use: hg postreview -o tip. For updating a request, I > use: hg postreview -p -e -u. > > -- > Nilay > > On Thu, 4 Dec 2014, Cagdas Dirik \(cdirik\) via gem5-dev wrote: > >> I am having a problem uploading my diff files for a review request. I >> generated diff file using hg export but when I upload them to review board I >> keep getting hunk failed error messages, but no reason why. Diff file looks >> normal. Any ideas on what may be wrong? Or am I using wrong process to >> update a review request? >> >> Case in question is r/2545: http://reviews.gem5.org/r/2545/ >> >> Thanks in advance. >> >> Cagdas >> ___ >> gem5-dev mailing list >> gem5-dev@gem5.org >> http://m5sim.org/mailman/listinfo/gem5-dev >> > ___ > gem5-dev mailing list > gem5-dev@gem5.org > http://m5sim.org/mailman/listinfo/gem5-dev ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
Re: [gem5-dev] how to post diff files on review board
I think the problem you are experiencing happens when reviewboard is unable to figure out the version of the repo on which to apply your patch. Initially I also used to use the web interface posting reviews. But now I use the reviewboard extension of mercurial. I find it less error prone. For a new review request, I use: hg postreview -o tip. For updating a request, I use: hg postreview -p -e -u. -- Nilay On Thu, 4 Dec 2014, Cagdas Dirik \(cdirik\) via gem5-dev wrote: I am having a problem uploading my diff files for a review request. I generated diff file using hg export but when I upload them to review board I keep getting hunk failed error messages, but no reason why. Diff file looks normal. Any ideas on what may be wrong? Or am I using wrong process to update a review request? Case in question is r/2545: http://reviews.gem5.org/r/2545/ Thanks in advance. Cagdas ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
[gem5-dev] how to post diff files on review board
I am having a problem uploading my diff files for a review request. I generated diff file using hg export but when I upload them to review board I keep getting hunk failed error messages, but no reason why. Diff file looks normal. Any ideas on what may be wrong? Or am I using wrong process to update a review request? Case in question is r/2545: http://reviews.gem5.org/r/2545/ Thanks in advance. Cagdas ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
