----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2764/#review6357 -----------------------------------------------------------
Ship it! Ship It! - Alexandru Dutu On May 7, 2015, 11 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2764/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 11 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10841:5bbc826fb52e > --------------------------- > arm: Get rid of pointless have_generic_timer param > > The ArmSystem class has a parameter to indicate whether it is > configured to use the generic timer extension or not. This parameter > doesn't affect any feature flags in the current implementation and is > therefore completely unnecessary. In fact, we usually don't set it > even if a system has a generic timer. If we ever need to check if > there is a generic timer present, we should just request a pointer and > check if it is non-null instead. > > > Diffs > ----- > > src/arch/arm/ArmSystem.py fbdaa08aaa42 > src/arch/arm/system.hh fbdaa08aaa42 > src/arch/arm/system.cc fbdaa08aaa42 > > Diff: http://reviews.gem5.org/r/2764/diff/ > > > Testing > ------- > > ARM regressions pass. All backends build. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
