Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-02 Thread Nilay Vaish 

---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/611/
---

(Updated 2011-04-02 11:42:47.195024)


Review request for Default.


Summary
---

Ruby: Add support for functional accesses
This patch is meant for aiding discussions on implementation of functional
access support in Ruby.


Diffs (updated)
-

  configs/ruby/MESI_CMP_directory.py aeec9e157d06 
  configs/ruby/Ruby.py aeec9e157d06 
  src/mem/ruby/network/Network.cc aeec9e157d06 
  src/mem/ruby/network/Network.py aeec9e157d06 
  src/mem/ruby/profiler/Profiler.cc aeec9e157d06 
  src/mem/ruby/profiler/Profiler.py aeec9e157d06 
  src/mem/ruby/recorder/Tracer.cc aeec9e157d06 
  src/mem/ruby/recorder/Tracer.py aeec9e157d06 
  src/mem/ruby/system/AbstractMemory.hh PRE-CREATION 
  src/mem/ruby/system/AbstractMemory.cc PRE-CREATION 
  src/mem/ruby/system/Cache.py aeec9e157d06 
  src/mem/ruby/system/CacheMemory.hh aeec9e157d06 
  src/mem/ruby/system/CacheMemory.cc aeec9e157d06 
  src/mem/ruby/system/DirectoryMemory.hh aeec9e157d06 
  src/mem/ruby/system/DirectoryMemory.cc aeec9e157d06 
  src/mem/ruby/system/DirectoryMemory.py aeec9e157d06 
  src/mem/ruby/system/RubyPort.hh aeec9e157d06 
  src/mem/ruby/system/RubyPort.cc aeec9e157d06 
  src/mem/ruby/system/RubySystem.py aeec9e157d06 
  src/mem/ruby/system/SConscript aeec9e157d06 
  src/mem/ruby/system/Sequencer.cc aeec9e157d06 
  src/mem/ruby/system/Sequencer.py aeec9e157d06 
  src/mem/ruby/system/System.hh aeec9e157d06 
  src/mem/ruby/system/System.cc aeec9e157d06 

Diff: http://reviews.m5sim.org/r/611/diff


Testing
---


Thanks,

Nilay

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-02 Thread Nilay Vaish 


> On 2011-03-31 22:08:21, Brad Beckmann wrote:
> > src/mem/ruby/system/RubyPort.cc, line 417
> > 
> >
> > Are functional packets put on the stack or the heap?  I seem to 
> > remember the former, but I could be wrong.

In a couple of places in src/mem/port.cc, the packet is on the stack.
But in src/cpu/testers/memtest/memtest.cc, the packet is on the heap.
As per the documentation, the packet is owned by the requestor. So, the
requestor will have to free the packet. I will remove this code. 


- Nilay


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/611/#review1082
---


On 2011-03-31 20:44:17, Nilay Vaish wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/611/
> ---
> 
> (Updated 2011-03-31 20:44:17)
> 
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> Ruby: Add support for functional accesses
> This patch is meant for aiding discussions on implementation of functional
> access support in Ruby.
> 
> 
> Diffs
> -
> 
>   configs/ruby/MESI_CMP_directory.py c7302d55d644 
>   configs/ruby/Ruby.py c7302d55d644 
>   src/mem/ruby/network/Network.cc c7302d55d644 
>   src/mem/ruby/network/Network.py c7302d55d644 
>   src/mem/ruby/profiler/Profiler.cc c7302d55d644 
>   src/mem/ruby/profiler/Profiler.py c7302d55d644 
>   src/mem/ruby/recorder/Tracer.cc c7302d55d644 
>   src/mem/ruby/recorder/Tracer.py c7302d55d644 
>   src/mem/ruby/system/AbstractMemory.hh PRE-CREATION 
>   src/mem/ruby/system/AbstractMemory.cc PRE-CREATION 
>   src/mem/ruby/system/Cache.py c7302d55d644 
>   src/mem/ruby/system/CacheMemory.hh c7302d55d644 
>   src/mem/ruby/system/CacheMemory.cc c7302d55d644 
>   src/mem/ruby/system/DirectoryMemory.hh c7302d55d644 
>   src/mem/ruby/system/DirectoryMemory.cc c7302d55d644 
>   src/mem/ruby/system/DirectoryMemory.py c7302d55d644 
>   src/mem/ruby/system/RubyPort.hh c7302d55d644 
>   src/mem/ruby/system/RubyPort.cc c7302d55d644 
>   src/mem/ruby/system/RubySystem.py c7302d55d644 
>   src/mem/ruby/system/SConscript c7302d55d644 
>   src/mem/ruby/system/Sequencer.cc c7302d55d644 
>   src/mem/ruby/system/Sequencer.py c7302d55d644 
>   src/mem/ruby/system/System.hh c7302d55d644 
>   src/mem/ruby/system/System.cc c7302d55d644 
> 
> Diff: http://reviews.m5sim.org/r/611/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nilay
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Review Request: Ruby: Add support for functional accesses

2011-04-02 Thread Nilay Vaish 


> On 2011-04-01 09:30:54, Brad Beckmann wrote:
> > Hi Nilay,

Comments below.  I might be missing something, but the changes to 
DirectoryMemory seem straightforward.

No, you are not missing anything. It is just that I had not implemented
it up till now.


- Nilay


---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/611/#review1085
---


On 2011-03-31 20:44:17, Nilay Vaish wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.m5sim.org/r/611/
> ---
> 
> (Updated 2011-03-31 20:44:17)
> 
> 
> Review request for Default.
> 
> 
> Summary
> ---
> 
> Ruby: Add support for functional accesses
> This patch is meant for aiding discussions on implementation of functional
> access support in Ruby.
> 
> 
> Diffs
> -
> 
>   configs/ruby/MESI_CMP_directory.py c7302d55d644 
>   configs/ruby/Ruby.py c7302d55d644 
>   src/mem/ruby/network/Network.cc c7302d55d644 
>   src/mem/ruby/network/Network.py c7302d55d644 
>   src/mem/ruby/profiler/Profiler.cc c7302d55d644 
>   src/mem/ruby/profiler/Profiler.py c7302d55d644 
>   src/mem/ruby/recorder/Tracer.cc c7302d55d644 
>   src/mem/ruby/recorder/Tracer.py c7302d55d644 
>   src/mem/ruby/system/AbstractMemory.hh PRE-CREATION 
>   src/mem/ruby/system/AbstractMemory.cc PRE-CREATION 
>   src/mem/ruby/system/Cache.py c7302d55d644 
>   src/mem/ruby/system/CacheMemory.hh c7302d55d644 
>   src/mem/ruby/system/CacheMemory.cc c7302d55d644 
>   src/mem/ruby/system/DirectoryMemory.hh c7302d55d644 
>   src/mem/ruby/system/DirectoryMemory.cc c7302d55d644 
>   src/mem/ruby/system/DirectoryMemory.py c7302d55d644 
>   src/mem/ruby/system/RubyPort.hh c7302d55d644 
>   src/mem/ruby/system/RubyPort.cc c7302d55d644 
>   src/mem/ruby/system/RubySystem.py c7302d55d644 
>   src/mem/ruby/system/SConscript c7302d55d644 
>   src/mem/ruby/system/Sequencer.cc c7302d55d644 
>   src/mem/ruby/system/Sequencer.py c7302d55d644 
>   src/mem/ruby/system/System.hh c7302d55d644 
>   src/mem/ruby/system/System.cc c7302d55d644 
> 
> Diff: http://reviews.m5sim.org/r/611/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Nilay
> 
>

___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev

[m5-dev] Cron /z/m5/regression/do-regression quick

2011-04-02 Thread Cron Daemon 
scons: *** Found dependency cycle(s):
* 
build/ALPHA_SE_MOESI_CMP_token/tests/fast/quick/00.hello/alpha/linux/simple-timing-ruby-MOESI_CMP_token
 passed.
* 
build/ALPHA_SE_MOESI_CMP_directory/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby-MOESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MOESI_CMP_directory/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby-MOESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MOESI_CMP_directory/tests/fast/quick/60.rubytest/alpha/linux/rubytest-ruby-MOESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MOESI_CMP_directory/tests/fast/quick/00.hello/alpha/linux/simple-timing-ruby-MOESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MESI_CMP_directory/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby-MESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MESI_CMP_directory/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby-MESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MESI_CMP_directory/tests/fast/quick/60.rubytest/alpha/linux/rubytest-ruby-MESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MESI_CMP_directory/tests/fast/quick/00.hello/alpha/linux/simple-timing-ruby-MESI_CMP_directory
 passed.
* 
build/ALPHA_SE_MOESI_CMP_token/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby-MOESI_CMP_token
 passed.
* 
build/ALPHA_SE_MOESI_CMP_token/tests/fast/quick/50.memtest/alpha/linux/memtest-ruby-MOESI_CMP_token
 passed.
* 
build/ALPHA_SE_MOESI_CMP_token/tests/fast/quick/60.rubytest/alpha/linux/rubytest-ruby-MOESI_CMP_token
 passed.
* 
build/ALPHA_FS/tests/fast/quick/10.linux-boot/alpha/linux/tsunami-simple-atomic-dual
 passed.
* 
build/ALPHA_FS/tests/fast/quick/10.linux-boot/alpha/linux/tsunami-simple-atomic 
passed.
* 
build/ALPHA_FS/tests/fast/quick/10.linux-boot/alpha/linux/tsunami-simple-timing 
passed.
* 
build/ALPHA_FS/tests/fast/quick/10.linux-boot/alpha/linux/tsunami-simple-timing-dual
 passed.
* 
build/ALPHA_FS/tests/fast/quick/80.netperf-stream/alpha/linux/twosys-tsunami-simple-atomic
 passed.
* 
build/ALPHA_SE_MOESI_hammer/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby-MOESI_hammer
 passed.
* build/ALPHA_SE/tests/fast/quick/20.eio-short/alpha/eio/simple-atomic 
passed.
* 
build/ALPHA_SE_MOESI_hammer/tests/fast/quick/60.rubytest/alpha/linux/rubytest-ruby-MOESI_hammer
 passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/tru64/simple-timing passed.
* 
build/ALPHA_SE_MOESI_hammer/tests/fast/quick/00.hello/alpha/linux/simple-timing-ruby-MOESI_hammer
 passed.
* build/ALPHA_SE/tests/fast/quick/30.eio-mp/alpha/eio/simple-atomic-mp 
passed.
 * build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-timing-ruby 
passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-atomic passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/tru64/o3-timing passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/inorder-timing 
passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/o3-timing passed.
* build/ALPHA_SE/tests/fast/quick/20.eio-short/alpha/eio/simple-timing 
passed.
* build/ALPHA_SE/tests/fast/quick/60.rubytest/alpha/linux/rubytest-ruby 
passed.
* build/ALPHA_SE/tests/fast/quick/01.hello-2T-smt/alpha/linux/o3-timing 
passed.
* build/ALPHA_SE/tests/fast/quick/30.eio-mp/alpha/eio/simple-timing-mp 
passed.
* build/MIPS_SE/tests/fast/quick/00.hello/mips/linux/inorder-timing passed.
* build/MIPS_SE/tests/fast/quick/00.hello/mips/linux/o3-timing passed.
* build/MIPS_SE/tests/fast/quick/00.hello/mips/linux/simple-atomic passed.
* build/MIPS_SE/tests/fast/quick/00.hello/mips/linux/simple-timing passed.
* build/MIPS_SE/tests/fast/quick/00.hello/mips/linux/simple-timing-ruby 
passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/tru64/simple-timing-ruby 
passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/tru64/simple-atomic passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-timing passed.
* build/POWER_SE/tests/fast/quick/00.hello/power/linux/o3-timing passed.
* build/POWER_SE/tests/fast/quick/00.hello/power/linux/simple-atomic passed.
* build/SPARC_SE/tests/fast/quick/00.hello/sparc/linux/simple-atomic passed.
* build/SPARC_SE/tests/fast/quick/00.hello/sparc/linux/simple-timing passed.
* build/SPARC_SE/tests/fast/quick/00.hello/sparc/linux/simple-timing-ruby 
passed.
* build/SPARC_SE/tests/fast/quick/02.insttest/sparc/linux/o3-timing passed.
* build/SPARC_SE/tests/fast/quick/02.insttest/sparc/linux/simple-atomic 
passed.
* build/SPARC_SE/tests/fast/quick/02.insttest/sparc/linux/simple-timing 
passed.
* 
build/SPARC_SE/tests/fast/quick/40.m5threads-test-atomic/sparc/linux/o3-timing-mp
 passed.
* 
build/SPARC_SE/tests/fast/quick/40.m5threads-test-atomic/sparc/linux/simple-atomic-mp
 passed.
* 
build/SPARC_SE/tests/fast/quick/40.m5threads-test-atomic/sparc/linux/simple-timing-mp
 passed.
* build/X86_SE/tests/fast/quick/00.hell