Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

2020-08-13 Thread Christer Holmberg 
Thank You, Alissa!

Regards,

Christer

-Original Message-
From: Alissa Cooper  
Sent: torstai 13. elokuuta 2020 3.51
To: Brian E Carpenter 
Cc: Christer Holmberg ; gen-art@ietf.org; 
draft-ietf-mmusic-msrp-usage-data-channel@ietf.org; last-c...@ietf.org; 
mmu...@ietf.org
Subject: Re: [Gen-art] Genart last call review of 
draft-ietf-mmusic-msrp-usage-data-channel-21

Brian, thanks for your review. Christer, thanks for addressing Brian’s 
comments. I entered a No Objection ballot.

Alissa


> On Jul 13, 2020, at 4:51 PM, Brian E Carpenter  
> wrote:
> 
> Thanks Christer, that all looks good to me,
> 
> Regards
>   Brian
> 
> On 13-Jul-20 20:58, Christer Holmberg wrote:
>> Hi Brian,
>> 
>> Thank You for the review! Please see inline.
>> 
>> 
>> Nits:
>> -
>> 
>>>> 4.1.  MSRP URI
>>>> 
>>>>transport  /= "dc"
>>>> 
>>>> I see that RFC7977 takes a slightly different approach to updating the 
>>>> ABNF:
>>>> 
>>>>transport  =  "tcp" / "ws" / 1*ALPHANUM
>>>> 
>>> The advantage of listing out
>>> 
>>> transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
>>> 
>>> would be that the reader sees the full list.
>> 
>> The MMUSIC WG has previously decided to take the approach of only writing 
>> the new value, using the "/=" format.
>> 
>> ---
>> 
>>>> ; Add "dc" to existing transports per [RFC4975]
>>>> 
>>>> I suggest
>>>> 
>>>>; Add "dc" to existing transports per Section 9 of 
>>>> [RFC4975]
>> 
>> Will modify as suggested.
>> 
>> ---
>> 
>>>> 4.6.  Session Closing
>>>> 
>>>>  The SDP answerer must ensure that no dcmap or dcsa attributes are  
>>>> present in the SDP answer if no corresponding attributes are 
>>>> present  in the received SDP offer.
>>>> 
>>>> Should that be MUST?
>> 
>> The reason for "must" is that is referring to generic data channel SDP O/A 
>> procedures.
>> 
>> I suggest to remove the paragraph.
>> 
>> ---
>> 
>>>> B2BUA
>>>> 
>>>> Define the acronym please.
>> 
>> We normally don't do that in MMUSIC specifications. Also, it is on the IETF 
>> list of well-known acronyms.
>> 
>> Having said that, I am fine to enhance it on first occurrence: 'Back-to-Back 
>> User Agent (B2BUA)'
>> 
>> ---
>> 
>>>> 9.2.  Subprotocol Identifier MSRP
>>>> 
>>>>  A reference to this document is added to the subprotocol 
>>>> identifier  "msrp" in the "WebSocket Subprotocol Name Registry"
>>>> 
>>>> s/this document/RFC/
>> 
>> Will modify as suggested.
>> 
>> ---
>> 
>>>> 11.  CHANGE LOG
>>>> 
>>>> Mark this section for deletion by the RFC Editor
>> 
>> I think the RFC Editor will delete it by default, but we can add explicit 
>> text.
>> 
>> Regards,
>> 
>> Christer
>> 
> 
> ___
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

2020-08-12 Thread Alissa Cooper 
Brian, thanks for your review. Christer, thanks for addressing Brian’s 
comments. I entered a No Objection ballot.

Alissa


> On Jul 13, 2020, at 4:51 PM, Brian E Carpenter  
> wrote:
> 
> Thanks Christer, that all looks good to me,
> 
> Regards
>   Brian
> 
> On 13-Jul-20 20:58, Christer Holmberg wrote:
>> Hi Brian,
>> 
>> Thank You for the review! Please see inline.
>> 
>> 
>> Nits:
>> -
>> 
 4.1.  MSRP URI
 
transport  /= "dc"
 
 I see that RFC7977 takes a slightly different approach to updating the 
 ABNF:
 
transport  =  "tcp" / "ws" / 1*ALPHANUM
 
>>> The advantage of listing out
>>> 
>>> transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
>>> 
>>> would be that the reader sees the full list.
>> 
>> The MMUSIC WG has previously decided to take the approach of only writing 
>> the new value, using the "/=" format.
>> 
>> ---
>> 
 ; Add "dc" to existing transports per [RFC4975]
 
 I suggest
 
; Add "dc" to existing transports per Section 9 of [RFC4975]
>> 
>> Will modify as suggested.
>> 
>> ---
>> 
 4.6.  Session Closing
 
  The SDP answerer must ensure that no dcmap or dcsa attributes are
  present in the SDP answer if no corresponding attributes are present
  in the received SDP offer.
 
 Should that be MUST?
>> 
>> The reason for "must" is that is referring to generic data channel SDP O/A 
>> procedures.
>> 
>> I suggest to remove the paragraph.
>> 
>> ---
>> 
 B2BUA
 
 Define the acronym please.
>> 
>> We normally don't do that in MMUSIC specifications. Also, it is on the IETF 
>> list of well-known acronyms.
>> 
>> Having said that, I am fine to enhance it on first occurrence: 'Back-to-Back 
>> User Agent (B2BUA)'
>> 
>> ---
>> 
 9.2.  Subprotocol Identifier MSRP
 
  A reference to this document is added to the subprotocol identifier
  "msrp" in the "WebSocket Subprotocol Name Registry"
 
 s/this document/RFC/
>> 
>> Will modify as suggested.
>> 
>> ---
>> 
 11.  CHANGE LOG
 
 Mark this section for deletion by the RFC Editor
>> 
>> I think the RFC Editor will delete it by default, but we can add explicit 
>> text.
>> 
>> Regards,
>> 
>> Christer
>> 
> 
> ___
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

2020-07-16 Thread Christer Holmberg 
Will do. Thanks!

Regards,

Christer

From: Murray S. Kucherawy 
Sent: torstai 16. heinäkuuta 2020 18.51
To: Christer Holmberg 
Cc: Brian E Carpenter ; gen-art@ietf.org; 
draft-ietf-mmusic-msrp-usage-data-channel@ietf.org; last-c...@ietf.org; 
mmu...@ietf.org
Subject: Re: [Gen-art] Genart last call review of 
draft-ietf-mmusic-msrp-usage-data-channel-21

If you email the files to 
internet-dra...@ietf.org<mailto:internet-dra...@ietf.org> and Cc: me, I'll 
approve them and then the secretariat will put the update in the tracker.
-MSK

On Tue, Jul 14, 2020 at 5:39 AM Christer Holmberg 
mailto:christer.holmb...@ericsson.com>> wrote:
Hi,

I have created a new version (-22) of the draft, based on Brian's comment.

Murray, as the submission window is currently closed, are you able to manually 
submit the new version if I send you the files?

Regards,

Christer



-Original Message-
From: Brian E Carpenter 
mailto:brian.e.carpen...@gmail.com>>
Sent: maanantai 13. heinäkuuta 2020 23.52
To: Christer Holmberg 
mailto:christer.holmb...@ericsson.com>>; 
gen-art@ietf.org<mailto:gen-art@ietf.org>
Cc: 
draft-ietf-mmusic-msrp-usage-data-channel@ietf.org<mailto:draft-ietf-mmusic-msrp-usage-data-channel@ietf.org>;
 last-c...@ietf.org<mailto:last-c...@ietf.org>; 
mmu...@ietf.org<mailto:mmu...@ietf.org>
Subject: Re: [Gen-art] Genart last call review of 
draft-ietf-mmusic-msrp-usage-data-channel-21

Thanks Christer, that all looks good to me,

Regards
   Brian

On 13-Jul-20 20:58, Christer Holmberg wrote:
> Hi Brian,
>
> Thank You for the review! Please see inline.
>
>
> Nits:
> -
>
>>> 4.1.  MSRP URI
>>> 
>>> transport  /= "dc"
>>>
>>> I see that RFC7977 takes a slightly different approach to updating the ABNF:
>>>
>>> transport  =  "tcp" / "ws" / 1*ALPHANUM
>>>
>> The advantage of listing out
>>
>>  transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
>>
>> would be that the reader sees the full list.
>
> The MMUSIC WG has previously decided to take the approach of only writing the 
> new value, using the "/=" format.
>
> ---
>
>>>  ; Add "dc" to existing transports per [RFC4975]
>>>
>>> I suggest
>>>
>>> ; Add "dc" to existing transports per Section 9 of [RFC4975]
>
> Will modify as suggested.
>
> ---
>
>>> 4.6.  Session Closing
>>>
>>>   The SDP answerer must ensure that no dcmap or dcsa attributes are
>>>   present in the SDP answer if no corresponding attributes are present
>>>   in the received SDP offer.
>>>
>>> Should that be MUST?
>
> The reason for "must" is that is referring to generic data channel SDP O/A 
> procedures.
>
> I suggest to remove the paragraph.
>
> ---
>
>>> B2BUA
>>>
>>> Define the acronym please.
>
> We normally don't do that in MMUSIC specifications. Also, it is on the IETF 
> list of well-known acronyms.
>
> Having said that, I am fine to enhance it on first occurrence: 'Back-to-Back 
> User Agent (B2BUA)'
>
> ---
>
>>> 9.2.  Subprotocol Identifier MSRP
>>>
>>>   A reference to this document is added to the subprotocol identifier
>>>   "msrp" in the "WebSocket Subprotocol Name Registry"
>>>
>>> s/this document/RFC/
>
> Will modify as suggested.
>
> ---
>
>>> 11.  CHANGE LOG
>>>
>>> Mark this section for deletion by the RFC Editor
>
> I think the RFC Editor will delete it by default, but we can add explicit 
> text.
>
> Regards,
>
> Christer
>
___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

2020-07-16 Thread Murray S. Kucherawy 
If you email the files to internet-dra...@ietf.org and Cc: me, I'll approve
them and then the secretariat will put the update in the tracker.

-MSK

On Tue, Jul 14, 2020 at 5:39 AM Christer Holmberg <
christer.holmb...@ericsson.com> wrote:

> Hi,
>
> I have created a new version (-22) of the draft, based on Brian's comment..
>
> Murray, as the submission window is currently closed, are you able to
> manually submit the new version if I send you the files?
>
> Regards,
>
> Christer
>
>
>
> -Original Message-
> From: Brian E Carpenter 
> Sent: maanantai 13. heinäkuuta 2020 23.52
> To: Christer Holmberg ; gen-art@ietf.org
> Cc: draft-ietf-mmusic-msrp-usage-data-channel@ietf.org;
> last-c...@ietf.org; mmu...@ietf.org
> Subject: Re: [Gen-art] Genart last call review of
> draft-ietf-mmusic-msrp-usage-data-channel-21
>
> Thanks Christer, that all looks good to me,
>
> Regards
>Brian
>
> On 13-Jul-20 20:58, Christer Holmberg wrote:
> > Hi Brian,
> >
> > Thank You for the review! Please see inline.
> >
> >
> > Nits:
> > -
> >
> >>> 4.1.  MSRP URI
> >>> 
> >>> transport  /= "dc"
> >>>
> >>> I see that RFC7977 takes a slightly different approach to updating the
> ABNF:
> >>>
> >>> transport  =  "tcp" / "ws" / 1*ALPHANUM
> >>>
> >> The advantage of listing out
> >>
> >>  transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
> >>
> >> would be that the reader sees the full list.
> >
> > The MMUSIC WG has previously decided to take the approach of only
> writing the new value, using the "/=" format.
> >
> > ---
> >
> >>>  ; Add "dc" to existing transports per [RFC4975]
> >>>
> >>> I suggest
> >>>
> >>> ; Add "dc" to existing transports per Section 9 of
> [RFC4975]
> >
> > Will modify as suggested.
> >
> > ---
> >
> >>> 4.6.  Session Closing
> >>>
> >>>   The SDP answerer must ensure that no dcmap or dcsa attributes are
> >>>   present in the SDP answer if no corresponding attributes are present
> >>>   in the received SDP offer.
> >>>
> >>> Should that be MUST?
> >
> > The reason for "must" is that is referring to generic data channel SDP
> O/A procedures.
> >
> > I suggest to remove the paragraph.
> >
> > ---
> >
> >>> B2BUA
> >>>
> >>> Define the acronym please.
> >
> > We normally don't do that in MMUSIC specifications. Also, it is on the
> IETF list of well-known acronyms.
> >
> > Having said that, I am fine to enhance it on first occurrence:
> 'Back-to-Back User Agent (B2BUA)'
> >
> > ---
> >
> >>> 9.2.  Subprotocol Identifier MSRP
> >>>
> >>>   A reference to this document is added to the subprotocol identifier
> >>>   "msrp" in the "WebSocket Subprotocol Name Registry"
> >>>
> >>> s/this document/RFC/
> >
> > Will modify as suggested.
> >
> > ---
> >
> >>> 11.  CHANGE LOG
> >>>
> >>> Mark this section for deletion by the RFC Editor
> >
> > I think the RFC Editor will delete it by default, but we can add
> explicit text.
> >
> > Regards,
> >
> > Christer
> >
>
___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

2020-07-14 Thread Christer Holmberg 
Hi,

I have created a new version (-22) of the draft, based on Brian's comment.

Murray, as the submission window is currently closed, are you able to manually 
submit the new version if I send you the files?

Regards,

Christer



-Original Message-
From: Brian E Carpenter  
Sent: maanantai 13. heinäkuuta 2020 23.52
To: Christer Holmberg ; gen-art@ietf.org
Cc: draft-ietf-mmusic-msrp-usage-data-channel@ietf.org; last-c...@ietf.org; 
mmu...@ietf.org
Subject: Re: [Gen-art] Genart last call review of 
draft-ietf-mmusic-msrp-usage-data-channel-21

Thanks Christer, that all looks good to me,

Regards
   Brian

On 13-Jul-20 20:58, Christer Holmberg wrote:
> Hi Brian,
> 
> Thank You for the review! Please see inline.
> 
> 
> Nits:
> -
> 
>>> 4.1.  MSRP URI
>>> 
>>> transport  /= "dc"
>>>
>>> I see that RFC7977 takes a slightly different approach to updating the ABNF:
>>>
>>> transport  =  "tcp" / "ws" / 1*ALPHANUM
>>>
>> The advantage of listing out
>>
>>  transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
>>
>> would be that the reader sees the full list.
> 
> The MMUSIC WG has previously decided to take the approach of only writing the 
> new value, using the "/=" format.
> 
> ---
> 
>>>  ; Add "dc" to existing transports per [RFC4975]
>>>
>>> I suggest
>>>
>>> ; Add "dc" to existing transports per Section 9 of [RFC4975]
> 
> Will modify as suggested.
> 
> ---
> 
>>> 4.6.  Session Closing
>>>
>>>   The SDP answerer must ensure that no dcmap or dcsa attributes are
>>>   present in the SDP answer if no corresponding attributes are present
>>>   in the received SDP offer.
>>>
>>> Should that be MUST?
> 
> The reason for "must" is that is referring to generic data channel SDP O/A 
> procedures.
> 
> I suggest to remove the paragraph.
> 
> ---
> 
>>> B2BUA
>>>
>>> Define the acronym please.
> 
> We normally don't do that in MMUSIC specifications. Also, it is on the IETF 
> list of well-known acronyms.
> 
> Having said that, I am fine to enhance it on first occurrence: 'Back-to-Back 
> User Agent (B2BUA)'
> 
> ---
> 
>>> 9.2.  Subprotocol Identifier MSRP
>>>
>>>   A reference to this document is added to the subprotocol identifier
>>>   "msrp" in the "WebSocket Subprotocol Name Registry"
>>>
>>> s/this document/RFC/
> 
> Will modify as suggested.
> 
> ---
> 
>>> 11.  CHANGE LOG
>>>
>>> Mark this section for deletion by the RFC Editor
> 
> I think the RFC Editor will delete it by default, but we can add explicit 
> text.
> 
> Regards,
> 
> Christer
> 
___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

2020-07-13 Thread Brian E Carpenter 
Thanks Christer, that all looks good to me,

Regards
   Brian

On 13-Jul-20 20:58, Christer Holmberg wrote:
> Hi Brian,
> 
> Thank You for the review! Please see inline.
> 
> 
> Nits:
> -
> 
>>> 4.1.  MSRP URI
>>> 
>>> transport  /= "dc"
>>>
>>> I see that RFC7977 takes a slightly different approach to updating the ABNF:
>>>
>>> transport  =  "tcp" / "ws" / 1*ALPHANUM
>>>
>> The advantage of listing out
>>
>>  transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
>>
>> would be that the reader sees the full list.
> 
> The MMUSIC WG has previously decided to take the approach of only writing the 
> new value, using the "/=" format.
> 
> ---
> 
>>>  ; Add "dc" to existing transports per [RFC4975]
>>>
>>> I suggest
>>>
>>> ; Add "dc" to existing transports per Section 9 of [RFC4975]
> 
> Will modify as suggested.
> 
> ---
> 
>>> 4.6.  Session Closing
>>>
>>>   The SDP answerer must ensure that no dcmap or dcsa attributes are
>>>   present in the SDP answer if no corresponding attributes are present
>>>   in the received SDP offer.
>>>
>>> Should that be MUST?
> 
> The reason for "must" is that is referring to generic data channel SDP O/A 
> procedures.
> 
> I suggest to remove the paragraph.
> 
> ---
> 
>>> B2BUA
>>>
>>> Define the acronym please.
> 
> We normally don't do that in MMUSIC specifications. Also, it is on the IETF 
> list of well-known acronyms.
> 
> Having said that, I am fine to enhance it on first occurrence: 'Back-to-Back 
> User Agent (B2BUA)'
> 
> ---
> 
>>> 9.2.  Subprotocol Identifier MSRP
>>>
>>>   A reference to this document is added to the subprotocol identifier
>>>   "msrp" in the "WebSocket Subprotocol Name Registry"
>>>
>>> s/this document/RFC/
> 
> Will modify as suggested.
> 
> ---
> 
>>> 11.  CHANGE LOG
>>>
>>> Mark this section for deletion by the RFC Editor
> 
> I think the RFC Editor will delete it by default, but we can add explicit 
> text.
> 
> Regards,
> 
> Christer
> 

___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

2020-07-13 Thread Brian E Carpenter 
On 14-Jul-20 02:58, Paul Kyzivat wrote:
> Brian,
> 
> On 7/12/20 6:40 PM, Brian Carpenter via Datatracker wrote:
> 
>> Nits:
>> -
>>
 4.1.  MSRP URI
>> 
  transport  /= "dc"
>>
>> I see that RFC7977 takes a slightly different approach to updating the ABNF:
>>
  transport  =  "tcp" / "ws" / 1*ALPHANUM
>>
>> The advantage of listing out
>>
>>transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
>>
>> would be that the reader sees the full list.
> 
> While it might be nice to see the full list, it can't be counted on to 
> remain the full list. If each update did this, then every draft that 
> updates the list should formally Update every other document that 
> updates the list.
> 
> The *point* of /= in abnf is that it decouples the particular addition 
> from all others.

Sure, I realise that. But...
 
> This sort of thing should really have an IANA registry. But often the 
> expectation is that changes aren't made often enough to justify that. 

Indeed, that occurred to me as an alternative approach but a registry
with 3 entries is a bit light (and also, readers starting at RFC4975
wouldn't know to look for the registry).

> Lacking that, IMO /= is the preferred way to go.

It was only a nit...

Brian

> 
>   Just kibitzing,
>   Paul
> 
> 
> 

___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

2020-07-13 Thread Paul Kyzivat 

Brian,

On 7/12/20 6:40 PM, Brian Carpenter via Datatracker wrote:


Nits:
-


4.1.  MSRP URI



 transport  /= "dc"


I see that RFC7977 takes a slightly different approach to updating the ABNF:


 transport  =  "tcp" / "ws" / 1*ALPHANUM


The advantage of listing out

   transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM

would be that the reader sees the full list.


While it might be nice to see the full list, it can't be counted on to 
remain the full list. If each update did this, then every draft that 
updates the list should formally Update every other document that 
updates the list.


The *point* of /= in abnf is that it decouples the particular addition 
from all others.


This sort of thing should really have an IANA registry. But often the 
expectation is that changes aren't made often enough to justify that. 
Lacking that, IMO /= is the preferred way to go.


Just kibitzing,
Paul


___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

Re: [Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

2020-07-13 Thread Christer Holmberg 
Hi Brian,

Thank You for the review! Please see inline.


Nits:
-

>> 4.1.  MSRP URI
>> 
>> transport  /= "dc"
>>
>> I see that RFC7977 takes a slightly different approach to updating the ABNF:
>>
>> transport  =  "tcp" / "ws" / 1*ALPHANUM
>>
> The advantage of listing out
>
>  transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM
>
> would be that the reader sees the full list.

The MMUSIC WG has previously decided to take the approach of only writing the 
new value, using the "/=" format.

---

>>  ; Add "dc" to existing transports per [RFC4975]
>>
>>I suggest
>>
>> ; Add "dc" to existing transports per Section 9 of [RFC4975]

Will modify as suggested.

---

>>4.6.  Session Closing
>>
>>   The SDP answerer must ensure that no dcmap or dcsa attributes are
>>   present in the SDP answer if no corresponding attributes are present
>>   in the received SDP offer.
>>
>> Should that be MUST?

The reason for "must" is that is referring to generic data channel SDP O/A 
procedures.

I suggest to remove the paragraph.

---

>> B2BUA
>>
>> Define the acronym please.

We normally don't do that in MMUSIC specifications. Also, it is on the IETF 
list of well-known acronyms.

Having said that, I am fine to enhance it on first occurrence: 'Back-to-Back 
User Agent (B2BUA)'

---

>> 9.2.  Subprotocol Identifier MSRP
>>
>>   A reference to this document is added to the subprotocol identifier
>>   "msrp" in the "WebSocket Subprotocol Name Registry"
>>
>> s/this document/RFC/

Will modify as suggested.

---

>> 11.  CHANGE LOG
>>
>> Mark this section for deletion by the RFC Editor

I think the RFC Editor will delete it by default, but we can add explicit text.

Regards,

Christer

___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art

[Gen-art] Genart last call review of draft-ietf-mmusic-msrp-usage-data-channel-21

2020-07-12 Thread Brian Carpenter via Datatracker 
Reviewer: Brian Carpenter
Review result: Ready with Nits

Gen-ART Last Call review of draft-ietf-mmusic-msrp-usage-data-channel-21

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at
.

Document: draft-ietf-mmusic-msrp-usage-data-channel-21
Reviewer: Brian Carpenter
Review Date: 2020-07-13
IETF LC End Date: 2020-07-21
IESG Telechat date:  

Summary: Ready with nits


Nits:
-

>> 4.1.  MSRP URI

>> transport  /= "dc"

I see that RFC7977 takes a slightly different approach to updating the ABNF:

>> transport  =  "tcp" / "ws" / 1*ALPHANUM

The advantage of listing out

  transport  =  "tcp" / "ws" / "dc" / 1*ALPHANUM

would be that the reader sees the full list.

>>  ; Add "dc" to existing transports per [RFC4975]

I suggest

 ; Add "dc" to existing transports per Section 9 of [RFC4975]

>>4.6.  Session Closing

>>   The SDP answerer must ensure that no dcmap or dcsa attributes are
>>   present in the SDP answer if no corresponding attributes are present
>>   in the received SDP offer.

Should that be MUST?

>> B2BUA

Define the acronym please.

>> 9.2.  Subprotocol Identifier MSRP
>>
>>   A reference to this document is added to the subprotocol identifier
>>   "msrp" in the "WebSocket Subprotocol Name Registry"

s/this document/RFC/

>> 11.  CHANGE LOG

Mark this section for deletion by the RFC Editor



___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art