Re: [Gen-art] Genart last call review of draft-ietf-calext-valarm-extensions-04

2021-02-24 Thread Alissa Cooper
Roni, thanks for your review. Ken, thanks for addressing Roni’s comments. I 
entered a No Objection ballot.

Alissa


> On Feb 17, 2021, at 12:07 AM, Roni Even  wrote:
> 
> Hi Ken,
> Thanks, it is OK 
> Roni
> 
>> -Original Message-
>> From: Ken Murchison [mailto:mu...@fastmail.com]
>> Sent: Monday, February 15, 2021 2:27 PM
>> To: Roni Even; gen-art@ietf.org
>> Cc: cals...@ietf.org; draft-ietf-calext-valarm-extensions@ietf.org; last-
>> c...@ietf.org
>> Subject: Re: Genart last call review of 
>> draft-ietf-calext-valarm-extensions-04
>> 
>> Hi Roni,
>> 
>> Thanks for the review.  Your comment is addressed below.
>> 
>> 
>> On 2/15/21 5:32 AM, Roni Even via Datatracker wrote:
>>> Reviewer: Roni Even
>>> Review result: Ready with Nits
>>> 
>>> I am the assigned Gen-ART reviewer for this draft. The General Area
>>> Review Team (Gen-ART) reviews all IETF documents being processed by
>>> the IESG for the IETF Chair.  Please treat these comments just like
>>> any other last call comments.
>>> 
>>> For more information, please see the FAQ at
>>> 
>>> .
>>> 
>>> Document: draft-ietf-calext-valarm-extensions-??
>>> Reviewer: Roni Even
>>> Review Date: 2021-02-15
>>> IETF LC End Date: 2021-02-16
>>> IESG Telechat date: Not scheduled for a telechat
>>> 
>>> Summary:
>>> The document is ready for publication as standard track RFC with nits
>>> 
>>> Major issues:
>>> 
>>> Minor issues:
>>> 
>>> Nits/editorial comments:
>>> 
>>> 1. The structured-location is optional so if it is not specified for
>>> proximity I assume that it implies current location?
>> 
>> 
>> STRUCTURED-LOCATION is optional because its not used for PROXIMITY:
>> [DIS]CONNECT.  I've made the following change to the text:
>> 
>>  This property is used to
>>  indicate that an alarm has a location-based trigger. Its
>>  value identifies the direction of motion used to trigger
>> -the alarm. One or more location values are set using
>> +the alarm. One or more location values MUST be set using
>>  "STRUCTURED-LOCATION" properties.
>> 
>> Is this sufficient?
>> 
>> --
>> Kenneth Murchison
>> Senior Software Developer
>> Fastmail US LLC
> 
> ___
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art

___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art


Re: [Gen-art] Genart last call review of draft-ietf-calext-valarm-extensions-04

2021-02-16 Thread Roni Even
Hi Ken,
Thanks, it is OK 
Roni

> -Original Message-
> From: Ken Murchison [mailto:mu...@fastmail.com]
> Sent: Monday, February 15, 2021 2:27 PM
> To: Roni Even; gen-art@ietf.org
> Cc: cals...@ietf.org; draft-ietf-calext-valarm-extensions@ietf.org; last-
> c...@ietf.org
> Subject: Re: Genart last call review of draft-ietf-calext-valarm-extensions-04
> 
> Hi Roni,
> 
> Thanks for the review.  Your comment is addressed below.
> 
> 
> On 2/15/21 5:32 AM, Roni Even via Datatracker wrote:
> > Reviewer: Roni Even
> > Review result: Ready with Nits
> >
> > I am the assigned Gen-ART reviewer for this draft. The General Area
> > Review Team (Gen-ART) reviews all IETF documents being processed by
> > the IESG for the IETF Chair.  Please treat these comments just like
> > any other last call comments.
> >
> > For more information, please see the FAQ at
> >
> > .
> >
> > Document: draft-ietf-calext-valarm-extensions-??
> > Reviewer: Roni Even
> > Review Date: 2021-02-15
> > IETF LC End Date: 2021-02-16
> > IESG Telechat date: Not scheduled for a telechat
> >
> > Summary:
> > The document is ready for publication as standard track RFC with nits
> >
> > Major issues:
> >
> > Minor issues:
> >
> > Nits/editorial comments:
> >
> > 1. The structured-location is optional so if it is not specified for
> > proximity I assume that it implies current location?
> 
> 
> STRUCTURED-LOCATION is optional because its not used for PROXIMITY:
> [DIS]CONNECT.  I've made the following change to the text:
> 
>   This property is used to
>   indicate that an alarm has a location-based trigger. Its
>   value identifies the direction of motion used to trigger
> -the alarm. One or more location values are set using
> +the alarm. One or more location values MUST be set using
>   "STRUCTURED-LOCATION" properties.
> 
> Is this sufficient?
> 
> --
> Kenneth Murchison
> Senior Software Developer
> Fastmail US LLC

___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art


Re: [Gen-art] Genart last call review of draft-ietf-calext-valarm-extensions-04

2021-02-15 Thread Ken Murchison

Hi Roni,

Thanks for the review.  Your comment is addressed below.


On 2/15/21 5:32 AM, Roni Even via Datatracker wrote:

Reviewer: Roni Even
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

.

Document: draft-ietf-calext-valarm-extensions-??
Reviewer: Roni Even
Review Date: 2021-02-15
IETF LC End Date: 2021-02-16
IESG Telechat date: Not scheduled for a telechat

Summary:
The document is ready for publication as standard track RFC with nits

Major issues:

Minor issues:

Nits/editorial comments:

1. The structured-location is optional so if it is not specified for proximity
I assume that it implies current location?



STRUCTURED-LOCATION is optional because its not used for PROXIMITY: 
[DIS]CONNECT.  I've made the following change to the text:


 This property is used to
 indicate that an alarm has a location-based trigger. Its
 value identifies the direction of motion used to trigger
-    the alarm. One or more location values are set using
+    the alarm. One or more location values MUST be set using
 "STRUCTURED-LOCATION" properties.

Is this sufficient?

--
Kenneth Murchison
Senior Software Developer
Fastmail US LLC

___
Gen-art mailing list
Gen-art@ietf.org
https://www.ietf.org/mailman/listinfo/gen-art