Hi kezhenxu,
Thanks for checking.
The license headers for the test resources have been excluded from the very
early days [1] of the project and also for the past releases. I guess it's
due to the low level of creativity per the ASF guideline [2]. And similarly
for the docs/Makefile [3]. Do you think this is a release blocker?
I think we could take some actions to clean up certain things or revisit
the exclusion rules in the next release. But given the current situation,
it'll be great to keep the current release and thereby make it less
confusing to the Pinot community. What do you think?
Thanks,
[1] https://github.com/apache/incubator-pinot/blame/master/pom.xml#L1564
[2] https://www.apache.org/legal/src-headers.html#faq-exceptions
[3] https://github.com/apache/incubator-pinot/blame/master/pom.xml#L1548
On Mon, Mar 22, 2021 at 8:13 PM kezhenxu94@apache
wrote:
> Hey, I found some of the files lack the license headers,
> though some of which are for testing only, but since you have
> included them in the source tar, it’d be better to have license headers
> for them.
>
> pinot-clients/pinot-jdbc-client/src/main/resources/java.sql.Driver
>
> pinot-connectors/pinot-spark-connector/src/main/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister
> pinot-core/src/test/resources/conf/pinot-broker.properties
> pinot-core/src/test/resources/conf/query-executor.properties
> pinot-core/src/test/resources/generate-test-data.py
> pinot-integration-tests/src/test/resources/compat-tests/kafka/topic1.cfg
> pinot-integration-tests/src/test/resources/index.html
> pinot-tools/src/main/resources/conf/sample_filesystem_benchmark.conf
>
>
> Also, I found that this file `docs/Makefile` originated from 3-rd party
> [1] and
> is modified in the release, but not mentioned in the LICENSE file.
>
> [1]
> https://github.com/apache/incubator-pinot/blob/release-0.7.0-rc/LICENSE
>
>
> > On Mar 23, 2021, at 00:25, Yupeng Fu wrote:
> >
> > Felix and others,
> >
> > The git hash on the git tag is now the same as the one sent out in the
> > vote. Please check again
> > https://github.com/apache/incubator-pinot/commits/release-0.7.0
> >
> > Sorry for the inconvenience and thanks for checking.
> >
> > Best,
> >
> > On Fri, Mar 19, 2021 at 3:45 PM Felix Cheung
> wrote:
> >
> >> For some reason the git hash has changed in release git tag
> >>
> >> https://github.com/apache/incubator-pinot/commits/release-0.7.0
> >>
> >>
> >>
> https://github.com/apache/incubator-pinot/commit/de0236c25727ffc2408c5bf55836bbfecf40499c
> >>
> >>
> >>
> >>
> >> On Fri, Mar 19, 2021 at 11:00 AM kishore g wrote:
> >>
> >>> Jim/Felix and others
> >>>
> >>> Do we have your +1 to go ahead with the release.
> >>>
> >>> Thanks
> >>> Kishore G
> >>>
> >>> On Thu, Mar 18, 2021 at 9:32 PM kishore g wrote:
> >>>
> That would be great. We will update the release runbook to make sure
> >> this
> doesn't happen again.
>
> Here is my +1
>
>
>
> On Thu, Mar 18, 2021 at 11:03 AM Jim Jagielski
> >> wrote:
>
> > I propose that we run the vote anyway, thus ensuring IPMC oversight
> >> and
> > (post)approval, and then update the release runbook to make sure this
> > doesn't happen again. Make sense?
> >
> >> On Mar 17, 2021, at 11:35 PM, Felix Cheung
> > wrote:
> >>
> >> It is unclear the guidance on this but since it is impossible remove
> > from
> >> maven
> >>
> >> https://repository.apache.org/#nexus-search;classname~Pinot
> >>
> >> Once it is published, I’d suggest we update all the links and git
> >> hash
> > and
> >> still proceed to vote on this. If there is any issue we should vote
> >> on
> >> another release with fix ASAP. Otherwise hopefully IPMC can continue
> >>> to
> >> sign off on this release.
> >>
> >>
> >>
> >> On Wed, Mar 17, 2021 at 3:09 PM kishore g
> >>> wrote:
> >>
> >>> Apologies for the mistake. We have done multiple releases until now
> >>> and
> >>> this is the first time we missed the step to get the approval from
> > IPMC was
> >>> missed before making the release.
> >>>
> >>> What is the right thing to do at this point? Should we cut another
> > release
> >>> or can we go ahead with this and ensure that this does not happen
> > again.
> >>>
> >>> thanks,
> >>> Kishore G
> >>>
> >>> On Wed, Mar 17, 2021 at 10:59 AM Felix Cheung <
> >>> felixche...@apache.org>
> >>> wrote:
> >>>
> Unfortunately this isn’t the right process for a podling release.
>
> As the mentor, I am sorry to see the release is not up to the
> >>> standard
> upheld by previous releases.
>
>
> On Wed, Mar 17, 2021 at 7:02 AM kezhenxu94@apache <
> > kezhenx...@apache.org
>
> wrote:
>
> > I think this release violates the Apache release policy because
> >> it
> >
