Re: [VOTE] Release Apache Kyuubi(Incubating) v1.3.1-incubating RC0
+1 (binding) I quickly checked: - version contains incubating - LICENSE, NOTICE, DISCLAIMER files are there and look good - signatures looks good - ASF headers are present in source files, and source compile - No binary files found in source distribution Thanks, Regards JB On 20/10/2021 09:34, Kent Yao wrote: +1(non-binding), carried from dev@k.a.o XiDuo You 于2021年10月19日周二 下午8:23写道： starting with my +1 XiDuo You 于2021年10月19日周二 下午3:48写道： Hello Incubator Community, The Apache Kyuubi community has voted on and approved a proposal to release Apache Kyuubi(Incubating) version v1.3.1-incubating RC0. We now kindly request the Incubator PMC members review and vote on this incubator release. Kyuubi community vote thread: https://www.mail-archive.com/dev@kyuubi.apache.org/msg01139.html Kyuubi community vote result thread: https://www.mail-archive.com/dev@kyuubi.apache.org/msg01156.html [ ] +1 Release this package as Apache Kyuubi v1.3.0-incubating [ ] +0 [ ] -1 Do not release this package because ... To learn more about Apache Kyuubi (Incubating), please see https://kyuubi.apache.org/ The tag to be voted on is v1.3.1-incubating-rc0 (commit ff9bab6): https://github.com/apache/incubator-kyuubi/tree/v1.3.1-incubating-rc0 The release files, including signatures, digests, etc. can be found at: https://dist.apache.org/repos/dist/dev/incubator/kyuubi/v1.3.1-incubating-rc0/ Signatures used for Kyuubi RCs can be found in this file: https://dist.apache.org/repos/dist/dev/incubator/kyuubi/KEYS The staging repository for this release can be found at: https://repository.apache.org/content/repositories/orgapachekyuubi-1012/ The commit list since the RC0: https://github.com/apache/incubator-kyuubi/compare/v1.3.0-incubating...v1.3.1-incubating-rc0 Thanks, Xiduo You - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache ShenYu (incubating) 2.4.1
Hi +1 (binding) I checked: - incubating in name - signatures and hashes are fine - disclaimer exists - notice and license look good - all source files have ASF header - no unexpected binary files - can compile from source I’m not 100% sure but there might be some 3rd party code in the release not mentioned in LICENSE. There a copyright 2018 mentioned here [1] and possibly some react code here [2] and elsewhere? Kind Regards, Justin 1. ./shenyu-dashboard/src/layouts/UserLayout.js 2. ./shenyu-dashboard/src/components/GlobalFooter/index.md - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache ShenYu (incubating) 2.4.1
On Thu, 21 Oct 2021 at 06:10, Zhang Yonglun wrote: > > Hi Sebb, > > Thanks for the kind reminder. > > > It would be better to link to the canonical KEYS file at: > > https://downloads.apache.org/incubator/shenyu/KEYS > > as that is what downloaders need to use. > > I agree with you. It's true that the downloaders need to use the canonical > KEYS from [1]. > For now, the KEKS is temporarily saved in [2] for the vote process. Why? You are not voting on the KEYS. > When the VOTE is successful, we will move the KEYS file to the release > directory [3] and then automatically sync it to [1] . > You can find the right link in the download page [4] . Note that the KEYS file must contain the keys for ALL historic releases, so it can be used to validate archived versions. So keys should only be added to the file, never removed (except perhaps if a key was revoked). This is probably easier to do if the KEYS file is maintained under the dist/release directory, and not present under dist/dev > > [1] https://downloads.apache.org/incubator/shenyu/KEYS > [2] https://dist.apache.org/repos/dist/dev/incubator/shenyu/KEYS > [3] https://dist.apache.org/repos/dist/release/incubator/shenyu/ > [4] https://shenyu.apache.org/download/ > > > -- > > Zhang Yonglun > Apache ShenYu (Incubating) > Apache ShardingSphere > > > sebb 于2021年10月20日周三 下午8:54写道： > > > On Wed, 20 Oct 2021 at 12:46, XiaoYu wrote: > > > > > > Hello Incubator Community, > > > > > > This is a call for vote to release Apache ShenYu (incubating) version > > 2.4.1 > > > > > > The Apache ShenYu community has voted on and approved a proposal to > > release > > > Apache ShenYu (incubating) version 2.4.1. > > > > > > We now kindly request the Incubator PMC members review and vote on this > > > incubator release. > > > > > > ShenYu community vote thread: > > > > > https://lists.apache.org/thread.html/rfd9fae5be635f8c3f6307400040542f39585dadc7920a02f6c97c0ee%40%3Cdev.shenyu.apache.org%3E > > > > > > Vote result thread: > > > > > https://lists.apache.org/thread.html/r088e47f7d25d8c05725b42b77cc569d3145a6a73b3eb80072c4ab431%40%3Cdev.shenyu.apache.org%3E > > > > > > Release notes: > > > https://github.com/apache/incubator-shenyu/blob/master/RELEASE-NOTES.md > > > > > > The release candidates: > > > https://dist.apache.org/repos/dist/dev/incubator/shenyu/2.4.1/ > > > > > > Maven 2 staging repository: > > > > > https://repository.apache.org/content/repositories/orgapacheshenyu-1014/org/apache/shenyu/ > > > > > > Git tag for the release: > > > https://github.com/apache/incubator-shenyu/tree/v2.4.1/ > > > > > > Release Commit ID: > > > > > https://github.com/apache/incubator-shenyu/commit/3c6e3a0a3134e59dc200cd68c85576d5bafc2f3b > > > > > > Keys to verify the Release Candidate: > > > https://dist.apache.org/repos/dist/dev/incubator/shenyu/KEYS > > > > It would be better to link to the canonical KEYS file at: > > https://downloads.apache.org/incubator/shenyu/KEYS > > as that is what downloaders need to use. > > > > > > > > Look at here for how to verify this release candidate: > > > https://shenyu.apache.org/community/release-guide/#check-release > > > > > > GPG user ID: > > > xiaoyu > > > > > > The vote will be open for at least 72 hours or until the necessary number > > > of votes are reached. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove with the reason > > > > > > Checklist for reference: > > > > > > [ ] Download links are valid. > > > > > > [ ] Checksums and PGP signatures are valid. > > > > > > [ ] Source code distributions have correct names matching the current > > > release. > > > > > > [ ] LICENSE and NOTICE files are correct for each ShenYu repo. > > > > > > [ ] All files have license headers if necessary. > > > > > > [ ] No compiled archives bundled in source archive. > > > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Kyuubi(Incubating) v1.3.1-incubating RC0
On Tue, 19 Oct 2021 at 08:49, XiDuo You wrote: > > Hello Incubator Community, > > The Apache Kyuubi community has voted on and approved a proposal to release > Apache Kyuubi(Incubating) version v1.3.1-incubating RC0. > > We now kindly request the Incubator PMC members review and vote on this > incubator release. > > Kyuubi community vote thread: > https://www.mail-archive.com/dev@kyuubi.apache.org/msg01139.html > > Kyuubi community vote result thread: > https://www.mail-archive.com/dev@kyuubi.apache.org/msg01156.html > > [ ] +1 Release this package as Apache Kyuubi v1.3.0-incubating > [ ] +0 > [ ] -1 Do not release this package because ... > > To learn more about Apache Kyuubi (Incubating), please see > https://kyuubi.apache.org/ > > The tag to be voted on is v1.3.1-incubating-rc0 (commit ff9bab6): > https://github.com/apache/incubator-kyuubi/tree/v1.3.1-incubating-rc0 > > The release files, including signatures, digests, etc. can be found at: > https://dist.apache.org/repos/dist/dev/incubator/kyuubi/v1.3.1-incubating-rc0/ > > Signatures used for Kyuubi RCs can be found in this file: > https://dist.apache.org/repos/dist/dev/incubator/kyuubi/KEYS Please see comments on Shenyu release vote regarding the location of the KEYS file https://lists.apache.org/thread.html/rb2c64e0e640db116747c84a0a69457bc5ab9e8fb7130030e17e1a175%40%3Cgeneral.incubator.apache.org%3E > The staging repository for this release can be found at: > https://repository.apache.org/content/repositories/orgapachekyuubi-1012/ > > The commit list since the RC0: > https://github.com/apache/incubator-kyuubi/compare/v1.3.0-incubating...v1.3.1-incubating-rc0 > > Thanks, > Xiduo You - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache ShenYu (incubating) 2.4.1
Hi Justin, Thanks for your check. > I’m not 100% sure but there might be some 3rd party code in the release not mentioned in LICENSE. There a copyright 2018 mentioned here [1] The copyright word mentioned in this file that is planned to be used to display the copyright information in the front end page. This file does not contain 3rd party codes and were developed under Apache 2.0 license. > and possibly some react code here [2] and elsewhere? Yes you are right. There are 3rd party codes in this file. We may have missed this check. -- Zhang Yonglun Apache ShenYu (Incubating) Apache ShardingSphere Justin Mclean 于2021年10月21日周四 下午4:42写道： > Hi > > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes are fine > - disclaimer exists > - notice and license look good > - all source files have ASF header > - no unexpected binary files > - can compile from source > > I’m not 100% sure but there might be some 3rd party code in the release > not mentioned in LICENSE. There a copyright 2018 mentioned here [1] and > possibly some react code here [2] and elsewhere? > > Kind Regards, > Justin > > 1. ./shenyu-dashboard/src/layouts/UserLayout.js > 2. ./shenyu-dashboard/src/components/GlobalFooter/index.md > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Kyuubi(Incubating) v1.3.1-incubating RC0
Hi Sebb, Thank you for the reminder. Kyuubi's KEYS now can be found at Kyuubi download page [1] and the download link is [2]. For now, the KEYS file is saved at dev directory [3] for the vote process and we will move KEYS file to the release directory [4] after the VOTE pass. [1] https://kyuubi.apache.org/releases.html [2] https://downloads.apache.org/incubator/kyuubi/KEYS [3] https://dist.apache.org/repos/dist/dev/incubator/kyuubi/KEYS [4] https://dist.apache.org/repos/dist/release/incubator/kyuubi/KEYS thanks Xiduo sebb 于2021年10月21日周四 下午5:58写道： > On Tue, 19 Oct 2021 at 08:49, XiDuo You wrote: > > > > Hello Incubator Community, > > > > The Apache Kyuubi community has voted on and approved a proposal to > release > > Apache Kyuubi(Incubating) version v1.3.1-incubating RC0. > > > > We now kindly request the Incubator PMC members review and vote on this > > incubator release. > > > > Kyuubi community vote thread: > > https://www.mail-archive.com/dev@kyuubi.apache.org/msg01139.html > > > > Kyuubi community vote result thread: > > https://www.mail-archive.com/dev@kyuubi.apache.org/msg01156.html > > > > [ ] +1 Release this package as Apache Kyuubi v1.3.0-incubating > > [ ] +0 > > [ ] -1 Do not release this package because ... > > > > To learn more about Apache Kyuubi (Incubating), please see > > https://kyuubi.apache.org/ > > > > The tag to be voted on is v1.3.1-incubating-rc0 (commit ff9bab6): > > https://github.com/apache/incubator-kyuubi/tree/v1.3.1-incubating-rc0 > > > > The release files, including signatures, digests, etc. can be found at: > > > https://dist.apache.org/repos/dist/dev/incubator/kyuubi/v1.3.1-incubating-rc0/ > > > > Signatures used for Kyuubi RCs can be found in this file: > > https://dist.apache.org/repos/dist/dev/incubator/kyuubi/KEYS > > Please see comments on Shenyu release vote regarding the location of > the KEYS file > > > https://lists.apache.org/thread.html/rb2c64e0e640db116747c84a0a69457bc5ab9e8fb7130030e17e1a175%40%3Cgeneral.incubator.apache.org%3E > > > The staging repository for this release can be found at: > > https://repository.apache.org/content/repositories/orgapachekyuubi-1012/ > > > > The commit list since the RC0: > > > https://github.com/apache/incubator-kyuubi/compare/v1.3.0-incubating...v1.3.1-incubating-rc0 > > > > Thanks, > > Xiduo You > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache ShenYu (incubating) 2.4.1
Just forwarding my dev +1 here. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Wed, Oct 20, 2021 at 7:46 PM XiaoYu wrote: > > Hello Incubator Community, > > This is a call for vote to release Apache ShenYu (incubating) version 2.4.1 > > The Apache ShenYu community has voted on and approved a proposal to release > Apache ShenYu (incubating) version 2.4.1. > > We now kindly request the Incubator PMC members review and vote on this > incubator release. > > ShenYu community vote thread: > https://lists.apache.org/thread.html/rfd9fae5be635f8c3f6307400040542f39585dadc7920a02f6c97c0ee%40%3Cdev.shenyu.apache.org%3E > > Vote result thread: > https://lists.apache.org/thread.html/r088e47f7d25d8c05725b42b77cc569d3145a6a73b3eb80072c4ab431%40%3Cdev.shenyu.apache.org%3E > > Release notes: > https://github.com/apache/incubator-shenyu/blob/master/RELEASE-NOTES.md > > The release candidates: > https://dist.apache.org/repos/dist/dev/incubator/shenyu/2.4.1/ > > Maven 2 staging repository: > https://repository.apache.org/content/repositories/orgapacheshenyu-1014/org/apache/shenyu/ > > Git tag for the release: > https://github.com/apache/incubator-shenyu/tree/v2.4.1/ > > Release Commit ID: > https://github.com/apache/incubator-shenyu/commit/3c6e3a0a3134e59dc200cd68c85576d5bafc2f3b > > Keys to verify the Release Candidate: > https://dist.apache.org/repos/dist/dev/incubator/shenyu/KEYS > > Look at here for how to verify this release candidate: > https://shenyu.apache.org/community/release-guide/#check-release > > GPG user ID: > xiaoyu > > The vote will be open for at least 72 hours or until the necessary number > of votes are reached. > > Please vote accordingly: > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > Checklist for reference: > > [ ] Download links are valid. > > [ ] Checksums and PGP signatures are valid. > > [ ] Source code distributions have correct names matching the current > release. > > [ ] LICENSE and NOTICE files are correct for each ShenYu repo. > > [ ] All files have license headers if necessary. > > [ ] No compiled archives bundled in source archive. - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Kyuubi(Incubating) v1.3.1-incubating RC0
Hi Justin, One further question, as we already have such declarations in our NOTICE file, does it mean we can eliminate other declarations if we use code from Apache TLPs? > This product includes software developed at > The Apache Software Foundation (https://www.apache.org/). Thanks, Cheng Pan On Thu, Oct 21, 2021 at 8:09 PM XiDuo You wrote: > Hi Sebb, > > Thank you for the reminder. > > Kyuubi's KEYS now can be found at Kyuubi download page [1] and the > download link is [2]. > For now, the KEYS file is saved at dev directory [3] for the vote process > and we will move > KEYS file to the release directory [4] after the VOTE pass. > > [1] https://kyuubi.apache.org/releases.html > [2] https://downloads.apache.org/incubator/kyuubi/KEYS > [3] https://dist.apache.org/repos/dist/dev/incubator/kyuubi/KEYS > [4] https://dist.apache.org/repos/dist/release/incubator/kyuubi/KEYS > > thanks > Xiduo > > sebb 于2021年10月21日周四 下午5:58写道： > > > On Tue, 19 Oct 2021 at 08:49, XiDuo You wrote: > > > > > > Hello Incubator Community, > > > > > > The Apache Kyuubi community has voted on and approved a proposal to > > release > > > Apache Kyuubi(Incubating) version v1.3.1-incubating RC0. > > > > > > We now kindly request the Incubator PMC members review and vote on this > > > incubator release. > > > > > > Kyuubi community vote thread: > > > https://www.mail-archive.com/dev@kyuubi.apache.org/msg01139.html > > > > > > Kyuubi community vote result thread: > > > https://www.mail-archive.com/dev@kyuubi.apache.org/msg01156.html > > > > > > [ ] +1 Release this package as Apache Kyuubi v1.3.0-incubating > > > [ ] +0 > > > [ ] -1 Do not release this package because ... > > > > > > To learn more about Apache Kyuubi (Incubating), please see > > > https://kyuubi.apache.org/ > > > > > > The tag to be voted on is v1.3.1-incubating-rc0 (commit ff9bab6): > > > https://github.com/apache/incubator-kyuubi/tree/v1.3.1-incubating-rc0 > > > > > > The release files, including signatures, digests, etc. can be found at: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/kyuubi/v1.3.1-incubating-rc0/ > > > > > > Signatures used for Kyuubi RCs can be found in this file: > > > https://dist.apache.org/repos/dist/dev/incubator/kyuubi/KEYS > > > > Please see comments on Shenyu release vote regarding the location of > > the KEYS file > > > > > > > https://lists.apache.org/thread.html/rb2c64e0e640db116747c84a0a69457bc5ab9e8fb7130030e17e1a175%40%3Cgeneral.incubator.apache.org%3E > > > > > The staging repository for this release can be found at: > > > > https://repository.apache.org/content/repositories/orgapachekyuubi-1012/ > > > > > > The commit list since the RC0: > > > > > > https://github.com/apache/incubator-kyuubi/compare/v1.3.0-incubating...v1.3.1-incubating-rc0 > > > > > > Thanks, > > > Xiduo You > > > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
Re: [VOTE] Release Apache Kyuubi(Incubating) v1.3.1-incubating RC0
Hi, > One further question, as we already have such declarations in our NOTICE > file, > does it mean we can eliminate other declarations if we use code from Apache > TLPs? > >> This product includes software developed at >> The Apache Software Foundation (https://www.apache.org/). Yes you inly ned to mention that once. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Kyuubi(Incubating) v1.3.1-incubating RC0
Hi, Sorry to clarify. You only need to mention than once. Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Kyuubi(Incubating) v1.3.1-incubating RC0
Got it, thanks for the clarification. Thanks, Cheng Pan On Fri, Oct 22, 2021 at 1:01 PM wrote: > Hi, > > Sorry to clarify. > > You only need to mention than once. > > Justin > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache ShenYu (incubating) 2.4.1
+1 (binding) from me, I have checked the following items: - Incubating in name - LICENSE and NOTICE are fine - DISCLAIMER exists - All links are valid - No unexpected binary files - All ASF files have ASF headers - Can compile from source - Checksums and PGP signatures are valid. Best regards Xun Liu On Fri, Oct 22, 2021 at 8:06 AM Willem Jiang wrote: > Just forwarding my dev +1 here. > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Wed, Oct 20, 2021 at 7:46 PM XiaoYu wrote: > > > > Hello Incubator Community, > > > > This is a call for vote to release Apache ShenYu (incubating) version > 2.4.1 > > > > The Apache ShenYu community has voted on and approved a proposal to > release > > Apache ShenYu (incubating) version 2.4.1. > > > > We now kindly request the Incubator PMC members review and vote on this > > incubator release. > > > > ShenYu community vote thread: > > > https://lists.apache.org/thread.html/rfd9fae5be635f8c3f6307400040542f39585dadc7920a02f6c97c0ee%40%3Cdev.shenyu.apache.org%3E > > > > Vote result thread: > > > https://lists.apache.org/thread.html/r088e47f7d25d8c05725b42b77cc569d3145a6a73b3eb80072c4ab431%40%3Cdev.shenyu.apache.org%3E > > > > Release notes: > > https://github.com/apache/incubator-shenyu/blob/master/RELEASE-NOTES.md > > > > The release candidates: > > https://dist.apache.org/repos/dist/dev/incubator/shenyu/2.4.1/ > > > > Maven 2 staging repository: > > > https://repository.apache.org/content/repositories/orgapacheshenyu-1014/org/apache/shenyu/ > > > > Git tag for the release: > > https://github.com/apache/incubator-shenyu/tree/v2.4.1/ > > > > Release Commit ID: > > > https://github.com/apache/incubator-shenyu/commit/3c6e3a0a3134e59dc200cd68c85576d5bafc2f3b > > > > Keys to verify the Release Candidate: > > https://dist.apache.org/repos/dist/dev/incubator/shenyu/KEYS > > > > Look at here for how to verify this release candidate: > > https://shenyu.apache.org/community/release-guide/#check-release > > > > GPG user ID: > > xiaoyu > > > > The vote will be open for at least 72 hours or until the necessary number > > of votes are reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > Checklist for reference: > > > > [ ] Download links are valid. > > > > [ ] Checksums and PGP signatures are valid. > > > > [ ] Source code distributions have correct names matching the current > > release. > > > > [ ] LICENSE and NOTICE files are correct for each ShenYu repo. > > > > [ ] All files have license headers if necessary. > > > > [ ] No compiled archives bundled in source archive. > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
