Re: [VOTE] Release Apache EventMesh (incubating) 1.8.0-rc2
Hi Gang Li, Thanks for your vote, we will fix the issues you raised. li gang 于2023年1月28日周六 23:41写道： > > +1 (binding) > I checked > - All files have license header if necessary. > - LICENSE and NOTICE files exist > - Include the word incubating in the release file name. > - DISCLAIMER-WIP file exist > - Signatures are fine > > Three are two issues need to be fixed next release. > 1、There are a lot of duplicated line of "This product includes software > developed at the Apache Software Foundation...",need to clean up those > lines[1]. > 2、The license [2] is triple-licensed and you should select which license > applies. > > [1]https://infra.apache.org/licensing-howto.html#bundle-asf-product > [2]src/tools/third-party-licenses/licenses/java/LICENSE-amqp-client.txt > > walterzywei 于2023年1月18日周三 20:23写道： > > > Hello Incubator Community, > > > > This is a call for a vote to release Apache EventMesh(Incubating) > > version 1.8.0-rc2 > > > > The Apache EventMesh community has voted on and approved a > > proposal to release > > Apache EventMesh(Incubating) version 1.8.0-rc2 > > > > We now kindly request the Incubator PMC members review and vote on this > > incubator release. > > > > EventMesh community vote thread: > > • https://lists.apache.org/thread/z6p2kxw2l1zv641fsx4bhjgtmdh4xwyg > > > > Vote result thread: > > • https://lists.apache.org/thread/16js8nnlbypy203snxk2fqzt3vjz1yg5 > > > > The release candidate: > > • https://dist.apache.org/repos/dist/dev/incubator/eventmesh/1.8.0-rc2 > > > > Git tag for the release: > > • https://github.com/apache/incubator-eventmesh/tree/v1.8.0-rc2 > > Release notes: > > • https://eventmesh.apache.org/events/release-notes/v1.8.0 > > > > The artifacts signed with PGP key > > 16D5190EA34AC32AE3CE05A753FF44C181774D3F, corresponding to > > walterzy...@apache.org, that can be found in keys file: > > • https://downloads.apache.org/incubator/eventmesh/KEYS > > > > The vote will be open for at least 72 hours or until necessary > > number of votes are reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > Thanks, > > On behalf of Apache EventMesh(Incubating) community > > > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > -- > > > -- > Best Regards > > DolphinScheduler PMC > Gang Li 李岗 > > lgcar...@apache.org - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache EventMesh (incubating) 1.8.0-rc2
+1 (binding) I checked - All files have license header if necessary. - LICENSE and NOTICE files exist - Include the word incubating in the release file name. - DISCLAIMER-WIP file exist - Signatures are fine Three are two issues need to be fixed next release. 1、There are a lot of duplicated line of "This product includes software developed at the Apache Software Foundation...",need to clean up those lines[1]. 2、The license [2] is triple-licensed and you should select which license applies. [1]https://infra.apache.org/licensing-howto.html#bundle-asf-product [2]src/tools/third-party-licenses/licenses/java/LICENSE-amqp-client.txt walterzywei 于2023年1月18日周三 20:23写道： > Hello Incubator Community, > > This is a call for a vote to release Apache EventMesh(Incubating) > version 1.8.0-rc2 > > The Apache EventMesh community has voted on and approved a > proposal to release > Apache EventMesh(Incubating) version 1.8.0-rc2 > > We now kindly request the Incubator PMC members review and vote on this > incubator release. > > EventMesh community vote thread: > • https://lists.apache.org/thread/z6p2kxw2l1zv641fsx4bhjgtmdh4xwyg > > Vote result thread: > • https://lists.apache.org/thread/16js8nnlbypy203snxk2fqzt3vjz1yg5 > > The release candidate: > • https://dist.apache.org/repos/dist/dev/incubator/eventmesh/1.8.0-rc2 > > Git tag for the release: > • https://github.com/apache/incubator-eventmesh/tree/v1.8.0-rc2 > Release notes: > • https://eventmesh.apache.org/events/release-notes/v1.8.0 > > The artifacts signed with PGP key > 16D5190EA34AC32AE3CE05A753FF44C181774D3F, corresponding to > walterzy...@apache.org, that can be found in keys file: > • https://downloads.apache.org/incubator/eventmesh/KEYS > > The vote will be open for at least 72 hours or until necessary > number of votes are reached. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thanks, > On behalf of Apache EventMesh(Incubating) community > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- -- Best Regards DolphinScheduler PMC Gang Li 李岗 lgcar...@apache.org
Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2
Thanks for review and feedback, streampark project does included the source code of the maven-wrapper project, We will add the license information of maven-wrapper to LICENSE file. Best, Huajie Wang kezhenxu94 于2023年1月28日周六 22:15写道： > > > On Jan 28, 2023, at 21:43, Justin Mclean > wrote: > > > > Hi, > > > >> 2. NOTICE is OK but I’m not sure if the maven wrapper code is included > in > >> the source release? > >> > >> the maven wrapper code is not included in the source code[1] > > But I can see the maven wrapper scripts are included in the source tar > ball. > > ```shell > ~ % tar -tf > /Users/kezhenxu94/Downloads/apache-streampark-2.0.0-incubating-src.tar.gz > | grep mvnw > apache-streampark-2.0.0-incubating-src/mvnw > apache-streampark-2.0.0-incubating-src/mvnw.cmd > > apache-streampark-2.0.0-incubating-src/streampark-console/streampark-console-service/src/main/assembly/bin/mvnw > > apache-streampark-2.0.0-incubating-src/streampark-console/streampark-console-service/src/main/assembly/bin/mvnw.cmd > > ``` > > > > Thanks for your feedback, it is really redundant to mention in the > NOTICE file, We will fix it. > > So I think you want to add the license information to LICENSE file, > instead of removing them from NOTICE file. > > > > > Kind Regards, > > Justin > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re:[VOTE] Release Apache EventMesh (incubating) 1.8.0-rc2
+1, I have checked: [√] Download links are valid. [√] Checksums and PGP signatures are valid. [√] DISCLAIMER is included. [√] Source code artifacts have correct names matching the current release. [√] LICENSE and NOTICE files are correct for each EventMesh repo. [√] All files have license headers if necessary. [√] No compiled archives bundled in source archive. At 2023-01-18 20:23:00, "walterzywei" wrote: >Hello Incubator Community, > >This is a call for a vote to release Apache EventMesh(Incubating) >version 1.8.0-rc2 > >The Apache EventMesh community has voted on and approved a >proposal to release >Apache EventMesh(Incubating) version 1.8.0-rc2 > >We now kindly request the Incubator PMC members review and vote on this >incubator release. > >EventMesh community vote thread: >• https://lists.apache.org/thread/z6p2kxw2l1zv641fsx4bhjgtmdh4xwyg > >Vote result thread: >• https://lists.apache.org/thread/16js8nnlbypy203snxk2fqzt3vjz1yg5 > >The release candidate: >• https://dist.apache.org/repos/dist/dev/incubator/eventmesh/1.8.0-rc2 > >Git tag for the release: >• https://github.com/apache/incubator-eventmesh/tree/v1.8.0-rc2 >Release notes: >• https://eventmesh.apache.org/events/release-notes/v1.8.0 > >The artifacts signed with PGP key >16D5190EA34AC32AE3CE05A753FF44C181774D3F, corresponding to >walterzy...@apache.org, that can be found in keys file: >• https://downloads.apache.org/incubator/eventmesh/KEYS > >The vote will be open for at least 72 hours or until necessary >number of votes are reached. > >Please vote accordingly: > >[ ] +1 approve >[ ] +0 no opinion >[ ] -1 disapprove with the reason > >Thanks, >On behalf of Apache EventMesh(Incubating) community > >- >To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2
> On Jan 28, 2023, at 21:43, Justin Mclean wrote: > > Hi, > >> 2. NOTICE is OK but I’m not sure if the maven wrapper code is included in >> the source release? >> >> the maven wrapper code is not included in the source code[1] But I can see the maven wrapper scripts are included in the source tar ball. ```shell ~ % tar -tf /Users/kezhenxu94/Downloads/apache-streampark-2.0.0-incubating-src.tar.gz | grep mvnw apache-streampark-2.0.0-incubating-src/mvnw apache-streampark-2.0.0-incubating-src/mvnw.cmd apache-streampark-2.0.0-incubating-src/streampark-console/streampark-console-service/src/main/assembly/bin/mvnw apache-streampark-2.0.0-incubating-src/streampark-console/streampark-console-service/src/main/assembly/bin/mvnw.cmd ``` > Thanks for your feedback, it is really redundant to mention in the NOTICE > file, We will fix it. So I think you want to add the license information to LICENSE file, instead of removing them from NOTICE file. > > Kind Regards, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2
On Sat, Jan 28, 2023 at 9:52 PM Huajie Wang wrote: > > Hi Justin: > > Thanks for your feedback, it is really redundant to mention in the NOTICE > file, We will fix it. I checked the source package and I'm pretty sure your mvnw.cmd and mvnw files are sourced from the maven-wrapper project. > > > Justin Mclean 于2023年1月28日周六 21:44写道： > > > Hi, > > > > > 2. NOTICE is OK but I’m not sure if the maven wrapper code is included in > > > the source release? > > > > > > the maven wrapper code is not included in the source code[1] > > > > Then why is it mention in the NOTICE file? > > > > Kind Regards, > > Justin > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > -- Best wishes！ CalvinKirs - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2
Hi Justin: Thanks for your feedback, it is really redundant to mention in the NOTICE file, We will fix it. Justin Mclean 于2023年1月28日周六 21:44写道： > Hi, > > > 2. NOTICE is OK but I’m not sure if the maven wrapper code is included in > > the source release? > > > > the maven wrapper code is not included in the source code[1] > > Then why is it mention in the NOTICE file? > > Kind Regards, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2
Hi, > 2. NOTICE is OK but I’m not sure if the maven wrapper code is included in > the source release? > > the maven wrapper code is not included in the source code[1] Then why is it mention in the NOTICE file? Kind Regards, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
[CANCEL][VOTE] Release Apache StreamPark 2.0.0-RC2
Hello Incubator Community: I'm cancelling this vote: https://lists.apache.org/thread/f8jqzbqvhnwn6y8gf9yov1ox9oz4797v because of license issues. I'll fix them and start the round 3 vote process. There are some License related issues we need to fixed: 1. remove google-fonts from the front-end module to fixed fonts license issues Thanks a lot for all your help.
Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2
Hi Justin, Thanks for your review, we'll fix the problems you mentioned. We need to fix some license related issues: 1. LICENSE is missing license information for fonts under we'll remove google-fonts from the front-end module, 2. NOTICE is OK but I’m not sure if the maven wrapper code is included in the source release? the maven wrapper code is not included in the source code[1] 3. The last RC mentioned other 3rd party software in the source release - has it been removed? Yes, we remove the other 3rd party source code[2] in the source release [1] https://github.com/apache/incubator-streampark/blob/dev/mvnw [1] https://github.com/apache/incubator-streampark/blob/dev/.mvn/wrapper [2] https://github.com/apache/incubator-streampark/pull/2195 If anything is wrong please let us know, this vote is closed. Justin Mclean 于2023年1月28日周六 16:36写道： > Hi, > > Sorry I’it -1 binding from me. > > I checked in the source release: > - incubating in name > - signatures and hashes are fine > - LICENSE is missing license information for fonts under [1]. It looks > like this is this font [2] licensed under the Open Font License a category > B license. [3] Normally this could not be included in a source release, but > in this case as it’s not code I think it’s OK, but you need need to include > the license. > - NOTICE is OK but I’m not sure if the maven wrapper code is included in > the source release? > - no unexpected binary file > - expected file has ASF headers > - can compile from source > > The last RC mentioned other 3rd party software in the source release - has > it been removed? > > Kind Regards, > Justin > > 1. ./streampark-console/streampark-console-webapp/public/resource/fonts > 2. https://fonts.google.com/specimen/Poppins/about > 3. https://www.apache.org/legal/resolved.html > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2
> > Hi Justin, > > Thanks for your review, we'll fix the problems you mentioned. > > We need to fix some license related issues: > > 1. LICENSE is missing license information for fonts under > > We'll remove google-fonts from the front-end module, > > > 2. NOTICE is OK but I’m not sure if the maven wrapper code is included in > the source release? > > The maven wrapper code is not included in the source code[1] > > > 3. The last RC mentioned other 3rd party software in the source release - > has it been removed? > Yes, we remove the other 3rd party sourcecode[2] in the source release > > > [1] https://github.com/apache/incubator-streampark/blob/dev/mvnw > [1] https://github.com/apache/incubator-streampark/blob/dev/.mvn/wrapper > [2] https://github.com/apache/incubator-streampark/pull/2195 > > > If anything is wrong please let us know, this vote is closed. >
Re: [VOTE] Release Apache StreamPark(Incubating) 2.0.0-RC2
Hi, Sorry I’it -1 binding from me. I checked in the source release: - incubating in name - signatures and hashes are fine - LICENSE is missing license information for fonts under [1]. It looks like this is this font [2] licensed under the Open Font License a category B license. [3] Normally this could not be included in a source release, but in this case as it’s not code I think it’s OK, but you need need to include the license. - NOTICE is OK but I’m not sure if the maven wrapper code is included in the source release? - no unexpected binary file - expected file has ASF headers - can compile from source The last RC mentioned other 3rd party software in the source release - has it been removed? Kind Regards, Justin 1. ./streampark-console/streampark-console-webapp/public/resource/fonts 2. https://fonts.google.com/specimen/Poppins/about 3. https://www.apache.org/legal/resolved.html - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
