Hi Justin, Thanks for your replyment, I fixed the license and notice issue in https://github.com/apache/incubator-fury/pull/1507 according to the advice from this thread and PJ.
Best Regards, Chaokun Yang On Sun, Apr 14, 2024 at 9:07 AM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > Any license information goes in LICENSE, not NOTICE. If you include > something that is MIT or BSD licensed, nothing goes in the NOTICE. The > NOTICE file will include re-located copyright statements removed from files > and the contents of any Apache code you have included NOTICE files. > > 1. is BSD licensed, so just put the text in LICENSE > 2. is Apache licensed, It’s a good idea to list that in the LICENSE file > (but not required). It has no NOTICE file, so there is nothing to go in > your NOTICE file. > > Kind Regards, > Justin > > > On 13 Apr 2024, at 3:53 pm, Shawn Yang <shawn.ck.y...@gmail.com> wrote: > > > > Dear Community, > > > > I'm fixing the license issue of Apache Fury to comply with ASF > requirements > > for the first release for Fury under ASF. > > > > Currently we borrowed some code from other projects such as > > v8-fast-api-calls.h[1] in v8 and Preconditions[2] in guava. We mentioned > > their license in our NOTICE file[3]. > > > > I'm wondering whether we should move those mentions into the LICENSE > file, > > and mention the NOTICE of those projects in our NOTICE instead. > > > > I did some research, but didn't know which is better: > > 1) Projects like flink[4] and pytorch[5] mention the license of other > > projects in the NOTICE file. > > 2) But other projects such as spark[6] and arrow[7] all put the mentions > > into the `LICENSE` file. > > > > Are those both ways legal? Do we have a best practice here? > > > > 1. > > > https://github.com/apache/incubator-fury/blob/main/javascript/packages/hps/src/v8-fast-api-calls.h > > 2. > > > https://github.com/apache/incubator-fury/blob/main/java/fury-core/src/main/java/org/apache/fury/util/Preconditions.java > > 3. https://github.com/apache/incubator-fury/blob/main/NOTICE > > 4. https://github.com/apache/opendal/blob/master/NOTICE > > 5. https://github.com/pytorch/pytorch/blob/main/NOTICE > > 6. https://github.com/apache/spark/blob/master/LICENSE > > 7. tttps://github.com/apache/arrow/blob/main/LICENSE.txt > > > > > > Best regards, > > Chaokun Yang > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
