[RESULT] [VOTE] Release Apache DolphinScheduler (Incubating) 1.2.1

2020-02-23 Thread lgcareer2...@outlook.com
Hi All,

Release vote for Release Apache DolphinScheduler (Incubating) 1.2.1 has PASSED 
and closed now. The results are as follows:


[3] +1 Binded votes
- Justin Mclean
- Sheng Wu
- ShaoFeng Shi

[ 0 ] +0  Binded Votes
[ 0 ] -1  Binded Votes

Thanks for everyone, especially for IPMCs who checked and voted to help this 
version released. I will process to publish the release and send ANNOUNCE later.




DolphinScheduler(Incubator) PPMC
Gang Li 李岗

lgcareer2...@outlook.com


Re: Re: [VOTE] Release Apache DolphinScheduler (Incubating) 1.2.1

2020-02-20 Thread lgcareer2...@outlook.com
Thanks for issues,Thanks for voting.We will fix the issues following in nex 
release.



DolphinScheduler(Incubator) PPMC
Gang Li 李岗

lgcareer2...@outlook.com<mailto:lgcareer2...@outlook.com>
 
From: Justin Mclean
Date: 2020-02-21 10:12
To: general
Subject: Re: [VOTE] Release Apache DolphinScheduler (Incubating) 1.2.1
HI,
 
+1 (binding) there are some license issues but they are to do with permissive 
licenses. My vote is conditional on this being fixed for the next release. 
Other IPMC member might consider voting -1.
 
I checked:
- incubating in name
- signatures and hashes are fine
- DISCLAIMER exists (not WIP)
- LICENSE is missing some items
- NOTICE is missing information
- Some file are missing ASF headers [3][4][5] although it could be argued that 
these are not very interesting files.
- No unexpected binaries
- can compile from source
 
LICENSE is missing license information on this file [1]. Given that the file is 
only a "Slightly modified version” it should IMO not have an ASF header.
LICENSE is missing information in these files [2][3] and missing the text of 
the license as required by the MIT license.
 
For [1] does a NOTICE file exist? If so information from that NOTICE file would 
need to be moved into your NOTICE file.
 
BTW a simple Rat check showed the above issues are you using rat and looking at 
the output?
 
Thanks,
Justin
 
1. 
./dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ScriptRunner.java
2. ./dolphinscheduler-ui/src/sass/common/_animation.scss
3. /dolphinscheduler-ui/src/sass/common/_normalize.scss
4. ./docker/docker-compose.yml
5. ./dolphinscheduler-ui/src/lib/external/config.js
6../dolphinscheduler-ui/src/lib/external/email.js
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
 


Re: [VOTE] Release Apache DolphinScheduler (Incubating) 1.2.1

2020-02-20 Thread Justin Mclean
HI,

+1 (binding) there are some license issues but they are to do with permissive 
licenses. My vote is conditional on this being fixed for the next release. 
Other IPMC member might consider voting -1.

I checked:
- incubating in name
- signatures and hashes are fine
- DISCLAIMER exists (not WIP)
- LICENSE is missing some items
- NOTICE is missing information
- Some file are missing ASF headers [3][4][5] although it could be argued that 
these are not very interesting files.
- No unexpected binaries
- can compile from source

LICENSE is missing license information on this file [1]. Given that the file is 
only a "Slightly modified version” it should IMO not have an ASF header.
LICENSE is missing information in these files [2][3] and missing the text of 
the license as required by the MIT license.

For [1] does a NOTICE file exist? If so information from that NOTICE file would 
need to be moved into your NOTICE file.

BTW a simple Rat check showed the above issues are you using rat and looking at 
the output?

Thanks,
Justin

1. 
./dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ScriptRunner.java
2. ./dolphinscheduler-ui/src/sass/common/_animation.scss
3. /dolphinscheduler-ui/src/sass/common/_normalize.scss
4. ./docker/docker-compose.yml
5. ./dolphinscheduler-ui/src/lib/external/config.js
6../dolphinscheduler-ui/src/lib/external/email.js
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



[VOTE] Release Apache DolphinScheduler (Incubating) 1.2.1

2020-02-19 Thread lgcareer2...@outlook.com

Hello everyone,

This is a call for vote to release Apache DolphinScheduler (Incubating) version 
1.2.1.

The Apache DolphinScheduler community has voted on and approved a proposal to 
release
Apache DolphinScheduler (Incubating) version 1.2.1.

We now kindly request the Incubator IPMC members review and vote on this 
incubator release.

Dolphin Scheduler is a distributed and easy-to-expand visual DAG workflow 
scheduling system, 
dedicated to solving the complex dependencies in data processing, making the 
scheduling system out of the box for data processing.

DolphinScheduler community vote and result threads:
https://lists.apache.org/thread.html/ra379eb0c20e6f813dcabe0f795cb0d6812dd1547b90d044c9dbcec68%40%3Cdev.dolphinscheduler.apache.org%3E

https://lists.apache.org/thread.html/r5db9d82597c99aa5de22e4b4b65613ece35107ad8534f526e0be798b%40%3Cdev.dolphinscheduler.apache.org%3E

Release notes:
https://github.com/apache/incubator-dolphinscheduler/blob/1.2.1/ReleaseNotes.md

The release candidates:
https://dist.apache.org/repos/dist/dev/incubator/dolphinscheduler/1.2.1/

Maven 2 staging repository:
https://repository.apache.org/content/repositories/orgapachedolphinscheduler-1018/org/apache/dolphinscheduler/

Git tag for the release:
https://github.com/apache/incubator-dolphinscheduler/tree/1.2.1

Release Commit ID:
https://github.com/apache/incubator-dolphinscheduler/commit/84a4f50caa4f0ea2abdeb0ea12c10f2f4b3f6907

Keys to verify the Release Candidate:
https://dist.apache.org/repos/dist/dev/incubator/dolphinscheduler/KEYS

Look at here for how to verify this release candidate:
https://dolphinscheduler.apache.org/en-us/docs/development/release.html

The vote will be open for at least 72 hours or until necessary number of votes 
are reached.
Please vote accordingly:

[ ] +1 approveg

[ ] +0 no opinion

[ ] -1 disapprove with the reason

Checklist for reference:

[ ] Download links are valid.

[ ] Checksums and PGP signatures are valid.

[ ] Source code artifacts have correct names matching the current release.

[ ] LICENSE and NOTICE files are correct for each DolphinScheduler repo.

[ ] All files have license headers if necessary.

[ ] No compiled archives bundled in source archive.

More detail checklist  please refer:
https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist

The following votes are carried over from DolphinScheduler dev mailing list,

+1 binding, Sheng Wu
+1 binding, ShaoFeng Shi




DolphinScheduler(Incubator) PPMC
Gang Li 李岗

lgcareer2...@outlook.com