[RESULT] [VOTE] Release Apache Hop (incubating) 0.99-rc4
Hello IPMC, The vote to release Apache Hop (incubating) 0.99 - RC4 has passed. +1 (binding): - Julian Hyde - Justin Mclean - François Papon - Kevin Ratnasekera +1 (non-binding) - Xun Liu +0 -1 (binding) -1 (non-binding) Thank you for reviewing this release candidate. Cheers, Hans
Re: [VOTE] Release Apache Hop (incubating) 0.99-rc4
+1 ( binding ) I checked the following. - Incubating in name. - PGP Signatures. - SHA512 Checksums. - DISCLAIMER exists. - LICENSE and NOTICE are fine. - Maven Build passes on MacOS. ( Maven - 3.6.3 JAVA - AdoptOpenJDK Java 1.8.0_252 ). Regards Kevin On Thu, Aug 5, 2021 at 12:31 AM Julian Hyde wrote: > +1 (binding) > > Downloaded, checked signatures, built using “./mvnw clean install > -DskipTests" and Java 8 on Ubuntu 20.04.2 LTS. Followed build instructions > in README.md. Checked LICENSE, NOTICE, DISCLAIMER; ran RAT. > > Note: It’s nothing to do with this release, but before you go 1.0 I think > you should remove the “a lot of things may be broken” language from > README.md. > > Julian > > > > On Aug 3, 2021, at 5:12 AM, fpa...@apache.org wrote: > > > > +1 (binding) > > > > regards, > > > > François > > fpa...@apache.org > > > > Le 02/08/2021 à 12:58, Hans Van Akelyen a écrit : > >> Hi All, > >> > >> This release candidate resolves the issues around Imported Source code. > >> As discussed in the following mail thread [1] we identified the code > that > >> was added from external sources after starting the incubator and removed > >> it. > >> > >> This release candidate also includes all changes that were marked for > the > >> 1.0 release. > >> For a detailed list on what was added after our initial 0.99 cutoff > point > >> and now you can see list [2]. > >> > >> Build instructions can be found in the README included. > >> > >> Hop community vote and result threads: > >> Vote: > >> > https://lists.apache.org/thread.html/r43840a74ba1b126268915c1ae4afd42f8ef9cbfe77da84bf0adef21b%40%3Cdev.hop.apache.org%3E > >> > >> Result: > >> > https://lists.apache.org/thread.html/rdb792ed9542758c0c430db8aa3e1494a28006a35d6f39b9d58b66e2c%40%3Cdev.hop.apache.org%3E > >> > >> The tag to be voted on is 0.99-rc4 (commit 069d67e): > >> https://github.com/apache/incubator-hop/tree/0.99-rc4 > >> > >> The release files, including signatures, digests, etc. can be found at: > >> > https://dist.apache.org/repos/dist/dev/incubator/hop/apache-hop-0.99-incubating-rc4/ > >> > >> The SHA512 Checksum for these artifacts is: > >> Source: > 38d3b318b8e7a19fe381be3727a467c0b842d5c46a7e534f8cc4671bed11e17124ad34af271e351101e54780b5084ad3366d0b8c2c06d1db11f608fada304804 > >> > >> Client: > 97fccb1ac74b0198c1db63109a7374d48ff252eb8ffbe3721941229defcf0d136fb7185895bffcdfa096f111717d75770617f989e2b3fc4f73f55cf33419c333 > >> > >> Release artifacts are signed with the following key: > >> > https://keyserver.ubuntu.com/pks/lookup?op=get=0x9a8a628dd4f4aa1e > >> > >> For more information about the contents of this release, see: > >> https://issues.apache.org/jira/projects/HOP/versions/12350036 > >> > >> Please vote on releasing this package as Apache Hop (incubating) 0.99! > >> > >> The vote is open for 72 hours and passes if > >> a majority of at least 3 +1 PMC votes are cast. > >> > >> [ ] +1 Release this package as Apache Hop (incubating) 0.99 > >> [ ] +0 No opinion > >> [ ] -1 Do not release this package because ... > >> > >> Best Regards, > >> Hans > >> > >> [1] > >> > https://lists.apache.org/thread.html/r3b04392a62d7bbe45fa214e6a4e3bd3ec1ec34b8e2db660508785a50%40%3Cdev.hop.apache.org%3E > >> > >> [2] > >> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20HOP%20AND%20fixVersion%20%3D%200.99%20AND%20resolved%20%3E%3D%202021-06-06%20AND%20resolved%20%3C%3D%202021-07-28 > >> > > > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Hop (incubating) 0.99-rc4
+1 (binding) Downloaded, checked signatures, built using “./mvnw clean install -DskipTests" and Java 8 on Ubuntu 20.04.2 LTS. Followed build instructions in README.md. Checked LICENSE, NOTICE, DISCLAIMER; ran RAT. Note: It’s nothing to do with this release, but before you go 1.0 I think you should remove the “a lot of things may be broken” language from README.md. Julian > On Aug 3, 2021, at 5:12 AM, fpa...@apache.org wrote: > > +1 (binding) > > regards, > > François > fpa...@apache.org > > Le 02/08/2021 à 12:58, Hans Van Akelyen a écrit : >> Hi All, >> >> This release candidate resolves the issues around Imported Source code. >> As discussed in the following mail thread [1] we identified the code that >> was added from external sources after starting the incubator and removed >> it. >> >> This release candidate also includes all changes that were marked for the >> 1.0 release. >> For a detailed list on what was added after our initial 0.99 cutoff point >> and now you can see list [2]. >> >> Build instructions can be found in the README included. >> >> Hop community vote and result threads: >> Vote: >> https://lists.apache.org/thread.html/r43840a74ba1b126268915c1ae4afd42f8ef9cbfe77da84bf0adef21b%40%3Cdev.hop.apache.org%3E >> >> Result: >> https://lists.apache.org/thread.html/rdb792ed9542758c0c430db8aa3e1494a28006a35d6f39b9d58b66e2c%40%3Cdev.hop.apache.org%3E >> >> The tag to be voted on is 0.99-rc4 (commit 069d67e): >> https://github.com/apache/incubator-hop/tree/0.99-rc4 >> >> The release files, including signatures, digests, etc. can be found at: >> https://dist.apache.org/repos/dist/dev/incubator/hop/apache-hop-0.99-incubating-rc4/ >> >> The SHA512 Checksum for these artifacts is: >> Source: >> 38d3b318b8e7a19fe381be3727a467c0b842d5c46a7e534f8cc4671bed11e17124ad34af271e351101e54780b5084ad3366d0b8c2c06d1db11f608fada304804 >> >> Client: >> 97fccb1ac74b0198c1db63109a7374d48ff252eb8ffbe3721941229defcf0d136fb7185895bffcdfa096f111717d75770617f989e2b3fc4f73f55cf33419c333 >> >> Release artifacts are signed with the following key: >> https://keyserver.ubuntu.com/pks/lookup?op=get=0x9a8a628dd4f4aa1e >> >> For more information about the contents of this release, see: >> https://issues.apache.org/jira/projects/HOP/versions/12350036 >> >> Please vote on releasing this package as Apache Hop (incubating) 0.99! >> >> The vote is open for 72 hours and passes if >> a majority of at least 3 +1 PMC votes are cast. >> >> [ ] +1 Release this package as Apache Hop (incubating) 0.99 >> [ ] +0 No opinion >> [ ] -1 Do not release this package because ... >> >> Best Regards, >> Hans >> >> [1] >> https://lists.apache.org/thread.html/r3b04392a62d7bbe45fa214e6a4e3bd3ec1ec34b8e2db660508785a50%40%3Cdev.hop.apache.org%3E >> >> [2] >> https://issues.apache.org/jira/issues/?jql=project%20%3D%20HOP%20AND%20fixVersion%20%3D%200.99%20AND%20resolved%20%3E%3D%202021-06-06%20AND%20resolved%20%3C%3D%202021-07-28 >> > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Hop (incubating) 0.99-rc4
+1 (binding) regards, François fpa...@apache.org Le 02/08/2021 à 12:58, Hans Van Akelyen a écrit : > Hi All, > > This release candidate resolves the issues around Imported Source code. > As discussed in the following mail thread [1] we identified the code that > was added from external sources after starting the incubator and removed > it. > > This release candidate also includes all changes that were marked for the > 1.0 release. > For a detailed list on what was added after our initial 0.99 cutoff point > and now you can see list [2]. > > Build instructions can be found in the README included. > > Hop community vote and result threads: > Vote: > https://lists.apache.org/thread.html/r43840a74ba1b126268915c1ae4afd42f8ef9cbfe77da84bf0adef21b%40%3Cdev.hop.apache.org%3E > > Result: > https://lists.apache.org/thread.html/rdb792ed9542758c0c430db8aa3e1494a28006a35d6f39b9d58b66e2c%40%3Cdev.hop.apache.org%3E > > The tag to be voted on is 0.99-rc4 (commit 069d67e): > https://github.com/apache/incubator-hop/tree/0.99-rc4 > > The release files, including signatures, digests, etc. can be found at: > https://dist.apache.org/repos/dist/dev/incubator/hop/apache-hop-0.99-incubating-rc4/ > > The SHA512 Checksum for these artifacts is: > Source: > 38d3b318b8e7a19fe381be3727a467c0b842d5c46a7e534f8cc4671bed11e17124ad34af271e351101e54780b5084ad3366d0b8c2c06d1db11f608fada304804 > > Client: > 97fccb1ac74b0198c1db63109a7374d48ff252eb8ffbe3721941229defcf0d136fb7185895bffcdfa096f111717d75770617f989e2b3fc4f73f55cf33419c333 > > Release artifacts are signed with the following key: > https://keyserver.ubuntu.com/pks/lookup?op=get=0x9a8a628dd4f4aa1e > > For more information about the contents of this release, see: > https://issues.apache.org/jira/projects/HOP/versions/12350036 > > Please vote on releasing this package as Apache Hop (incubating) 0.99! > > The vote is open for 72 hours and passes if > a majority of at least 3 +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Hop (incubating) 0.99 > [ ] +0 No opinion > [ ] -1 Do not release this package because ... > > Best Regards, > Hans > > [1] > https://lists.apache.org/thread.html/r3b04392a62d7bbe45fa214e6a4e3bd3ec1ec34b8e2db660508785a50%40%3Cdev.hop.apache.org%3E > > [2] > https://issues.apache.org/jira/issues/?jql=project%20%3D%20HOP%20AND%20fixVersion%20%3D%200.99%20AND%20resolved%20%3E%3D%202021-06-06%20AND%20resolved%20%3C%3D%202021-07-28 > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Hop (incubating) 0.99-rc4
HI, > In the client zip we have a THIRD-PARTY.txt which should list all > dependencies and their licenses [1]. A dependancy list is different to what needs to go in LICENSE, only what is included in the release needs to listed in LICENSE. Kind Regards, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Hop (incubating) 0.99-rc4
HI Justin, Thanks for the check, we will look into it. In the client zip we have a THIRD-PARTY.txt which should list all dependencies and their licenses [1]. I suppose this should then be included in the LICENSE file and we should go over all the dependencies to see what needs to be included in the notice file? Just to make sure we get it right next release. Cheers, Hans [1] https://github.com/apache/incubator-hop/blob/master/assemblies/static/src/main/resources/THIRD-PARTY.txt On Tue, 3 Aug 2021 at 08:59, Justin Mclean wrote: > Hi, > > +1 (binding) but LICENSE needs to be updated and there’s a few piece of > 3rd party code who licenses need to be clarified. Please fix these before > ether next release. > > I checked: > - incubating in name > - signatures and hashes are fine > - There is a 3rd party file here [1] that is not mentioned in LICENSE > - All file have ASF headers > - No unexpected binary files > - did not compile > > There is also code in here [2][3] that has been copied form [4] and is an > unknown license. My guess this is OK to use [5] but it should be mentioned > in LICENSE. There is also 3rd party code here [6]. How is this licensed? Is > there any other 3rd party code in the release? > > The LICENSE and NOTICE of apache-hop-client-0.99-incubating.zip are not > correct as they don’t reflect what is in that release artefact. The LICENSE > and NOTICE of binary files is often different to the source as they can > contain a lot more more 3rd party software. > > Kind Regards, > Justin > > 1. ./.mvn/wrapper/MavenWrapperDownloader.java > 2. > ./apache-hop-0.99-incubating/plugins/transforms/mailvalidator/src/main/java/org/apache/hop/pipeline/transforms/mailvalidator/MailValidation.java > 3. > ./apache-hop-0.99-incubating/plugins/actions/mailvalidator/src/main/java/org/apache/hop/workflow/actions/mailvalidator/MailValidation.java > 4. https://www.rgagnon.com/javadetails/java-0452.html > 5. https://www.rgagnon.com/varia/faq-e.html > 6 > ./apache-hop-0.99-incubating/core/src/main/java/org/apache/hop/core/util/Utils.java > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Hop (incubating) 0.99-rc4
Hi, +1 (binding) but LICENSE needs to be updated and there’s a few piece of 3rd party code who licenses need to be clarified. Please fix these before ether next release. I checked: - incubating in name - signatures and hashes are fine - There is a 3rd party file here [1] that is not mentioned in LICENSE - All file have ASF headers - No unexpected binary files - did not compile There is also code in here [2][3] that has been copied form [4] and is an unknown license. My guess this is OK to use [5] but it should be mentioned in LICENSE. There is also 3rd party code here [6]. How is this licensed? Is there any other 3rd party code in the release? The LICENSE and NOTICE of apache-hop-client-0.99-incubating.zip are not correct as they don’t reflect what is in that release artefact. The LICENSE and NOTICE of binary files is often different to the source as they can contain a lot more more 3rd party software. Kind Regards, Justin 1. ./.mvn/wrapper/MavenWrapperDownloader.java 2. ./apache-hop-0.99-incubating/plugins/transforms/mailvalidator/src/main/java/org/apache/hop/pipeline/transforms/mailvalidator/MailValidation.java 3. ./apache-hop-0.99-incubating/plugins/actions/mailvalidator/src/main/java/org/apache/hop/workflow/actions/mailvalidator/MailValidation.java 4. https://www.rgagnon.com/javadetails/java-0452.html 5. https://www.rgagnon.com/varia/faq-e.html 6 ./apache-hop-0.99-incubating/core/src/main/java/org/apache/hop/core/util/Utils.java - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Hop (incubating) 0.99-rc4
+1 (non-binding) from me, I have checked the following items: - Incubating in name - LICENSE and NOTICE are fine - DISCLAIMER exists - All links are valid - No unexpected binary files - All ASF files have ASF headers - RAT - compile (with tests) Best regards Xun Liu On Mon, Aug 2, 2021 at 6:58 PM Hans Van Akelyen wrote: > Hi All, > > This release candidate resolves the issues around Imported Source code. > As discussed in the following mail thread [1] we identified the code that > was added from external sources after starting the incubator and removed > it. > > This release candidate also includes all changes that were marked for the > 1.0 release. > For a detailed list on what was added after our initial 0.99 cutoff point > and now you can see list [2]. > > Build instructions can be found in the README included. > > Hop community vote and result threads: > Vote: > > https://lists.apache.org/thread.html/r43840a74ba1b126268915c1ae4afd42f8ef9cbfe77da84bf0adef21b%40%3Cdev.hop.apache.org%3E > > Result: > > https://lists.apache.org/thread.html/rdb792ed9542758c0c430db8aa3e1494a28006a35d6f39b9d58b66e2c%40%3Cdev.hop.apache.org%3E > > The tag to be voted on is 0.99-rc4 (commit 069d67e): > https://github.com/apache/incubator-hop/tree/0.99-rc4 > > The release files, including signatures, digests, etc. can be found at: > > https://dist.apache.org/repos/dist/dev/incubator/hop/apache-hop-0.99-incubating-rc4/ > > The SHA512 Checksum for these artifacts is: > Source: > 38d3b318b8e7a19fe381be3727a467c0b842d5c46a7e534f8cc4671bed11e17124ad34af271e351101e54780b5084ad3366d0b8c2c06d1db11f608fada304804 > > Client: > 97fccb1ac74b0198c1db63109a7374d48ff252eb8ffbe3721941229defcf0d136fb7185895bffcdfa096f111717d75770617f989e2b3fc4f73f55cf33419c333 > > Release artifacts are signed with the following key: > https://keyserver.ubuntu.com/pks/lookup?op=get=0x9a8a628dd4f4aa1e > > For more information about the contents of this release, see: > https://issues.apache.org/jira/projects/HOP/versions/12350036 > > Please vote on releasing this package as Apache Hop (incubating) 0.99! > > The vote is open for 72 hours and passes if > a majority of at least 3 +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Hop (incubating) 0.99 > [ ] +0 No opinion > [ ] -1 Do not release this package because ... > > Best Regards, > Hans > > [1] > > https://lists.apache.org/thread.html/r3b04392a62d7bbe45fa214e6a4e3bd3ec1ec34b8e2db660508785a50%40%3Cdev.hop.apache.org%3E > > [2] > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20HOP%20AND%20fixVersion%20%3D%200.99%20AND%20resolved%20%3E%3D%202021-06-06%20AND%20resolved%20%3C%3D%202021-07-28 >
[VOTE] Release Apache Hop (incubating) 0.99-rc4
Hi All, This release candidate resolves the issues around Imported Source code. As discussed in the following mail thread [1] we identified the code that was added from external sources after starting the incubator and removed it. This release candidate also includes all changes that were marked for the 1.0 release. For a detailed list on what was added after our initial 0.99 cutoff point and now you can see list [2]. Build instructions can be found in the README included. Hop community vote and result threads: Vote: https://lists.apache.org/thread.html/r43840a74ba1b126268915c1ae4afd42f8ef9cbfe77da84bf0adef21b%40%3Cdev.hop.apache.org%3E Result: https://lists.apache.org/thread.html/rdb792ed9542758c0c430db8aa3e1494a28006a35d6f39b9d58b66e2c%40%3Cdev.hop.apache.org%3E The tag to be voted on is 0.99-rc4 (commit 069d67e): https://github.com/apache/incubator-hop/tree/0.99-rc4 The release files, including signatures, digests, etc. can be found at: https://dist.apache.org/repos/dist/dev/incubator/hop/apache-hop-0.99-incubating-rc4/ The SHA512 Checksum for these artifacts is: Source: 38d3b318b8e7a19fe381be3727a467c0b842d5c46a7e534f8cc4671bed11e17124ad34af271e351101e54780b5084ad3366d0b8c2c06d1db11f608fada304804 Client: 97fccb1ac74b0198c1db63109a7374d48ff252eb8ffbe3721941229defcf0d136fb7185895bffcdfa096f111717d75770617f989e2b3fc4f73f55cf33419c333 Release artifacts are signed with the following key: https://keyserver.ubuntu.com/pks/lookup?op=get=0x9a8a628dd4f4aa1e For more information about the contents of this release, see: https://issues.apache.org/jira/projects/HOP/versions/12350036 Please vote on releasing this package as Apache Hop (incubating) 0.99! The vote is open for 72 hours and passes if a majority of at least 3 +1 PMC votes are cast. [ ] +1 Release this package as Apache Hop (incubating) 0.99 [ ] +0 No opinion [ ] -1 Do not release this package because ... Best Regards, Hans [1] https://lists.apache.org/thread.html/r3b04392a62d7bbe45fa214e6a4e3bd3ec1ec34b8e2db660508785a50%40%3Cdev.hop.apache.org%3E [2] https://issues.apache.org/jira/issues/?jql=project%20%3D%20HOP%20AND%20fixVersion%20%3D%200.99%20AND%20resolved%20%3E%3D%202021-06-06%20AND%20resolved%20%3C%3D%202021-07-28
