Re: Are tests part of the release?
thanks for your feedback, i canceled the vote, we fixed the deps and startet a new vote. On Mon, Aug 10, 2015 at 3:45 PM, Bertrand Delacretaz wrote: > On Mon, Aug 10, 2015 at 11:11 AM, jan i wrote: >> ...we do not have a demand that a release must contain a >> test set, so if the release >> does not contain the test we cannot see it as broken, or ?... > > From the ASF's point of view you are correct, having tests in a > release is not required. > > OTOH releasing code without tests is...well, suboptimal. But nobody's > perfect of course. > > In Hendrik's case IIUC the tests are present but somewhat broken by > depending on Maven snapshots, which makes it a buggy release - but > releases are not always perfect either, and I suspect in their case > the workaround is easy: release said snapshot and instruct people to > replace the appropriate references. That makes it a just a known issue > in that release, with a known workaround. > > -Bertrand > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > -- Hendrik Saly (salyh, hendrikdev22) @hendrikdev22 PGP: 0x22D7F6EC - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: Are tests part of the release?
On Mon, Aug 10, 2015 at 11:11 AM, jan i wrote: > ...we do not have a demand that a release must contain a > test set, so if the release > does not contain the test we cannot see it as broken, or ?... >From the ASF's point of view you are correct, having tests in a release is not required. OTOH releasing code without tests is...well, suboptimal. But nobody's perfect of course. In Hendrik's case IIUC the tests are present but somewhat broken by depending on Maven snapshots, which makes it a buggy release - but releases are not always perfect either, and I suspect in their case the workaround is easy: release said snapshot and instruct people to replace the appropriate references. That makes it a just a known issue in that release, with a known workaround. -Bertrand - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: Are tests part of the release?
On 10 August 2015 at 10:33, Bertrand Delacretaz wrote: > On Sun, Aug 9, 2015 at 10:43 AM, Hendrik Dev > wrote: > > ...We have (accidentally) a dependency to a snapshot version > > for a library but only in maven scope... > > To me this means that release is broken, if I cannot test it I cannot > trust it. > > Not like Fully Absolutely Fatally broken, but still broken ;-) > I agree with you, everything contained in the release must work. but at the same time, we do not have a demand that a release must contain a test set, so if the release does not contain the test we cannot see it as broken, or ? rgds jan i. > > -Bertrand > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: Are tests part of the release?
On Sun, Aug 9, 2015 at 10:43 AM, Hendrik Dev wrote: > ...We have (accidentally) a dependency to a snapshot version > for a library but only in maven scope... To me this means that release is broken, if I cannot test it I cannot trust it. Not like Fully Absolutely Fatally broken, but still broken ;-) -Bertrand - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: Are tests part of the release?
On Sun, Aug 9, 2015 at 5:29 AM, Romain Manni-Bucau wrote: > A tag should be buildable anytime. Snapshots can be dropped from repos so > from my understanding it is an issue even if less impacting than direct > binaries dependencies. To me the above is exactly the way to think about this issue: if that -SNAPSHOT disappears, can I still build your release? Thanks, Roman. - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: Are tests part of the release?
On Aug 9, 2015 4:05 AM, "Justin Mclean" wrote: > > Hi, > > > Are tests are part of the release? > > If they are included as source code in the released artefact yes :-) Well put. The Apache HTTP Server has several 'test' modules which are embedded in release tarballs. The 'test framework' is an eternal work in progress and has never been proposed for release, httpd devs simply consume and expand test/framework/trunk/ as new exceptions or interesting subjects for testing are identified. Not sure it has ever been tagged or branched even until recently.
Re: Are tests part of the release?
@john: no since it would likely be deleted and has no link with revisions so it is still highly mutable Le 9 août 2015 07:11, "John D. Ament" a écrit : > And if you're using a snapshot, just switch to the timestamp based > snapshot. > > On Sun, Aug 9, 2015 at 8:29 AM Romain Manni-Bucau > wrote: > > > A tag should be buildable anytime. Snapshots can be dropped from repos so > > from my understanding it is an issue even if less impacting than direct > > binaries dependencies. > > Le 9 août 2015 02:05, "Justin Mclean" a > écrit : > > > > > Hi, > > > > > > > Are tests are part of the release? > > > > > > If they are included as source code in the released artefact yes :-) > > > > > > > Background: We have (accidentally) a dependency to a snapshot version > > > > for a library but only in maven scope. > > > > > > Up to the project I’d say, but I’d just raise a JIRA and fix it next > > > release/before graduation if a VOTE is already underway. > > > > > > I could be mistaken but seem to recall other incubator releases that > > > depended on a snapshot or two. > > > > > > Thanks, > > > Justin > > > - > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > >
Re: Are tests part of the release?
And if you're using a snapshot, just switch to the timestamp based snapshot. On Sun, Aug 9, 2015 at 8:29 AM Romain Manni-Bucau wrote: > A tag should be buildable anytime. Snapshots can be dropped from repos so > from my understanding it is an issue even if less impacting than direct > binaries dependencies. > Le 9 août 2015 02:05, "Justin Mclean" a écrit : > > > Hi, > > > > > Are tests are part of the release? > > > > If they are included as source code in the released artefact yes :-) > > > > > Background: We have (accidentally) a dependency to a snapshot version > > > for a library but only in maven scope. > > > > Up to the project I’d say, but I’d just raise a JIRA and fix it next > > release/before graduation if a VOTE is already underway. > > > > I could be mistaken but seem to recall other incubator releases that > > depended on a snapshot or two. > > > > Thanks, > > Justin > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
Re: Are tests part of the release?
A tag should be buildable anytime. Snapshots can be dropped from repos so from my understanding it is an issue even if less impacting than direct binaries dependencies. Le 9 août 2015 02:05, "Justin Mclean" a écrit : > Hi, > > > Are tests are part of the release? > > If they are included as source code in the released artefact yes :-) > > > Background: We have (accidentally) a dependency to a snapshot version > > for a library but only in maven scope. > > Up to the project I’d say, but I’d just raise a JIRA and fix it next > release/before graduation if a VOTE is already underway. > > I could be mistaken but seem to recall other incubator releases that > depended on a snapshot or two. > > Thanks, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: Are tests part of the release?
Hi, > Are tests are part of the release? If they are included as source code in the released artefact yes :-) > Background: We have (accidentally) a dependency to a snapshot version > for a library but only in maven scope. Up to the project I’d say, but I’d just raise a JIRA and fix it next release/before graduation if a VOTE is already underway. I could be mistaken but seem to recall other incubator releases that depended on a snapshot or two. Thanks, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: Are tests part of the release?
On 9 August 2015 at 10:43, Hendrik Dev wrote: > Are tests are part of the release? > It is not a mandatory part, the project defines the content of the release. I work with a.o. Corinthia, there we have some test cases that will not be released, but most will, for dependency reasons. Eventually those test cases will be rewritten. rgds jan i. > > Background: We have (accidentally) a dependency to a snapshot version > for a library but only in maven scope. > > Thanks > Hendrik > > -- > Hendrik Saly (salyh, hendrikdev22) > @hendrikdev22 > PGP: 0x22D7F6EC > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Are tests part of the release?
Are tests are part of the release? Background: We have (accidentally) a dependency to a snapshot version for a library but only in maven scope. Thanks Hendrik -- Hendrik Saly (salyh, hendrikdev22) @hendrikdev22 PGP: 0x22D7F6EC - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
