Re: [VOTE] Pulsar Release 1.22.1-incubating Candidate 2
Repeating my +1 (binding) from the dev@pulsar VOTE Regards, Dave Sent from my iPhone > On Jun 7, 2018, at 11:29 AM, Jai Asher wrote: > > This is the second release candidate for Apache Pulsar, patch release > version 1.22.1-incubating. > > It fixes the following issues: > https://github.com/apache/incubator-pulsar/milestone/15?closed=1 > > *** Please download, test and vote on this release. This vote will stay > open for at least 72 hours *** > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Source and binary files: > https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-1.22.1-incubating-candidate-2/ > > SHA-1 checksums: > > f2d29aa5e046c5bdefd8f466bce8e9ead80a2e09 > apache-pulsar-1.22.1-incubating-src.tar.gz > f2704cae22b7fb3c1b72daab6ebe7d484fdfec6b > apache-pulsar-1.22.1-incubating-bin.tar.gz > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachepulsar-1018/ > > The tag to be voted upon: > v1.22.1-incubating-candidate-2 (c9a369936af3b3ecc663b86ae959a3fbfa627aca) > https://github.com/apache/incubator-pulsar/releases/tag/v1.22.1-incubating-candidate-2 > > Pulsar's KEYS file containing PGP keys we use to sign the release: > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS > > Please download the source package, and follow the README to build and run > the Pulsar standalone service. - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Pulsar Release 1.22.1-incubating Candidate 2
+1 (repeated my +1 from dev@ votes) On Thu, Jun 7, 2018 at 11:29 AM Jai Asher wrote: > This is the second release candidate for Apache Pulsar, patch release > version 1.22.1-incubating. > > It fixes the following issues: > https://github.com/apache/incubator-pulsar/milestone/15?closed=1 > > *** Please download, test and vote on this release. This vote will stay > open for at least 72 hours *** > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Source and binary files: > > https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-1.22.1-incubating-candidate-2/ > > SHA-1 checksums: > > f2d29aa5e046c5bdefd8f466bce8e9ead80a2e09 > apache-pulsar-1.22.1-incubating-src.tar.gz > f2704cae22b7fb3c1b72daab6ebe7d484fdfec6b > apache-pulsar-1.22.1-incubating-bin.tar.gz > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachepulsar-1018/ > > The tag to be voted upon: > v1.22.1-incubating-candidate-2 (c9a369936af3b3ecc663b86ae959a3fbfa627aca) > > https://github.com/apache/incubator-pulsar/releases/tag/v1.22.1-incubating-candidate-2 > > Pulsar's KEYS file containing PGP keys we use to sign the release: > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS > > Please download the source package, and follow the README to build and run > the Pulsar standalone service. >
Re: [VOTE] Pulsar Release 1.22.1-incubating Candidate 2
Hi,
I checked the source release and found a minor issue:
pulsar-common/src/main/java/org/apache/pulsar/common/util/protobuf/ByteBufCoded{Input,Output}Stream.java
Those files are from google thus should not have ASF header in the source
file.
On Fri, Jun 8, 2018 at 9:51 AM, Sijie Guo wrote:
> +1 (repeated my +1 from dev@ votes)
>
> On Thu, Jun 7, 2018 at 11:29 AM Jai Asher wrote:
>
> > This is the second release candidate for Apache Pulsar, patch release
> > version 1.22.1-incubating.
> >
> > It fixes the following issues:
> > https://github.com/apache/incubator-pulsar/milestone/15?closed=1
> >
> > *** Please download, test and vote on this release. This vote will stay
> > open for at least 72 hours ***
> >
> > Note that we are voting upon the source (tag), binaries are provided for
> > convenience.
> >
> > Source and binary files:
> >
> > https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> pulsar-1.22.1-incubating-candidate-2/
> >
> > SHA-1 checksums:
> >
> > f2d29aa5e046c5bdefd8f466bce8e9ead80a2e09
> > apache-pulsar-1.22.1-incubating-src.tar.gz
> > f2704cae22b7fb3c1b72daab6ebe7d484fdfec6b
> > apache-pulsar-1.22.1-incubating-bin.tar.gz
> >
> > Maven staging repo:
> > https://repository.apache.org/content/repositories/orgapachepulsar-1018/
> >
> > The tag to be voted upon:
> > v1.22.1-incubating-candidate-2 (c9a369936af3b3ecc663b86ae959a3
> fbfa627aca)
> >
> > https://github.com/apache/incubator-pulsar/releases/tag/
> v1.22.1-incubating-candidate-2
> >
> > Pulsar's KEYS file containing PGP keys we use to sign the release:
> > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> >
> > Please download the source package, and follow the README to build and
> run
> > the Pulsar standalone service.
> >
>
--
Best Regards,
Yang.
Re: [VOTE] Pulsar Release 1.22.1-incubating Candidate 2
Hi Yang,
these files are not directly found in Protobuf, though their content is
derived from Protobuf code, though with several additions. These are
special adapters to have protobuf to interact directly with Netty ByteBuf
with zero-copy access. Based on an earlier discussion, the resolution was
to have both headers as well as a comment that says:
/**
* This file is derived from Google ProcolBuffer CodedInputStream class
*/
Matteo
On Thu, Jun 7, 2018 at 7:22 PM Yang Bo wrote:
> Hi,
>
> I checked the source release and found a minor issue:
>
> pulsar-common/src/main/java/org/apache/pulsar/common/util/protobuf/ByteBufCoded{Input,Output}Stream.java
> Those files are from google thus should not have ASF header in the source
> file.
>
>
> On Fri, Jun 8, 2018 at 9:51 AM, Sijie Guo wrote:
>
> > +1 (repeated my +1 from dev@ votes)
> >
> > On Thu, Jun 7, 2018 at 11:29 AM Jai Asher wrote:
> >
> > > This is the second release candidate for Apache Pulsar, patch release
> > > version 1.22.1-incubating.
> > >
> > > It fixes the following issues:
> > > https://github.com/apache/incubator-pulsar/milestone/15?closed=1
> > >
> > > *** Please download, test and vote on this release. This vote will stay
> > > open for at least 72 hours ***
> > >
> > > Note that we are voting upon the source (tag), binaries are provided
> for
> > > convenience.
> > >
> > > Source and binary files:
> > >
> > > https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> > pulsar-1.22.1-incubating-candidate-2/
> > >
> > > SHA-1 checksums:
> > >
> > > f2d29aa5e046c5bdefd8f466bce8e9ead80a2e09
> > > apache-pulsar-1.22.1-incubating-src.tar.gz
> > > f2704cae22b7fb3c1b72daab6ebe7d484fdfec6b
> > > apache-pulsar-1.22.1-incubating-bin.tar.gz
> > >
> > > Maven staging repo:
> > >
> https://repository.apache.org/content/repositories/orgapachepulsar-1018/
> > >
> > > The tag to be voted upon:
> > > v1.22.1-incubating-candidate-2 (c9a369936af3b3ecc663b86ae959a3
> > fbfa627aca)
> > >
> > > https://github.com/apache/incubator-pulsar/releases/tag/
> > v1.22.1-incubating-candidate-2
> > >
> > > Pulsar's KEYS file containing PGP keys we use to sign the release:
> > > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> > >
> > > Please download the source package, and follow the README to build and
> > run
> > > the Pulsar standalone service.
> > >
> >
>
>
>
> --
> Best Regards,
> Yang.
>
--
Matteo Merli
Re: [VOTE] Pulsar Release 1.22.1-incubating Candidate 2
Hi Matteo,
Having 2 different license headers for a source files is a bit strange, the
user would be confused what license the file actually uses.
The 3Clause-BSD license allows us to modify and redistribute in source
form, but I'm not sure whether it's OK to re-license it to ASL.
On Fri, Jun 8, 2018 at 2:17 PM, Matteo Merli wrote:
> Hi Yang,
>
> these files are not directly found in Protobuf, though their content is
> derived from Protobuf code, though with several additions. These are
> special adapters to have protobuf to interact directly with Netty ByteBuf
> with zero-copy access. Based on an earlier discussion, the resolution was
> to have both headers as well as a comment that says:
>
> /**
> * This file is derived from Google ProcolBuffer CodedInputStream class
> */
>
> Matteo
>
> On Thu, Jun 7, 2018 at 7:22 PM Yang Bo wrote:
>
> > Hi,
> >
> > I checked the source release and found a minor issue:
> >
> > pulsar-common/src/main/java/org/apache/pulsar/common/util/
> protobuf/ByteBufCoded{Input,Output}Stream.java
> > Those files are from google thus should not have ASF header in the source
> > file.
> >
> >
> > On Fri, Jun 8, 2018 at 9:51 AM, Sijie Guo wrote:
> >
> > > +1 (repeated my +1 from dev@ votes)
> > >
> > > On Thu, Jun 7, 2018 at 11:29 AM Jai Asher
> wrote:
> > >
> > > > This is the second release candidate for Apache Pulsar, patch release
> > > > version 1.22.1-incubating.
> > > >
> > > > It fixes the following issues:
> > > > https://github.com/apache/incubator-pulsar/milestone/15?closed=1
> > > >
> > > > *** Please download, test and vote on this release. This vote will
> stay
> > > > open for at least 72 hours ***
> > > >
> > > > Note that we are voting upon the source (tag), binaries are provided
> > for
> > > > convenience.
> > > >
> > > > Source and binary files:
> > > >
> > > > https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> > > pulsar-1.22.1-incubating-candidate-2/
> > > >
> > > > SHA-1 checksums:
> > > >
> > > > f2d29aa5e046c5bdefd8f466bce8e9ead80a2e09
> > > > apache-pulsar-1.22.1-incubating-src.tar.gz
> > > > f2704cae22b7fb3c1b72daab6ebe7d484fdfec6b
> > > > apache-pulsar-1.22.1-incubating-bin.tar.gz
> > > >
> > > > Maven staging repo:
> > > >
> > https://repository.apache.org/content/repositories/orgapachepulsar-1018/
> > > >
> > > > The tag to be voted upon:
> > > > v1.22.1-incubating-candidate-2 (c9a369936af3b3ecc663b86ae959a3
> > > fbfa627aca)
> > > >
> > > > https://github.com/apache/incubator-pulsar/releases/tag/
> > > v1.22.1-incubating-candidate-2
> > > >
> > > > Pulsar's KEYS file containing PGP keys we use to sign the release:
> > > > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> > > >
> > > > Please download the source package, and follow the README to build
> and
> > > run
> > > > the Pulsar standalone service.
> > > >
> > >
> >
> >
> >
> > --
> > Best Regards,
> > Yang.
> >
> --
> Matteo Merli
>
>
--
Best Regards,
Yang.
Re: [VOTE] Pulsar Release 1.22.1-incubating Candidate 2
Hi, Please remove the .md5 hashes. +1 binding I checked: - incubating in name - signatures and hashes correct - LICENSE is fine - NOTICE is OK but has wrong year please fix - no unexpected binary files - source files have headers - can compile from source I think I agree with Matteo that those protobuf files should not have an ASF header. Generally changes to a file are under the original license, see [1], but it not a big issue as BSD is an Category A license and you are including the full license text. It’s also seems odd because the license calls them out as BSD licensed. Thanks, Justin 1. https://www.apache.org/legal/src-headers.html#3party - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Pulsar Release 1.22.1-incubating Candidate 2
I'll add my own chimes to this discussion. > On Jun 10, 2018, at 2:57 AM, Justin Mclean wrote: > ... > I think I agree with Matteo that those protobuf files should not have an ASF > header. Generally changes to a file are under the original license, see [1], > but it not a big issue as BSD is an Category A license and you are including > the full license text. It’s also seems odd because the license calls them out > as BSD licensed. Yes, these files are not being relicensed. Files that are covered by an ICLA by the original author, or covered by a software grant can be relicensed. In that case, removing the BSD license header and replacing it by the Apache license header is appropriate. In this case of a BSD-licensed file that has minor changes, the Apache license header is inappropriate. The only part of the file that is Apache-licensed is the changes made here. So the Apache license header that states that this file is "Licensed to the Apache Software Foundation ... under one or more contributor license agreements" is not correct. The comment line "This file is derived from Google ProcolBuffer CodedInputStream class" is sufficient documentation, without the Apache license header. Regards, Craig > > Thanks, > Justin > > 1. https://www.apache.org/legal/src-headers.html#3party > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > Craig L Russell Secretary, Apache Software Foundation c...@apache.org http://db.apache.org/jdo - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Pulsar Release 1.22.1-incubating Candidate 2
+1 (if not too late) - binding > On Jun 7, 2018, at 2:29 PM, Jai Asher wrote: > > This is the second release candidate for Apache Pulsar, patch release > version 1.22.1-incubating. > > It fixes the following issues: > https://github.com/apache/incubator-pulsar/milestone/15?closed=1 > > *** Please download, test and vote on this release. This vote will stay > open for at least 72 hours *** > > Note that we are voting upon the source (tag), binaries are provided for > convenience. > > Source and binary files: > https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-1.22.1-incubating-candidate-2/ > > SHA-1 checksums: > > f2d29aa5e046c5bdefd8f466bce8e9ead80a2e09 > apache-pulsar-1.22.1-incubating-src.tar.gz > f2704cae22b7fb3c1b72daab6ebe7d484fdfec6b > apache-pulsar-1.22.1-incubating-bin.tar.gz > > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachepulsar-1018/ > > The tag to be voted upon: > v1.22.1-incubating-candidate-2 (c9a369936af3b3ecc663b86ae959a3fbfa627aca) > https://github.com/apache/incubator-pulsar/releases/tag/v1.22.1-incubating-candidate-2 > > Pulsar's KEYS file containing PGP keys we use to sign the release: > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS > > Please download the source package, and follow the README to build and run > the Pulsar standalone service. - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Pulsar Release 1.22.1-incubating Candidate 2
Thanks Yang, Justin and Craig for the discussion. We will correct these files by removing ASF header, leaving only BSD header + comment. Matteo On Sun, Jun 10, 2018 at 9:59 AM Craig Russell wrote: > I'll add my own chimes to this discussion. > > > On Jun 10, 2018, at 2:57 AM, Justin Mclean > wrote: > > ... > > I think I agree with Matteo that those protobuf files should not have an > ASF header. Generally changes to a file are under the original license, see > [1], but it not a big issue as BSD is an Category A license and you are > including the full license text. It’s also seems odd because the license > calls them out as BSD licensed. > > Yes, these files are not being relicensed. Files that are covered by an > ICLA by the original author, or covered by a software grant can be > relicensed. In that case, removing the BSD license header and replacing it > by the Apache license header is appropriate. > > In this case of a BSD-licensed file that has minor changes, the Apache > license header is inappropriate. The only part of the file that is > Apache-licensed is the changes made here. So the Apache license header that > states that this file is "Licensed to the Apache Software Foundation ... > under one or more contributor license agreements" is not correct. > > The comment line "This file is derived from Google ProcolBuffer > CodedInputStream class" is sufficient documentation, without the Apache > license header. > > Regards, > > Craig > > > > > Thanks, > > Justin > > > > 1. https://www.apache.org/legal/src-headers.html#3party > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > Craig L Russell > Secretary, Apache Software Foundation > c...@apache.org http://db.apache.org/jdo > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > > -- Matteo Merli
Re: [VOTE] Pulsar Release 1.22.1-incubating Candidate 2
The vote for releasing Apache Pulsar 1.22.1-incubating is now closed. With a total of +3 binding votes and no -1 votes, the vote passes. +1s (binding): Dave Justin Jim This is the link to the dev@ vote thread for the same, will update the release process to add this link in the initial mail next release onwards - Thanks Dave for pointing this out. https://lists.apache.org/thread.html/27dbe3f467d2df18bf2799b480d66194bf8943f7fd764ecb9d15773c@%3Cdev.pulsar.apache.org%3E Thanks, Yang, Justin and Craig for your inputs on the ASF and BSD header - we will correct these files by removing ASF header, leaving only BSD header. On Mon, Jun 11, 2018 at 9:30 AM, Matteo Merli wrote: > Thanks Yang, Justin and Craig for the discussion. > > We will correct these files by removing ASF header, leaving only BSD header > + comment. > > Matteo > > On Sun, Jun 10, 2018 at 9:59 AM Craig Russell > wrote: > > > I'll add my own chimes to this discussion. > > > > > On Jun 10, 2018, at 2:57 AM, Justin Mclean > > wrote: > > > ... > > > I think I agree with Matteo that those protobuf files should not have > an > > ASF header. Generally changes to a file are under the original license, > see > > [1], but it not a big issue as BSD is an Category A license and you are > > including the full license text. It’s also seems odd because the license > > calls them out as BSD licensed. > > > > Yes, these files are not being relicensed. Files that are covered by an > > ICLA by the original author, or covered by a software grant can be > > relicensed. In that case, removing the BSD license header and replacing > it > > by the Apache license header is appropriate. > > > > In this case of a BSD-licensed file that has minor changes, the Apache > > license header is inappropriate. The only part of the file that is > > Apache-licensed is the changes made here. So the Apache license header > that > > states that this file is "Licensed to the Apache Software Foundation ... > > under one or more contributor license agreements" is not correct. > > > > The comment line "This file is derived from Google ProcolBuffer > > CodedInputStream class" is sufficient documentation, without the Apache > > license header. > > > > Regards, > > > > Craig > > > > > > > > Thanks, > > > Justin > > > > > > 1. https://www.apache.org/legal/src-headers.html#3party > > > - > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > Craig L Russell > > Secretary, Apache Software Foundation > > c...@apache.org http://db.apache.org/jdo > > > > > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > -- > Matteo Merli > >
