Re: [VOTE] Release Apache Druid (incubating) 0.15.1 [RC2]
>Given you have soured files from all those project the minimum would be the project name and copyright line, I’m not seeing that. [1] I've opened a PR to adjust NOTICE and NOTICE.BINARY files to include the copyright notices which were previously removed, https://github.com/apache/incubator-druid/pull/8298 >I believe it’s either public domain or the copyright has expired deepening on teh versions you use but it’s not easy to find out. It not an issue, just a curiosity. Might as well be on the safe side, the text didn't matter it was being used for some sort of compression test so I just replaced it with the apache license text, https://github.com/apache/incubator-druid/pull/8299 >My guess is that you would need permission from the people who content is in that file, that’s probably going to be hard to obtain, so it may be best to replace it with something else if possible. I've opened an issue to resolve the licensing issues or replace the file with different example data to use for the quickstart tutorials and integration tests, https://github.com/apache/incubator-druid/issues/8300 Thanks for the feedback, will try to get stuff fixed up before the next release! On Tue, Aug 13, 2019 at 4:36 PM William Guo wrote: > +1 > > I checked: > > - Can compile from source > - No unexpected binary files > - Source files have ASF headers > - incubating in name > - signatures and hashes fine > - LICENSE is fine > > > Thanks, > William > > On Wed, Aug 14, 2019 at 6:59 AM Furkan KAMACI > wrote: > > > Hi, > > > > +1 from me. > > > > I checked: > > - Incubating in name > > - Disclaimer exists > > - LICENSE is fine > > - No unexpected binary files > > - Code compiles and tests successfully run > > > > Kind Regards, > > Furkan KAMACI > > > > 13 Ağu 2019 Sal, saat 13:04 tarihinde Justin Mclean < > > jus...@classsoftware.com> şunu yazdı: > > > > > Hi, > > > > > > > I was not directly involved in this, but it is my understanding that > > the > > > > modifications to our source NOTICE file between 0.15.0-incubating and > > > this > > > > version are a result of this thread on the IPMC vote, > > > > > > > > > > https://mail-archives.apache.org/mod_mbox/incubator-general/201906.mbox/%3CCAOGo0VZoqnNuMdBsbiPB1gzqdR_WAp8wyBx7jeANaKKkm6pavQ%40mail.gmail.com%3E > > > . > > > > which suggested that the NOTICE files should contain only what is > > > strictly > > > > required for the files actually contained in the bundle to which they > > > > apply. > > > > > > Given you have soured files from all those project the minimum would be > > > the project name and copyright line, I’m not seeing that. [1] > > > > > > > With regards to the 'lorem ipsum' text, I am unsure of how this is > > > licensed > > > > and somewhat surprised how hard this seems to be to find out > > > > > > I believe it’s either public domain or the copyright has expired > > deepening > > > on teh versions you use but it’s not easy to find out. It not an issue, > > > just a curiosity. > > > > > > > I believe the wikiticker-2015-09-12-sampled.json.gz data was > collected > > > by Gian Merlino > > > > from an IRC channel where a bot prints out all wikipedia edit > activity > > in > > > > real-ish time. I don't know and haven't yet found out the ownership > > > details > > > > of the contents of that IRC channel, I will try to follow-up and > > resolve > > > > this as soon as I figure out how to do so. > > > > > > My guess is that you would need permission from the people who content > is > > > in that file, that’s probably going to be hard to obtain, so it may be > > best > > > to replace it with something else if possible. > > > > > > Thanks, > > > Justin > > > > > > 1. http://www.apache.org/dev/licensing-howto.html#bundle-asf-product > > > - > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > >
Re: [VOTE] Release Apache Druid (incubating) 0.15.1 [RC2]
+1 I checked: - Can compile from source - No unexpected binary files - Source files have ASF headers - incubating in name - signatures and hashes fine - LICENSE is fine Thanks, William On Wed, Aug 14, 2019 at 6:59 AM Furkan KAMACI wrote: > Hi, > > +1 from me. > > I checked: > - Incubating in name > - Disclaimer exists > - LICENSE is fine > - No unexpected binary files > - Code compiles and tests successfully run > > Kind Regards, > Furkan KAMACI > > 13 Ağu 2019 Sal, saat 13:04 tarihinde Justin Mclean < > jus...@classsoftware.com> şunu yazdı: > > > Hi, > > > > > I was not directly involved in this, but it is my understanding that > the > > > modifications to our source NOTICE file between 0.15.0-incubating and > > this > > > version are a result of this thread on the IPMC vote, > > > > > > https://mail-archives.apache.org/mod_mbox/incubator-general/201906.mbox/%3CCAOGo0VZoqnNuMdBsbiPB1gzqdR_WAp8wyBx7jeANaKKkm6pavQ%40mail.gmail.com%3E > > . > > > which suggested that the NOTICE files should contain only what is > > strictly > > > required for the files actually contained in the bundle to which they > > > apply. > > > > Given you have soured files from all those project the minimum would be > > the project name and copyright line, I’m not seeing that. [1] > > > > > With regards to the 'lorem ipsum' text, I am unsure of how this is > > licensed > > > and somewhat surprised how hard this seems to be to find out > > > > I believe it’s either public domain or the copyright has expired > deepening > > on teh versions you use but it’s not easy to find out. It not an issue, > > just a curiosity. > > > > > I believe the wikiticker-2015-09-12-sampled.json.gz data was collected > > by Gian Merlino > > > from an IRC channel where a bot prints out all wikipedia edit activity > in > > > real-ish time. I don't know and haven't yet found out the ownership > > details > > > of the contents of that IRC channel, I will try to follow-up and > resolve > > > this as soon as I figure out how to do so. > > > > My guess is that you would need permission from the people who content is > > in that file, that’s probably going to be hard to obtain, so it may be > best > > to replace it with something else if possible. > > > > Thanks, > > Justin > > > > 1. http://www.apache.org/dev/licensing-howto.html#bundle-asf-product > > - > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > >
Re: [VOTE] Release Apache Druid (incubating) 0.15.1 [RC2]
Hi, +1 from me. I checked: - Incubating in name - Disclaimer exists - LICENSE is fine - No unexpected binary files - Code compiles and tests successfully run Kind Regards, Furkan KAMACI 13 Ağu 2019 Sal, saat 13:04 tarihinde Justin Mclean < jus...@classsoftware.com> şunu yazdı: > Hi, > > > I was not directly involved in this, but it is my understanding that the > > modifications to our source NOTICE file between 0.15.0-incubating and > this > > version are a result of this thread on the IPMC vote, > > > https://mail-archives.apache.org/mod_mbox/incubator-general/201906.mbox/%3CCAOGo0VZoqnNuMdBsbiPB1gzqdR_WAp8wyBx7jeANaKKkm6pavQ%40mail.gmail.com%3E > . > > which suggested that the NOTICE files should contain only what is > strictly > > required for the files actually contained in the bundle to which they > > apply. > > Given you have soured files from all those project the minimum would be > the project name and copyright line, I’m not seeing that. [1] > > > With regards to the 'lorem ipsum' text, I am unsure of how this is > licensed > > and somewhat surprised how hard this seems to be to find out > > I believe it’s either public domain or the copyright has expired deepening > on teh versions you use but it’s not easy to find out. It not an issue, > just a curiosity. > > > I believe the wikiticker-2015-09-12-sampled.json.gz data was collected > by Gian Merlino > > from an IRC channel where a bot prints out all wikipedia edit activity in > > real-ish time. I don't know and haven't yet found out the ownership > details > > of the contents of that IRC channel, I will try to follow-up and resolve > > this as soon as I figure out how to do so. > > My guess is that you would need permission from the people who content is > in that file, that’s probably going to be hard to obtain, so it may be best > to replace it with something else if possible. > > Thanks, > Justin > > 1. http://www.apache.org/dev/licensing-howto.html#bundle-asf-product > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Druid (incubating) 0.15.1 [RC2]
Hi, > I was not directly involved in this, but it is my understanding that the > modifications to our source NOTICE file between 0.15.0-incubating and this > version are a result of this thread on the IPMC vote, > https://mail-archives.apache.org/mod_mbox/incubator-general/201906.mbox/%3CCAOGo0VZoqnNuMdBsbiPB1gzqdR_WAp8wyBx7jeANaKKkm6pavQ%40mail.gmail.com%3E. > which suggested that the NOTICE files should contain only what is strictly > required for the files actually contained in the bundle to which they > apply. Given you have soured files from all those project the minimum would be the project name and copyright line, I’m not seeing that. [1] > With regards to the 'lorem ipsum' text, I am unsure of how this is licensed > and somewhat surprised how hard this seems to be to find out I believe it’s either public domain or the copyright has expired deepening on teh versions you use but it’s not easy to find out. It not an issue, just a curiosity. > I believe the wikiticker-2015-09-12-sampled.json.gz data was collected by > Gian Merlino > from an IRC channel where a bot prints out all wikipedia edit activity in > real-ish time. I don't know and haven't yet found out the ownership details > of the contents of that IRC channel, I will try to follow-up and resolve > this as soon as I figure out how to do so. My guess is that you would need permission from the people who content is in that file, that’s probably going to be hard to obtain, so it may be best to replace it with something else if possible. Thanks, Justin 1. http://www.apache.org/dev/licensing-howto.html#bundle-asf-product - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Druid (incubating) 0.15.1 [RC2]
+1 (binding) Checked hashes; in -src.tar.gz, checked license, notice, disclaimer, readme; compiled from source (skipping tests) on Ubuntu/JDK 8; ran RAT; checked that src tarball contents match git commit c698daa. Did not examine -bin.tar.gz. Julian > On Aug 9, 2019, at 5:28 PM, Justin Mclean wrote: > > Hi, > > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes fine > - LICENSE is fine > - NOTICE may need a little work > - No unexpected binary files > - Source files have ASF headers > - Can compile from source > > NOTICE mentions using code From Apache Hive, Apache Lucerne, Apache Hadoop > and Apache Calcite. Only Calcite is mentioned in your NOTICE file and all of > those projects have NOTICE files, Jets3t contains a NOTICE file [3] so I > think more needs to go in your NOTICE file. > > I am sort of curious how this is licensed [1] and if that should go in > LICENSE? (which I don’t think is an issue) and if you had permission from the > people to use and distribute the content in [2] > > Thanks, > Justin > > 1. core/src/test/resources/loremipsum.txt > 2. > apache-druid-0.15.1-incubating-src/examples/quickstart/tutorial/wikiticker-2015-09-12-sampled.json.gz > 3. https://bitbucket.org/jmurty/jets3t/src/default/NOTICE.txt > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Druid (incubating) 0.15.1 [RC2]
Hi Justin, Thank you so much for taking the time to have a look and for the +1 vote. > NOTICE mentions using code From Apache Hive, Apache Lucerne, Apache Hadoop and Apache Calcite. Only Calcite is mentioned in your NOTICE file and all of those projects have NOTICE files, Jets3t contains a NOTICE file [3] so I think more needs to go in your NOTICE file. I was not directly involved in this, but it is my understanding that the modifications to our source NOTICE file between 0.15.0-incubating and this version are a result of this thread on the IPMC vote, https://mail-archives.apache.org/mod_mbox/incubator-general/201906.mbox/%3CCAOGo0VZoqnNuMdBsbiPB1gzqdR_WAp8wyBx7jeANaKKkm6pavQ%40mail.gmail.com%3E. which suggested that the NOTICE files should contain only what is strictly required for the files actually contained in the bundle to which they apply. Based on this, only code we adapted from Apache Calcite fits this interpretation of how to construct NOTICE files, so we have removed the others that you listed for the source distribution NOTICE. NOTICE.BINARY still has the NOTICE file contents for those that you listed which we bundle (we don't bundle Lucene so it isn't present). https://github.com/apache/incubator-druid/pull/7945 is the pull request where the changes were done for reference. > I am sort of curious how this is licensed [1] and if that should go in LICENSE? (which I don’t think is an issue) and if you had permission from the people to use and distribute the content in [2] With regards to the 'lorem ipsum' text, I am unsure of how this is licensed and somewhat surprised how hard this seems to be to find out, but I will try to determine this (or replace the text with something else since it is just used for a compression test) before the next release. I believe the wikiticker-2015-09-12-sampled.json.gz data was collected by Gian Merlino from an IRC channel where a bot prints out all wikipedia edit activity in real-ish time. I don't know and haven't yet found out the ownership details of the contents of that IRC channel, I will try to follow-up and resolve this as soon as I figure out how to do so. Cheers, Clint On Fri, Aug 9, 2019 at 5:28 PM Justin Mclean wrote: > Hi, > > +1 (binding) > > I checked: > - incubating in name > - signatures and hashes fine > - LICENSE is fine > - NOTICE may need a little work > - No unexpected binary files > - Source files have ASF headers > - Can compile from source > > NOTICE mentions using code From Apache Hive, Apache Lucerne, Apache Hadoop > and Apache Calcite. Only Calcite is mentioned in your NOTICE file and all > of those projects have NOTICE files, Jets3t contains a NOTICE file [3] so I > think more needs to go in your NOTICE file. > > I am sort of curious how this is licensed [1] and if that should go in > LICENSE? (which I don’t think is an issue) and if you had permission from > the people to use and distribute the content in [2] > > Thanks, > Justin > > 1. core/src/test/resources/loremipsum.txt > 2. > apache-druid-0.15.1-incubating-src/examples/quickstart/tutorial/wikiticker-2015-09-12-sampled.json.gz > 3. https://bitbucket.org/jmurty/jets3t/src/default/NOTICE.txt > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Druid (incubating) 0.15.1 [RC2]
Hi, +1 (binding) I checked: - incubating in name - signatures and hashes fine - LICENSE is fine - NOTICE may need a little work - No unexpected binary files - Source files have ASF headers - Can compile from source NOTICE mentions using code From Apache Hive, Apache Lucerne, Apache Hadoop and Apache Calcite. Only Calcite is mentioned in your NOTICE file and all of those projects have NOTICE files, Jets3t contains a NOTICE file [3] so I think more needs to go in your NOTICE file. I am sort of curious how this is licensed [1] and if that should go in LICENSE? (which I don’t think is an issue) and if you had permission from the people to use and distribute the content in [2] Thanks, Justin 1. core/src/test/resources/loremipsum.txt 2. apache-druid-0.15.1-incubating-src/examples/quickstart/tutorial/wikiticker-2015-09-12-sampled.json.gz 3. https://bitbucket.org/jmurty/jets3t/src/default/NOTICE.txt - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
